Skip to content

Commit c11d59c

Browse files
committed
🚩(backend) add feature flag for the footer
We added the feature flag `FRONTEND_FOOTER_FEATURE_ENABLED` to enable or disable the footer in the frontend.
1 parent 8836109 commit c11d59c

File tree

7 files changed

+14
-2
lines changed

7 files changed

+14
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to
1010

1111
## Added
1212

13+
- 🚩(backend) add feature flag for the footer #841
1314
- 🔧(backend) add view to manage footer json #841
1415

1516
## Changed

env.d/development/common.dist

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,5 @@ COLLABORATION_WS_URL=ws://localhost:4444/collaboration/ws/
6464

6565
# Frontend
6666
FRONTEND_THEME=default
67+
FRONTEND_FOOTER_FEATURE_ENABLED=True
6768
FRONTEND_URL_JSON_FOOTER=http://frontend:3000/contents/footer-demo.json

src/backend/core/api/viewsets.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1692,6 +1692,7 @@ def get(self, request):
16921692
"CRISP_WEBSITE_ID",
16931693
"ENVIRONMENT",
16941694
"FRONTEND_CSS_URL",
1695+
"FRONTEND_FOOTER_FEATURE_ENABLED",
16951696
"FRONTEND_THEME",
16961697
"MEDIA_BASE_URL",
16971698
"POSTHOG_KEY",

src/backend/core/tests/test_api_config.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@
1818
@override_settings(
1919
COLLABORATION_WS_URL="http://testcollab/",
2020
CRISP_WEBSITE_ID="123",
21-
FRONTEND_THEME="test-theme",
2221
FRONTEND_CSS_URL="http://testcss/",
22+
FRONTEND_FOOTER_FEATURE_ENABLED=True,
23+
FRONTEND_THEME="test-theme",
2324
MEDIA_BASE_URL="http://testserver/",
2425
POSTHOG_KEY={"id": "132456", "host": "https://eu.i.posthog-test.com"},
2526
SENTRY_DSN="https://sentry.test/123",
@@ -39,8 +40,9 @@ def test_api_config(is_authenticated):
3940
"COLLABORATION_WS_URL": "http://testcollab/",
4041
"CRISP_WEBSITE_ID": "123",
4142
"ENVIRONMENT": "test",
42-
"FRONTEND_THEME": "test-theme",
4343
"FRONTEND_CSS_URL": "http://testcss/",
44+
"FRONTEND_FOOTER_FEATURE_ENABLED": True,
45+
"FRONTEND_THEME": "test-theme",
4446
"LANGUAGES": [
4547
["en-us", "English"],
4648
["fr-fr", "Français"],

src/backend/impress/settings.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,11 @@ class Base(Configuration):
413413
FRONTEND_URL_JSON_FOOTER = values.Value(
414414
None, environ_name="FRONTEND_URL_JSON_FOOTER", environ_prefix=None
415415
)
416+
FRONTEND_FOOTER_FEATURE_ENABLED = values.BooleanValue(
417+
default=False,
418+
environ_name="FRONTEND_FOOTER_FEATURE_ENABLED",
419+
environ_prefix=None,
420+
)
416421
FRONTEND_FOOTER_VIEW_CACHE_TIMEOUT = values.Value(
417422
60 * 60 * 24,
418423
environ_name="FRONTEND_FOOTER_VIEW_CACHE_TIMEOUT",

src/frontend/apps/e2e/__tests__/app-impress/config.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ const config = {
1010
COLLABORATION_WS_URL: 'ws://localhost:4444/collaboration/ws/',
1111
ENVIRONMENT: 'development',
1212
FRONTEND_CSS_URL: null,
13+
FRONTEND_FOOTER_FEATURE_ENABLED: true,
1314
FRONTEND_THEME: 'default',
1415
MEDIA_BASE_URL: 'http://localhost:8083',
1516
LANGUAGES: [

src/helm/env.d/dev/values.impress.yaml.gotmpl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ backend:
5050
DB_USER: dinum
5151
DB_PASSWORD: pass
5252
DB_PORT: 5432
53+
FRONTEND_FOOTER_FEATURE_ENABLED: true
5354
FRONTEND_URL_JSON_FOOTER: https://impress.127.0.0.1.nip.io/contents/footer-demo.json
5455
POSTGRES_DB: impress
5556
POSTGRES_USER: dinum

0 commit comments

Comments
 (0)