chapter 10 finished

Author: cfsamson

ch10/a-coroutines-variables/src/future.rs

@@ -1,13 +1,8 @@
-// NEW
-use std::{thread::Thread, sync::Arc};
-
 use crate::runtime::Waker;
-// END NEW
-
 
 pub trait Future {
     type Output;
-    ///////////////////////// NEW
+    
     fn poll(&mut self, waker: &Waker) -> PollState<Self::Output>;
 }
 
@@ -16,6 +11,7 @@ pub enum PollState<T> {
     NotReady,
 }
 
+#[allow(dead_code)]
 pub fn join_all<F: Future>(futures: Vec<F>) -> JoinAll<F> {
         let futures = futures.into_iter().map(|f| (false, f)).collect();
         JoinAll {

ch10/a-coroutines-variables/src/http.rs

@@ -1,6 +1,6 @@
 use std::io::{ErrorKind, Read, Write};
 
-use mio::{Interest, Registry, Token};
+use mio::Interest;
 
 use crate::{
     future::PollState,
@@ -55,17 +55,13 @@ impl Future for HttpGetFuture {
     type Output = String;
 
     fn poll(&mut self, waker: &Waker) -> PollState<Self::Output> {
-        // If this is first time polled, start the operation
-        // see: https://users.rust-lang.org/t/is-it-bad-behaviour-for-a-future-or-stream-to-do-something-before-being-polled/61353
-        // Avoid dns lookup this time
+
         if self.stream.is_none() {
             println!("FIRST POLL - START OPERATION");
             self.write_request();
-            // CHANGED
             let stream = self.stream.as_mut().unwrap();
             runtime::reactor().register(stream, Interest::READABLE, self.id);
             runtime::reactor().set_waker(waker, self.id);
-            // ============
         }
 
         let mut buff = vec![0u8; 147];
@@ -81,7 +77,6 @@ impl Future for HttpGetFuture {
                     continue;
                 }
                 Err(e) if e.kind() == ErrorKind::WouldBlock => {
-                    // always store the last given Waker
                     runtime::reactor().set_waker(waker, self.id);
                     break PollState::NotReady;
                 }

ch10/a-coroutines-variables/src/main.rs

@@ -1,7 +1,6 @@
 mod future;
 mod http;
 mod runtime;
-use crate::http::Http;
 use future::{Future, PollState};
 use runtime::Waker;
 

ch10/b-coroutines-references/src/future.rs

@@ -1,13 +1,7 @@
-// NEW
-use std::{thread::Thread, sync::Arc};
-
 use crate::runtime::Waker;
-// END NEW
-
 
 pub trait Future {
     type Output;
-    ///////////////////////// NEW
     fn poll(&mut self, waker: &Waker) -> PollState<Self::Output>;
 }
 
@@ -16,6 +10,7 @@ pub enum PollState<T> {
     NotReady,
 }
 
+#[allow(dead_code)]
 pub fn join_all<F: Future>(futures: Vec<F>) -> JoinAll<F> {
         let futures = futures.into_iter().map(|f| (false, f)).collect();
         JoinAll {
@@ -31,7 +26,7 @@ pub fn join_all<F: Future>(futures: Vec<F>) -> JoinAll<F> {
 
     impl<F: Future> Future for JoinAll<F> {
         type Output = String;
-        ////////////////////////// HERE
+
         fn poll(&mut self, waker: &Waker) -> PollState<Self::Output> {
             for (finished, fut) in self.futures.iter_mut() {
                 if *finished {

ch10/b-coroutines-references/src/http.rs

@@ -1,12 +1,10 @@
-use std::io::{ErrorKind, Read, Write};
-
-use mio::{Interest, Registry, Token};
-
 use crate::{
     future::PollState,
     runtime::{self, reactor, Waker},
     Future,
 };
+use mio::Interest;
+use std::io::{ErrorKind, Read, Write};
 
 fn get_req(path: &str) -> String {
     format!(
@@ -55,17 +53,12 @@ impl Future for HttpGetFuture {
     type Output = String;
 
     fn poll(&mut self, waker: &Waker) -> PollState<Self::Output> {
-        // If this is first time polled, start the operation
-        // see: https://users.rust-lang.org/t/is-it-bad-behaviour-for-a-future-or-stream-to-do-something-before-being-polled/61353
-        // Avoid dns lookup this time
         if self.stream.is_none() {
             println!("FIRST POLL - START OPERATION");
             self.write_request();
-            // CHANGED
             let stream = self.stream.as_mut().unwrap();
             runtime::reactor().register(stream, Interest::READABLE, self.id);
             runtime::reactor().set_waker(waker, self.id);
-            // ============
         }
 
         let mut buff = vec![0u8; 147];

ch10/b-coroutines-references/src/main.rs

@@ -1,7 +1,6 @@
 mod future;
 mod http;
 mod runtime;
-use crate::http::Http;
 use future::{Future, PollState};
 use runtime::Waker;
 use std::fmt::Write;

ch10/c-coroutines-problem/src/future.rs

@@ -1,13 +1,8 @@
-// NEW
-use std::{thread::Thread, sync::Arc};
-
 use crate::runtime::Waker;
-// END NEW
-
 
 pub trait Future {
     type Output;
-    ///////////////////////// NEW
+
     fn poll(&mut self, waker: &Waker) -> PollState<Self::Output>;
 }
 
@@ -16,6 +11,7 @@ pub enum PollState<T> {
     NotReady,
 }
 
+#[allow(dead_code)]
 pub fn join_all<F: Future>(futures: Vec<F>) -> JoinAll<F> {
         let futures = futures.into_iter().map(|f| (false, f)).collect();
         JoinAll {

ch10/c-coroutines-problem/src/http.rs

@@ -1,7 +1,6 @@
+use mio::Interest;
 use std::io::{ErrorKind, Read, Write};
 
-use mio::{Interest, Registry, Token};
-
 use crate::{
     future::PollState,
     runtime::{self, reactor, Waker},
@@ -55,17 +54,13 @@ impl Future for HttpGetFuture {
     type Output = String;
 
     fn poll(&mut self, waker: &Waker) -> PollState<Self::Output> {
-        // If this is first time polled, start the operation
-        // see: https://users.rust-lang.org/t/is-it-bad-behaviour-for-a-future-or-stream-to-do-something-before-being-polled/61353
-        // Avoid dns lookup this time
         if self.stream.is_none() {
             println!("FIRST POLL - START OPERATION");
             self.write_request();
-            // CHANGED
+
             let stream = self.stream.as_mut().unwrap();
             runtime::reactor().register(stream, Interest::READABLE, self.id);
             runtime::reactor().set_waker(waker, self.id);
-            // ============
         }
 
         let mut buff = vec![0u8; 147];
@@ -81,7 +76,6 @@ impl Future for HttpGetFuture {
                     continue;
                 }
                 Err(e) if e.kind() == ErrorKind::WouldBlock => {
-                    // always store the last given Waker
                     runtime::reactor().set_waker(waker, self.id);
                     break PollState::NotReady;
                 }

ch10/c-coroutines-problem/src/main.rs

@@ -1,7 +1,6 @@
 mod future;
 mod http;
 mod runtime;
-use crate::http::Http;
 use future::{Future, PollState};
 use runtime::Waker;
 

ch10/d-pin/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "x-pin-experiments"
+name = "d-pin"
 version = "0.1.0"
 edition = "2021"