Skip to content

Commit 0ed821c

Browse files
chore: remove unused test utility code (#387)
These functions are not used, so should be removed.
1 parent 2ece486 commit 0ed821c

File tree

1 file changed

+0
-38
lines changed

1 file changed

+0
-38
lines changed

spark/src/test/scala/io/substrait/spark/SubstraitPlanTestBase.scala

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -54,38 +54,6 @@ trait SubstraitPlanTestBase { self: SharedSparkSession =>
5454
} else Succeeded
5555
}
5656

57-
def sqlToProtoPlan(sql: String): proto.Plan = {
58-
val convert = new ToSubstraitRel()
59-
val logicalPlan = plan(sql)
60-
val substraitRel = convert.visit(logicalPlan)
61-
62-
val extensionCollector = new ExtensionCollector
63-
val relProtoConverter = new RelProtoConverter(extensionCollector)
64-
val builder = proto.Plan
65-
.newBuilder()
66-
.addRelations(
67-
proto.PlanRel
68-
.newBuilder()
69-
.setRoot(
70-
proto.RelRoot
71-
.newBuilder()
72-
.setInput(substraitRel
73-
.accept(relProtoConverter))
74-
)
75-
)
76-
extensionCollector.addExtensionsToPlan(builder)
77-
builder.build()
78-
}
79-
80-
def assertProtoPlanRoundrip(sql: String): Plan = {
81-
val protoPlan1 = sqlToProtoPlan(sql)
82-
val plan = new ProtoPlanConverter().from(protoPlan1)
83-
val protoPlan2 = new PlanProtoConverter().toProto(plan)
84-
assertResult(protoPlan1)(protoPlan2)
85-
assertResult(1)(plan.getRoots.size())
86-
plan
87-
}
88-
8957
def assertSqlSubstraitRelRoundTrip(query: String): LogicalPlan = {
9058
val sparkPlan = plan(query)
9159

@@ -135,12 +103,6 @@ trait SubstraitPlanTestBase { self: SharedSparkSession =>
135103
spark.sql(sql).queryExecution.optimizedPlan
136104
}
137105

138-
def assertPlanRoundrip(plan: Plan): Unit = {
139-
val protoPlan1 = new PlanProtoConverter().toProto(plan)
140-
val protoPlan2 = new PlanProtoConverter().toProto(new ProtoPlanConverter().from(protoPlan1))
141-
assertResult(protoPlan1)(protoPlan2)
142-
}
143-
144106
def testQuery(group: String, query: String, suffix: String = ""): Unit = {
145107
val queryString = resourceToString(
146108
s"$group/$query.sql",

0 commit comments

Comments
 (0)