Minimum CMake version is now 3.5. (#158)

EpsilonPrime · web-flow · commit ec9f8725df7a · 2025-04-09T19:38:05.000-07:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 2.8.12)
+cmake_minimum_required(VERSION 3.5...3.29)
 
 # Set extension name here
 set(TARGET_NAME substrait)
diff --git a/test/c/CMakeLists.txt b/test/c/CMakeLists.txt
@@ -1,12 +1,8 @@
-cmake_minimum_required(VERSION 2.8.12)
+cmake_minimum_required(VERSION 3.5...3.29)
 set(TARGET_NAME substrait_c_test)
 project(${TARGET_NAME})
 
-if (CMAKE_VERSION VERSION_LESS "3.1")
-    set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
-else ()
-  set (CMAKE_CXX_STANDARD 11)
-endif ()
+set (CMAKE_CXX_STANDARD 11)
 
 include_directories(../../duckdb/src/include)
 include_directories(../../duckdb/test/include)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-cmake_minimum_required(VERSION 2.8.12)`
	`1`	`+cmake_minimum_required(VERSION 3.5...3.29)`
`2`	`2`
`3`	`3`	`# Set extension name here`
`4`	`4`	`set(TARGET_NAME substrait)`