Fixed call to DeleteRelation.

Author: EpsilonPrime

src/from_substrait.cpp

@@ -904,11 +904,11 @@ shared_ptr<Relation> SubstraitToDuckDB::TransformWriteOp(const substrait::Rel &s
 		case RelationType::PROJECTION_RELATION: {
 			auto project = std::move(input.get()->Cast<ProjectionRelation>());
 			auto filter = std::move(project.child->Cast<FilterRelation>());
-        	return make_shared_ptr<DeleteRelation>(filter.context, std::move(filter.condition), schema_name, table_name);
+                        return make_shared_ptr<DeleteRelation>(filter.context, std::move(filter.condition), catalog_name, schema_name, table_name);
 		}
 		case RelationType::FILTER_RELATION: {
 			auto filter = std::move(input.get()->Cast<FilterRelation>());
-			return make_shared_ptr<DeleteRelation>(filter.context, std::move(filter.condition), schema_name, table_name);
+			return make_shared_ptr<DeleteRelation>(filter.context, std::move(filter.condition), catalog_name, schema_name, table_name);
 		}
 		default:
 			throw NotImplementedException("Unsupported relation type for delete operation");

test/c/test_substrait_c_api.cpp

@@ -291,7 +291,7 @@ TEST_CASE_METHOD(DataDirectoryFixture, "Test C Function Varchar Literal", "[subs
 	DuckDB db(nullptr);
 	Connection con(db);
 
-	REQUIRE_NO_FAIL(con.Query("INSTALL iceberg;"));
+	REQUIRE_NO_FAIL(con.Query("INSTALL iceberg FROM core_nightly;"));
 	REQUIRE_NO_FAIL(con.Query("LOAD iceberg;"));
 
 	const string plan_json = R"plan(
@@ -397,7 +397,7 @@ TEST_CASE_METHOD(DataDirectoryFixture, "Test C Iceberg Substrait with Substrait
 	DuckDB db(nullptr);
 	Connection con(db);
 
-	REQUIRE_NO_FAIL(con.Query("INSTALL iceberg;"));
+	REQUIRE_NO_FAIL(con.Query("INSTALL iceberg FROM core_nightly;"));
 	REQUIRE_NO_FAIL(con.Query("LOAD iceberg;"));
 
 	const string plan_json = R"plan(
@@ -476,7 +476,7 @@ TEST_CASE_METHOD(DataDirectoryFixture, "Test C Iceberg Substrait Snapshot ID wit
 	DuckDB db(nullptr);
 	Connection con(db);
 
-	REQUIRE_NO_FAIL(con.Query("INSTALL iceberg;"));
+	REQUIRE_NO_FAIL(con.Query("INSTALL iceberg FROM core_nightly;"));
 	REQUIRE_NO_FAIL(con.Query("LOAD iceberg;"));
 
 	const string plan_json = R"plan(
@@ -556,7 +556,7 @@ TEST_CASE_METHOD(DataDirectoryFixture, "Test C Iceberg Substrait Snapshot Timest
 	DuckDB db(nullptr);
 	Connection con(db);
 
-	REQUIRE_NO_FAIL(con.Query("INSTALL iceberg;"));
+	REQUIRE_NO_FAIL(con.Query("INSTALL iceberg FROM core_nightly;"));
 	REQUIRE_NO_FAIL(con.Query("LOAD iceberg;"));
 
 	const string plan_json = R"plan(
@@ -667,4 +667,4 @@ TEST_CASE("Test C Project with VirtualTable", "[substrait-api]") {
 	auto json_plan = R"({"version":{"minorNumber":29, "producer":"substrait-go darwin/arm64"}, "relations":[{"root":{"input":{"project":{"common":{"emit":{"outputMapping":[2]}}, "input":{"read":{"common":{"direct":{}}, "baseSchema":{"names":["c1", "c2"], "struct":{"types":[{"fp64":{"nullability":"NULLABILITY_NULLABLE"}}, {"fp64":{"nullability":"NULLABILITY_NULLABLE"}}], "nullability":"NULLABILITY_REQUIRED"}}, "virtualTable":{"expressions":[{"fields":[{"literal":{"fp64":1, "nullable":true}}, {"literal":{"fp64":2, "nullable":true}}]}]}}}, "expressions":[{"literal":{"fp64":42}}]}}, "names":["p1"]}}]})";
 	auto result = FromSubstraitJSON(con,json_plan);
 	REQUIRE(CHECK_COLUMN(result, 0, {42}));
-}
+}