File tree Expand file tree Collapse file tree 1 file changed +3
-3
lines changed Expand file tree Collapse file tree 1 file changed +3
-3
lines changed Original file line number Diff line number Diff line change @@ -769,7 +769,7 @@ substrait::Expression *DuckDBToSubstrait::TransformJoinCond(const JoinCondition
769
769
join_comparision = " lt" ;
770
770
break ;
771
771
default :
772
- throw InternalException (" Unsupported join comparison: " + ExpressionTypeToOperator (dcond.comparison ));
772
+ throw NotImplementedException (" Unsupported join comparison: " + ExpressionTypeToOperator (dcond.comparison ));
773
773
}
774
774
vector<::substrait::Type> args_types;
775
775
auto scalar_fun = expr->mutable_scalar_function ();
@@ -1011,15 +1011,15 @@ substrait::Rel *DuckDBToSubstrait::TransformAggregateGroup(LogicalOperator &dop)
1011
1011
for (auto &dgrp : daggr.groups ) {
1012
1012
if (dgrp->type != ExpressionType::BOUND_REF) {
1013
1013
// TODO push projection or push substrait to allow expressions here
1014
- throw InternalException (" No expressions in groupings yet" );
1014
+ throw NotImplementedException (" No expressions in groupings yet" );
1015
1015
}
1016
1016
TransformExpr (*dgrp, *sgrp->add_grouping_expressions ());
1017
1017
}
1018
1018
for (auto &dmeas : daggr.expressions ) {
1019
1019
auto smeas = saggr->add_measures ()->mutable_measure ();
1020
1020
if (dmeas->type != ExpressionType::BOUND_AGGREGATE) {
1021
1021
// TODO push projection or push substrait, too
1022
- throw InternalException (" No non-aggregate expressions in measures yet" );
1022
+ throw NotImplementedException (" No non-aggregate expressions in measures yet" );
1023
1023
}
1024
1024
auto &daexpr = dmeas->Cast <BoundAggregateExpression>();
1025
1025
You can’t perform that action at this time.
0 commit comments