Skip to content

Commit c50851f

Browse files
committed
changed to not implemented exception
1 parent 45a4541 commit c50851f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/to_substrait.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -769,7 +769,7 @@ substrait::Expression *DuckDBToSubstrait::TransformJoinCond(const JoinCondition
769769
join_comparision = "lt";
770770
break;
771771
default:
772-
throw InternalException("Unsupported join comparison: " + ExpressionTypeToOperator(dcond.comparison));
772+
throw NotImplementedException("Unsupported join comparison: " + ExpressionTypeToOperator(dcond.comparison));
773773
}
774774
vector<::substrait::Type> args_types;
775775
auto scalar_fun = expr->mutable_scalar_function();
@@ -1011,15 +1011,15 @@ substrait::Rel *DuckDBToSubstrait::TransformAggregateGroup(LogicalOperator &dop)
10111011
for (auto &dgrp : daggr.groups) {
10121012
if (dgrp->type != ExpressionType::BOUND_REF) {
10131013
// TODO push projection or push substrait to allow expressions here
1014-
throw InternalException("No expressions in groupings yet");
1014+
throw NotImplementedException("No expressions in groupings yet");
10151015
}
10161016
TransformExpr(*dgrp, *sgrp->add_grouping_expressions());
10171017
}
10181018
for (auto &dmeas : daggr.expressions) {
10191019
auto smeas = saggr->add_measures()->mutable_measure();
10201020
if (dmeas->type != ExpressionType::BOUND_AGGREGATE) {
10211021
// TODO push projection or push substrait, too
1022-
throw InternalException("No non-aggregate expressions in measures yet");
1022+
throw NotImplementedException("No non-aggregate expressions in measures yet");
10231023
}
10241024
auto &daexpr = dmeas->Cast<BoundAggregateExpression>();
10251025

0 commit comments

Comments
 (0)