Merge pull request #103 from pdet/full_out

Support full outer join

Author: pdet

src/from_substrait.cpp

@@ -401,6 +401,9 @@ shared_ptr<Relation> SubstraitToDuckDB::TransformJoinOp(const substrait::Rel &so
 	case substrait::JoinRel::JoinType::JoinRel_JoinType_JOIN_TYPE_SEMI:
 		djointype = JoinType::SEMI;
 		break;
+	case substrait::JoinRel::JoinType::JoinRel_JoinType_JOIN_TYPE_OUTER:
+		djointype = JoinType::OUTER;
+		break;
 	default:
 		throw InternalException("Unsupported join type");
 	}

src/to_substrait.cpp

@@ -568,7 +568,7 @@ uint64_t DuckDBToSubstrait::RegisterFunction(const string &name, vector<::substr
 				std::ostringstream error;
 				// Casting Error Message
 				error << "Could not find function \"" << function.function.GetName() << "\" with argument types: (";
-				auto types = custom_functions.GetTypes(args_types);
+				auto types = SubstraitCustomFunctions::GetTypes(args_types);
 				for (idx_t i = 0; i < types.size(); i++) {
 					error << "\'" << types[i] << "\'";
 					if (i != types.size() - 1) {
@@ -912,6 +912,9 @@ substrait::Rel *DuckDBToSubstrait::TransformComparisonJoin(LogicalOperator &dop)
 	case JoinType::SEMI:
 		sjoin->set_type(substrait::JoinRel::JoinType::JoinRel_JoinType_JOIN_TYPE_SEMI);
 		break;
+	case JoinType::OUTER:
+		sjoin->set_type(substrait::JoinRel::JoinType::JoinRel_JoinType_JOIN_TYPE_OUTER);
+		break;
 	default:
 		throw InternalException("Unsupported join type " + JoinTypeToString(djoin.join_type));
 	}

test/sql/test_join.test

@@ -0,0 +1,20 @@
+# name: test/sql/test_join.test
+# description: Test Join operators
+# group: [sql]
+
+require substrait
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+CREATE table customer as select range c_custkey, range::VARCHAR c_name from range(10000);
+
+# Test Full outer join
+statement ok
+CALL get_substrait('
+    WITH raw_data as (SELECT * from customer),
+    cte1 as (SELECT c_custkey as join_custkey, c_name from raw_data where c_custkey = 800),
+    cte2 as (SELECT c_custkey as other_custkey, c_name from raw_data where c_custkey = 900)
+    select * from cte1 full join cte2 on join_custkey = other_custkey;
+  ');