strlen -> octet_length

Author: pdet

src/from_substrait.cpp

@@ -31,7 +31,7 @@ const std::unordered_map<std::string, std::string> SubstraitToDuckDB::function_n
     {"ends_with", "suffix"}, {"substring", "substr"},   {"char_length", "length"},
     {"is_nan", "isnan"},     {"is_finite", "isfinite"}, {"is_infinite", "isinf"},
     {"like", "~~"},          {"extract", "date_part"},  {"bitwise_and", "&"},
-    {"bitwise_or", "|"},     {"bitwise_xor", "xor"}};
+    {"bitwise_or", "|"},     {"bitwise_xor", "xor"},    {"octet_length", "strlen"}};
 
 const case_insensitive_set_t SubstraitToDuckDB::valid_extract_subfields = {
     "year",    "month",       "day",          "decade", "century", "millenium",

src/to_substrait.cpp

@@ -41,7 +41,8 @@ const std::unordered_map<std::string, std::string> DuckDBToSubstrait::function_n
     {"!~~", "not_equal"},
     {"&", "bitwise_and"},
     {"|", "bitwise_or"},
-    {"xor", "bitwise_xor"}};
+    {"xor", "bitwise_xor"},
+    {"strlen", "octet_length"}};
 
 const case_insensitive_set_t DuckDBToSubstrait::valid_extract_subfields = {
     "year",    "month",       "day",          "decade", "century", "millenium",

test/sql/test_functions.test

@@ -12,23 +12,23 @@ create table t as select 1 as a ,2 as b;
 
 # bitwise_and
 statement ok
-CALL get_substrait('select a & b from t')
+CALL get_substrait('select a & b from t', strict = true)
 
 # bitwise_or
 statement ok
-CALL get_substrait('select a | b from t')
+CALL get_substrait('select a | b from t', strict = true)
 
 # bitwise_xor
 statement ok
-CALL get_substrait('select xor(a,b) from t')
+CALL get_substrait('select xor(a,b) from t', strict = true)
 
-# octet_length
-#statement ok
-#CALL get_substrait('select octet_length(''100001'') from t')
+# strlen gets transformed to octet_length
+statement ok
+CALL get_substrait('select strlen(a::varchar) from t', strict = true)
 
 # coalesce
 statement ok
-CALL get_substrait('select coalesce(a) from t')
+CALL get_substrait('select coalesce(a) from t', strict = true)
 
 # acosh
 # asinh
@@ -37,4 +37,4 @@ CALL get_substrait('select coalesce(a) from t')
 # sinh
 # tanh
 statement ok
-CALL get_substrait('select acosh(a),asinh(a),atanh(a),cosh(a),sinh(a),tanh(a) from t')
+CALL get_substrait('select acosh(a),asinh(a),atanh(a),cosh(a),sinh(a),tanh(a) from t', strict = true)