Skip to content

Commit 30a3c32

Browse files
committed
Changed some exceptions to NotImplemented
1 parent 325440a commit 30a3c32

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/to_substrait.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ void DuckDBToSubstrait::TransformExpr(Expression &dexpr, substrait::Expression &
584584
TransformNotExpression(dexpr, sexpr, col_offset);
585585
break;
586586
default:
587-
throw InternalException(ExpressionTypeToString(dexpr.type));
587+
throw NotImplementedException(ExpressionTypeToString(dexpr.type));
588588
}
589589
}
590590

@@ -973,7 +973,7 @@ substrait::Rel *DuckDBToSubstrait::TransformComparisonJoin(LogicalOperator &dop)
973973
sjoin->set_type(substrait::JoinRel::JoinType::JoinRel_JoinType_JOIN_TYPE_OUTER);
974974
break;
975975
default:
976-
throw InternalException("Unsupported join type " + JoinTypeToString(djoin.join_type));
976+
throw NotImplementedException("Unsupported join type " + JoinTypeToString(djoin.join_type));
977977
}
978978
// somewhat odd semantics on our side
979979
if (djoin.left_projection_map.empty()) {
@@ -1449,7 +1449,7 @@ substrait::Rel *DuckDBToSubstrait::TransformOp(LogicalOperator &dop) {
14491449
case LogicalOperatorType::LOGICAL_DUMMY_SCAN:
14501450
return TransformDummyScan();
14511451
default:
1452-
throw InternalException(LogicalOperatorToString(dop.type));
1452+
throw NotImplementedException(LogicalOperatorToString(dop.type));
14531453
}
14541454
}
14551455

0 commit comments

Comments
 (0)