build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.61.0 to 6.0.0 (#2609)

dependabot[bot] · hugo-vrijswijk · web-flow · commit 8492452936dc · 2023-07-11T11:48:35.000Z
* build(deps-dev): bump @typescript-eslint/eslint-plugin Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.61.0 to 6.0.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.0.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update linting config --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hugo van Rijswijk <git@hugovr.nl>
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -20,8 +20,8 @@ module.exports = {
   extends: [
     'eslint:recommended',
     'plugin:@typescript-eslint/eslint-recommended',
-    'plugin:@typescript-eslint/recommended',
-    'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    'plugin:@typescript-eslint/recommended-type-checked',
+    'plugin:@typescript-eslint/stylistic-type-checked',
     'prettier',
     'plugin:tailwindcss/recommended',
   ],
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -49,8 +49,8 @@
     "@types/sinon": "^10.0.0",
     "@types/sinon-chai": "^3.2.2",
     "@types/webpack-env": "^1.13.9",
-    "@typescript-eslint/eslint-plugin": "^5.3.0",
-    "@typescript-eslint/parser": "^5.3.0",
+    "@typescript-eslint/eslint-plugin": "^6.0.0",
+    "@typescript-eslint/parser": "^6.0.0",
     "ajv": "^8.6.3",
     "autoprefixer": "^10.4.13",
     "canvas": "^2.11.0",
diff --git a/packages/elements/src/components/app/app.component.ts b/packages/elements/src/components/app/app.component.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-enum-comparison */
 import { html, PropertyValues, unsafeCSS, nothing } from 'lit';
 import { customElement, property } from 'lit/decorators.js';
 import { MutantResult, MutationTestResult } from 'mutation-testing-report-schema/api';
@@ -59,7 +60,7 @@ export class MutationTestReportAppComponent extends RealtimeElement {
   public context: Context = { view: View.mutant, path: [] };
 
   @property()
-  public path: ReadonlyArray<string> = [];
+  public path: readonly string[] = [];
 
   @property({ attribute: 'title-postfix' })
   public titlePostfix: string | undefined;
@@ -124,8 +125,8 @@ export class MutationTestReportAppComponent extends RealtimeElement {
     }
   }
 
-  private mutants: Map<string, MutantModel> = new Map();
-  private tests: Map<string, TestModel> = new Map();
+  private mutants = new Map<string, MutantModel>();
+  private tests = new Map<string, TestModel>();
 
   public updated(changedProperties: PropertyValues) {
     if (changedProperties.has('theme') && this.theme) {
@@ -183,7 +184,7 @@ export class MutationTestReportAppComponent extends RealtimeElement {
     if (this.rootModel) {
       const findResult = <TFile, TResult>(root: MetricsResult<TFile, TResult>, path: string[]): MetricsResult<TFile, TResult> | undefined => {
         return path.reduce<MetricsResult<TFile, TResult> | undefined>(
-          (model, currentPathPart) => model && model.childResults.find((child) => child.name === currentPathPart),
+          (model, currentPathPart) => model?.childResults.find((child) => child.name === currentPathPart),
           root
         );
       };
@@ -225,7 +226,7 @@ export class MutationTestReportAppComponent extends RealtimeElement {
   }
 
   private source: EventSource | undefined;
-  private sseSubscriptions: Set<Subscription> = new Set();
+  private sseSubscriptions = new Set<Subscription>();
   private theMutant?: MutantModel;
   private theTest?: TestModel;
 
@@ -319,7 +320,7 @@ export class MutationTestReportAppComponent extends RealtimeElement {
   }
 
   public render() {
-    if (this.context.result || this.errorMessage) {
+    if (this.context.result ?? this.errorMessage) {
       return html`
         <div class="container bg-white pb-4 font-sans text-gray-800 motion-safe:transition-max-width">
           <div class="space-y-4 transition-colors">
diff --git a/packages/elements/src/components/drawer-mutant/drawer-mutant.component.ts b/packages/elements/src/components/drawer-mutant/drawer-mutant.component.ts
@@ -23,6 +23,7 @@ export class MutationTestReportDrawerMutant extends RealtimeElement {
 
   public render() {
     return renderDrawer(
+      // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- we want to coalesce on length 0
       { hasDetail: Boolean(this.mutant?.killedByTests?.length || this.mutant?.coveredByTests?.length), mode: this.mode },
       renderIfPresent(
         this.mutant,
diff --git a/packages/elements/src/components/drawer-mutant/util.ts b/packages/elements/src/components/drawer-mutant/util.ts
@@ -3,6 +3,7 @@ import { html, nothing, TemplateResult } from 'lit';
 export const renderDetailLine = (title: string, content: string | TemplateResult) =>
   html`<li title=${title || nothing} class="my-3 rounded bg-white px-2 py-3 shadow">${content}</li>`;
 
+// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- we want to coalesce on empty string
 export const renderSummaryLine = (content: string | TemplateResult, title?: string) => html`<p title=${title || nothing}>${content}</p>`;
 
 export const renderSummaryContainer = (content: TemplateResult) => html`<div class="mb-6 mr-6 mt-2 flex flex-col gap-4">${content}</div>`;
diff --git a/packages/elements/src/components/drawer-test/drawer-test.component.ts b/packages/elements/src/components/drawer-test/drawer-test.component.ts
@@ -22,6 +22,7 @@ export class MutationTestReportDrawerTestComponent extends RealtimeElement {
 
   public render() {
     return renderDrawer(
+      // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- we want to coalesce on length 0
       { hasDetail: Boolean(this.test?.killedMutants?.length || this.test?.coveredMutants?.length), mode: this.mode },
       renderIfPresent(
         this.test,
diff --git a/packages/elements/src/lib/code-helpers.ts b/packages/elements/src/lib/code-helpers.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-enum-comparison */
 import { Position } from 'mutation-testing-report-schema/api';
 import { highlight, languages } from 'prismjs/components/prism-core';
 
@@ -340,10 +341,10 @@ export function findDiffIndices(original: string, mutated: string) {
   // Make an exception for `true` and `false` (end in same character 🤷‍♀️)
   const mutatedPart = mutated.substring(focusFrom, focusTo);
   ['true', 'false'].forEach((keyword) => {
-    if (mutatedPart === keyword.substr(0, keyword.length - 1) && keyword[keyword.length - 1] === mutated[focusTo]) {
+    if (mutatedPart === keyword.substr(0, keyword.length - 1) && keyword.endsWith(mutated[focusTo])) {
       focusTo++;
     }
-    if (mutatedPart === keyword.substr(1, keyword.length) && keyword[0] === mutated[focusFrom - 1]) {
+    if (mutatedPart === keyword.substr(1, keyword.length) && keyword.startsWith(mutated[focusFrom - 1])) {
       focusFrom--;
     }
   });
diff --git a/packages/elements/test/integration/lib/browser.ts b/packages/elements/test/integration/lib/browser.ts
@@ -4,7 +4,7 @@ import chrome from 'selenium-webdriver/chrome';
 let browser: WebDriver | null = null;
 
 export function isHeadless(): boolean {
-  return !!(process.env.HEADLESS || process.env.CI);
+  return !!(process.env.HEADLESS ?? process.env.CI);
 }
 
 export async function init() {
diff --git a/packages/elements/test/integration/po/MutantElement.po.ts b/packages/elements/test/integration/po/MutantElement.po.ts
@@ -17,6 +17,7 @@ export abstract class MutantElement extends PageObject {
 
   public async getStatus(): Promise<MutantStatus | undefined> {
     return (await this.classes()).find((clazz) => {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
       const testState = allMutantStates.find((state) => state === clazz);
       if (testState) {
         return testState;
diff --git a/packages/elements/test/integration/po/TestDot.po.ts b/packages/elements/test/integration/po/TestDot.po.ts
@@ -15,6 +15,7 @@ export class TestDot extends PageObject {
 
   public async getStatus(): Promise<TestStatus | undefined> {
     return (await this.classes()).find((clazz) => {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
       const testState = allTestStates.find((state) => state === clazz);
       if (testState) {
         return testState;
diff --git a/packages/elements/test/integration/setup/setup-chai.ts b/packages/elements/test/integration/setup/setup-chai.ts
@@ -15,7 +15,7 @@ chai.use(({ Assertion }) => {
   Assertion.addMethod('matchScreenshot', async function () {
     const snapshotFileExists = existsSync(currentSnapshotFile);
     const actualBase64Encoded: string = this._obj;
-    if (process.env.UPDATE_ALL_SCREENSHOTS !== 'true' && (process.env.CI || snapshotFileExists)) {
+    if (process.env.UPDATE_ALL_SCREENSHOTS !== 'true' && (process.env.CI ?? snapshotFileExists)) {
       expect(snapshotFileExists, `Snapshot file does not exist! ${currentSnapshotFile}`).true;
       await assertSnapshot(actualBase64Encoded);
     } else {
diff --git a/packages/elements/test/unit/components/breadcrumb.component.spec.ts b/packages/elements/test/unit/components/breadcrumb.component.spec.ts
@@ -37,7 +37,7 @@ describe(MutationTestReportBreadcrumbComponent.name, () => {
     await sut.whenStable();
     const elements = sut.$$('li');
     expect(elements).lengthOf(2);
-    const anchor = elements[0].querySelector('a') as HTMLAnchorElement;
+    const anchor = elements[0].querySelector('a')!;
     expect(anchor).ok;
     expect(anchor.href).eq(href('#mutant'));
     expect(elements[1].textContent?.trim()).eq('foo.js');
@@ -49,11 +49,11 @@ describe(MutationTestReportBreadcrumbComponent.name, () => {
     await sut.whenStable();
     const elements = sut.$$('li');
     expect(elements).lengthOf(3);
-    const rootLink = elements[0].querySelector('a') as HTMLAnchorElement;
+    const rootLink = elements[0].querySelector('a')!;
     expect(rootLink).ok;
     expect(rootLink.href).eq(href('#mutant'));
     expect(elements[1].textContent?.trim()).eq('bar');
-    const barAnchor = elements[1].querySelector('a') as HTMLAnchorElement;
+    const barAnchor = elements[1].querySelector('a')!;
     expect(barAnchor).ok;
     expect(barAnchor.href).eq(href('#mutant/bar'));
     expect(elements[2].textContent?.trim()).eq('foo.js');
diff --git a/packages/elements/test/unit/components/state-filter.component.spec.ts b/packages/elements/test/unit/components/state-filter.component.spec.ts
@@ -51,7 +51,7 @@ describe(FileStateFilterComponent.name, () => {
       // Assert
       const actualCheckboxes = sut.$$('input[type=checkbox]');
       expect(actualCheckboxes).lengthOf(7);
-      const checkboxTexts = sut.$$('input[type=checkbox] + label').map((checkbox) => normalizeWhitespace(checkbox.textContent as string));
+      const checkboxTexts = sut.$$('input[type=checkbox] + label').map((checkbox) => normalizeWhitespace(checkbox.textContent!));
       expect(checkboxTexts).deep.eq([
         '✅ Killed (1)',
         '👽 Survived (1)',
diff --git a/packages/elements/test/unit/components/totals.component.spec.ts b/packages/elements/test/unit/components/totals.component.spec.ts
@@ -83,7 +83,7 @@ describe(MutationTestReportTestMetricsTable.name, () => {
     expect(table).ok;
     const rows = table.querySelectorAll('tbody tr');
     expect(rows).lengthOf(2);
-    expect(((rows.item(1) as HTMLTableRowElement).cells.item(0) as HTMLTableCellElement).textContent).contains('baz/foo.js');
+    expect((rows.item(1) as HTMLTableRowElement).cells.item(0)!.textContent).contains('baz/foo.js');
   });
 
   it('should show N/A when no mutation score is available', async () => {
diff --git a/packages/elements/test/unit/helpers/CustomElementFixture.ts b/packages/elements/test/unit/helpers/CustomElementFixture.ts
@@ -59,14 +59,14 @@ export class CustomElementFixture<TCustomElement extends LitElement> {
 
   public $<TElement extends Element = HTMLElement>(selector: string, inShadow = true): TElement {
     if (inShadow) {
-      return (this.element.shadowRoot as ShadowRoot).querySelector(selector) as TElement;
+      return this.element.shadowRoot!.querySelector(selector)!;
     } else {
-      return this.element.querySelector(selector) as TElement;
+      return this.element.querySelector(selector)!;
     }
   }
 
   public $$<TElement extends Element = HTMLElement>(selector: string): TElement[] {
-    return [...(this.element.shadowRoot as ShadowRoot).querySelectorAll<TElement>(selector)];
+    return [...this.element.shadowRoot!.querySelectorAll<TElement>(selector)];
   }
 
   public get style(): CSSStyleDeclaration {
diff --git a/packages/metrics/src/calculateMetrics.ts b/packages/metrics/src/calculateMetrics.ts
@@ -98,7 +98,7 @@ function toChildModels<TFileModel, TMetrics>(
 
 function relate(mutants: MutantModel[], tests: TestModel[]) {
   // Create a testId -> TestModel map for fast lookup
-  const testMap: Map<string, TestModel> = new Map(tests.map((test) => [test.id, test]));
+  const testMap = new Map<string, TestModel>(tests.map((test) => [test.id, test]));
 
   for (const mutant of mutants) {
     const coveringTests = mutant.coveredBy?.map((testId) => testMap.get(testId)) ?? [];
diff --git a/packages/metrics/src/helpers/file.ts b/packages/metrics/src/helpers/file.ts
@@ -26,7 +26,7 @@ function normalizeName(fileName: string) {
   return fileName.split(/\/|\\/).filter(Boolean).join('/');
 }
 
-export function determineCommonBasePath(fileNames: ReadonlyArray<string>): string {
+export function determineCommonBasePath(fileNames: readonly string[]): string {
   const directories = fileNames.map((fileName) => fileName.split(/\/|\\/).slice(0, -1));
   if (fileNames.length) {
     return directories.reduce(filterDirectories).join(SEPARATOR);
diff --git a/packages/metrics/src/helpers/text.ts b/packages/metrics/src/helpers/text.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-enum-comparison */
 // The implementation of this file is grabbed and modified from TypeScript source code
 
 const enum CharacterCodes {
diff --git a/packages/metrics/src/model/mutant-model.ts b/packages/metrics/src/model/mutant-model.ts
@@ -32,8 +32,8 @@ export class MutantModel implements MutantResult {
   public killedByTests: TestModel[] | undefined;
   public sourceFile: FileUnderTestModel | undefined;
 
-  #coveredByTests: Map<string, TestModel> = new Map();
-  #killedByTests: Map<string, TestModel> = new Map();
+  #coveredByTests = new Map<string, TestModel>();
+  #killedByTests = new Map<string, TestModel>();
 
   constructor(input: MutantResult) {
     this.coveredBy = input.coveredBy;
diff --git a/packages/metrics/src/model/source-file.ts b/packages/metrics/src/model/source-file.ts
@@ -13,7 +13,7 @@ export abstract class SourceFile {
 
   public getLineMap(): number[] {
     assertSourceDefined(this.source);
-    return this.lineMap || (this.lineMap = computeLineStarts(this.source));
+    return this.lineMap ?? (this.lineMap = computeLineStarts(this.source));
   }
 
   /**
diff --git a/packages/metrics/src/model/test-model.ts b/packages/metrics/src/model/test-model.ts
@@ -28,8 +28,8 @@ export class TestModel implements TestDefinition {
   public coveredMutants?: MutantModel[];
   public sourceFile: TestFileModel | undefined;
 
-  #killedMutants: Map<string, MutantModel> = new Map();
-  #coveredMutants: Map<string, MutantModel> = new Map();
+  #killedMutants = new Map<string, MutantModel>();
+  #coveredMutants = new Map<string, MutantModel>();
 
   public addCovered(mutant: MutantModel) {
     if (!this.coveredMutants) {

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import chrome from 'selenium-webdriver/chrome';`
`4`	`4`	`let browser: WebDriver \| null = null;`
`5`	`5`
`6`	`6`	`export function isHeadless(): boolean {`
`7`		`- return !!(process.env.HEADLESS \|\| process.env.CI);`
	`7`	`+ return !!(process.env.HEADLESS ?? process.env.CI);`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`export async function init() {`