Skip to content

Commit 3032109

Browse files
authored
Merge pull request #72 from sasezaki/default-rule-enables
Change default enable rules
2 parents 3f78b53 + a552379 commit 3032109

File tree

3 files changed

+11
-14
lines changed

3 files changed

+11
-14
lines changed

README.md

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
* [PSR-3 Meta Document](https://www.php-fig.org/psr/psr-3/meta/)
1212

1313
> [!IMPORTANT]
14-
> It is planned to change default rule settings.
14+
> Since `0.20.0`, changed default rule settings.
1515
16-
* MessageStaticStringRule would be enabled by default.
17-
* ContextRequireExceptionKeyRule would be disabled by default.
18-
* [Recommendation] write these parameters to your project's `phpstan.neon`
16+
* MessageStaticStringRule is enabled by default.
17+
* ContextRequireExceptionKeyRule is disabled by default.
18+
* [Recommendation] write these parameters to your project's `phpstan.neon`.
1919

2020
```neon
2121
parameters:
@@ -182,19 +182,16 @@ Then, `debug`| `info` | `notice` LogLevel is ignored for report.
182182
}
183183
```
184184

185-
* If you want to disable this rule, please add `enableContextRequireExceptionKeyRule` as false.
185+
* If you want to enable this rule, please add `enableContextRequireExceptionKeyRule` as true.
186186

187187
```neon
188188
parameters:
189189
sfpPsrLog:
190-
enableContextRequireExceptionKeyRule: false
190+
enableContextRequireExceptionKeyRule: true
191191
```
192192

193193
### MessageStaticStringRule
194194

195-
> [!IMPORTANT]
196-
> This Rule is currently experimental.
197-
198195
| :pushpin: _error identifier_ |
199196
| --- |
200197
| sfp-psr-log.messageNotStaticString |
@@ -208,12 +205,12 @@ $logger->info(sprintf('Message contains %s variable', $var));
208205

209206
#### Configuration
210207

211-
* If you want to enable this rule, please add `enableMessageStaticStringRule` as true.
208+
* If you want to disable this rule, please add `enableMessageStaticStringRule` as false.
212209

213210
```neon
214211
parameters:
215212
sfpPsrLog:
216-
enableMessageStaticStringRule: true
213+
enableMessageStaticStringRule: false
217214
```
218215

219216
## Installation

example/phpstan.neon

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ parameters:
1313
paths:
1414
- %currentWorkingDirectory%/example/src
1515
sfpPsrLog:
16-
# enableContextRequireExceptionKeyRule: true
16+
enableContextRequireExceptionKeyRule: true
1717
enableMessageStaticStringRule: true
1818
reportContextExceptionLogLevel: 'notice'
1919
contextKeyOriginalPattern: '#\A[A-Za-z0-9-]+\z#'

rules.neon

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ parametersSchema:
88

99
parameters:
1010
sfpPsrLog:
11-
enableContextRequireExceptionKeyRule: true
12-
enableMessageStaticStringRule: false
11+
enableContextRequireExceptionKeyRule: false
12+
enableMessageStaticStringRule: true
1313
reportContextExceptionLogLevel: 'debug'
1414
contextKeyOriginalPattern: null
1515

0 commit comments

Comments
 (0)