Add ResourceOperationFuncCallRule

Author: sasezaki

example/example.php

@@ -1,12 +1,16 @@
 <?php
 namespace SfpExample\PHPStan\DontOperationInsideConstructor;
 
+use function fopen;
+
 class Example
 {
 	public function __construct()
 	{
 		$fileInfo = new \SplFileInfo('test');
 		$fileInfo->openFile('r');
+
+		fopen('test', 'r');
 	}
 
 	public static function factory() : self

rules.neon

@@ -1,2 +1,3 @@
 rules:
 	- Sfp\PHPStan\DontOperationInsideConstructor\Rules\ResourceOperationMethodCallRule
+	- Sfp\PHPStan\DontOperationInsideConstructor\Rules\ResourceOperationFuncCallRule

src/Rules/ResourceOperationFuncCallRule.php

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Sfp\PHPStan\DontOperationInsideConstructor\Rules;
+
+use PhpParser\Node;
+use PhpParser\Node\Name;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleError;
+use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
+use Sfp\ResourceOperations\ResourceOperations;
+
+use function in_array;
+use function sprintf;
+
+/**
+ * @implements Rule<Node\Expr\FuncCall>
+ */
+final class ResourceOperationFuncCallRule implements Rule
+{
+    public function getNodeType(): string
+    {
+        return Node\Expr\FuncCall::class;
+    }
+
+    /**
+     * @param Node\Expr\FuncCall $node
+     * @return array|RuleError[]|string[]
+     * @throws ShouldNotHappenException
+     */
+    public function processNode(Node $node, Scope $scope): array
+    {
+        if ($scope->getFunctionName() !== '__construct') {
+            return [];
+        }
+
+        if (! $node->name instanceof Name) {
+            return [];
+        }
+
+        $errors = [];
+        if (in_array($node->name->toString(), ResourceOperations::getFunctions(), true)) {
+            $errors[] = RuleErrorBuilder::message(
+                sprintf("Don't resource operation inside constructor. function %s() is called.", $node->name->toString())
+            )->identifier('sfp-dont-operation.resourceOperationFuncCall')->build();
+        }
+
+        return $errors;
+    }
+}

test/Rules/ResourceOperationFuncCallRuleTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SfpTest\PHPStan\DontOperationInsideConstructor\Rules;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use Sfp\PHPStan\DontOperationInsideConstructor\Rules\ResourceOperationFuncCallRule;
+
+/**
+ * @extends RuleTestCase<ResourceOperationFuncCallRule>
+ * @covers \Sfp\PHPStan\DontOperationInsideConstructor\Rules\ResourceOperationFuncCallRule
+ */
+class ResourceOperationFuncCallRuleTest extends RuleTestCase
+{
+    public function getRule(): Rule
+    {
+        return new ResourceOperationFuncCallRule();
+    }
+
+    public function testProcess(): void
+    {
+        $this->analyse([__DIR__ . '/data/ResourceOperationFuncCall.php'], [
+            [
+                "Don't resource operation inside constructor. function fopen() is called.",
+                13,
+            ],
+        ]);
+    }
+}

test/Rules/data/ResourceOperationFuncCall.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SfpTest\PHPStan\DontOperationInsideConstructor\Rules\data;
+
+use function fopen;
+
+class ResourceOperationFuncCall
+{
+    public function __construct()
+    {
+        $fp = fopen('test', 'r');
+
+        (function () {
+        })();
+    }
+}

test/example.output

@@ -1,6 +1,9 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuite xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" failures="1" name="phpstan" tests="1" xsi:noNamespaceSchemaLocation="https://raw.githubusercontent.com/junit-team/junit5/r5.5.1/platform-tests/src/test/resources/jenkins-junit.xsd">
-  <testcase name="example/example.php:9">
+<testsuite xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" failures="2" name="phpstan" tests="2" xsi:noNamespaceSchemaLocation="https://raw.githubusercontent.com/junit-team/junit5/r5.5.1/platform-tests/src/test/resources/jenkins-junit.xsd">
+  <testcase name="example/example.php:11">
     <failure type="ERROR" message="Don't resource operation inside constructor. Method SplFileInfo::openfile() is called."/>
   </testcase>
+  <testcase name="example/example.php:13">
+    <failure type="ERROR" message="Don't resource operation inside constructor. function fopen() is called."/>
+  </testcase>
 </testsuite>