Allow data to be set in only POST rawRequests (#2346)

Only allow data to be set in POST

Author: helenye-stripe

src/RequestSender.ts

@@ -487,7 +487,8 @@ export class RequestSender {
 
         // Pull request data and options (headers, auth) from args.
         const dataFromArgs = getDataFromArgs(args);
-        const data = Object.assign({}, dataFromArgs);
+        const data =
+          requestMethod === 'POST' ? Object.assign({}, dataFromArgs) : null;
         const calculatedOptions = getOptionsFromArgs(args);
 
         const headers = calculatedOptions.headers;

test/RequestSender.spec.ts

@@ -520,6 +520,22 @@ describe('RequestSender', () => {
             done(error);
           });
       });
+
+      it('sends empty v2 GET request bodies', (done) => {
+        const scope = nock(`https://api.stripe.com`)
+          .get(`/v2/core/event_destinations`)
+          .reply(200, {data: [], next_page_url: null, previous_page_url: null});
+
+        realStripe
+          .rawRequest('GET', '/v2/core/event_destinations')
+          .then((result) => {
+            done();
+            scope.done();
+          })
+          .catch((error) => {
+            done(error);
+          });
+      });
     });
   });