KafkaConnect - Restart Connector KIP-745 #11678
Closed
rlanhellas
started this conversation in
Ideas
Replies: 2 comments 1 reply
-
@rlanhellas thanks for the proposal but you should use the Strimzi proposals repository in order to do so and not the Github discussions. |
Beta Was this translation helpful? Give feedback.
1 reply
-
Closing since the proposal can now be found here: strimzi/proposals#163 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Related to #11484
Kafka KIP-745 adds two optional query parameters to restart a connector:
includeTasks
andonlyFailed
. Today in our current annotation we have the following options:The
strimzi.io/restart
calls exactly the API mentioned on KIP-745, but always set false to the new optional arguments, as you can see here.If you take a look on other very famous products like nginx, they allow most of configs using annotations, check this out. Then my proposal is to do the same here, and we should have the following:
The two new annotations
strimzi.io/restart-include-tasks
andstrimzi.io/restart-only-failed
will have default to false and will be ignored ifstrimzi.io/restart
is not set.Beta Was this translation helpful? Give feedback.
All reactions