[Bug]: Test testCreateStatefulPodWithTemplate are failing

[rlanhellas]

Bug Description

The tests under testCreateStatefulPodWithTemplate are failing.

The tests are expecting to strimzi.io/revision to be equal to 6458a317 but they are consistently equal to 070283ab no matter how much times you run it.

Since we can't revert hash to original value, I can't find what is different in the Pod object to generate the correct hash. I can open a PR to change to the new hash but not sure if it's ok.

Steps to reproduce

Just run the tests testCreateStatefulPodWithTemplate under WorkloadUtilsTest.

Expected behavior

The revision should be equal to expected by the tests.

Strimzi version

main

Kubernetes version

1.33

Installation method

No response

Infrastructure

No response

Configuration files and logs

No response

Additional context

No response

[im-konge]

Hi, did you do any change or something on main?
I tried to run the test + whole suite few times and it works fine.
What are the differences? Are you using for example different Java version or something?

[rlanhellas]

@im-konge , the only thing I changed was this line because Intellij returns this error :

java: non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.String for a varargs call
  cast to java.lang.String[] for a non-varargs call and to suppress this warning

So I changed to ...

String str = annotation(annotation, null, metadata, (String) null);

My java version is : 17.0.4

[rlanhellas]

I changed so many things that i'm unsure about what was the solution , let me try to reproduce the problem and steps to fix it again

[im-konge]

I completely understand. It is just my curiosity. I don't want to waste your time on trying to reproduce the same thing. In case that it's fixed and you don't see the issue anymore, we can re-open the discussion or the issue anytime in the future. Maybe once we will move to Java 21 or something, we will have to deal with these kind of issues.

But thanks for the investigation and sorry for the issues :)

[rlanhellas]

No problem at all, help to contribute.

[rlanhellas]

@im-konge , I was able to reproduce the problem and here is the full context:

When using Java 23 the test produces strimzi.io/revision=070283ab , different from expected which should be strimzi.io/revision=6458a317. In my case I was using Java 23 in the test case.

So we can close this discussion. Thx

[im-konge]

Great, thanks for checking that out once more.