UI: generalize autocompletion to work for MultipleChoice fields (code review)

Author: stanislaw

strictdoc/backend/sdoc/models/document.py

@@ -25,6 +25,7 @@
 )
 from strictdoc.core.document_meta import DocumentMeta
 from strictdoc.helpers.auto_described import auto_described
+from strictdoc.helpers.cast import assert_cast
 from strictdoc.helpers.mid import MID
 
 
@@ -217,8 +218,7 @@ def get_grammar_element_field_for(
         """
         Returns the GrammarElementField for a field of a [element_type] in this document.
         """
-        assert self.grammar is not None
-        grammar: DocumentGrammar = self.grammar
+        grammar: DocumentGrammar = assert_cast(self.grammar, DocumentGrammar)
         element: GrammarElement = grammar.elements_by_type[element_type]
         field: GrammarElementField = element.fields_map[field_name]
         return field

strictdoc/export/html/_static/controllers/autocompletable_field_controller.js

@@ -185,7 +185,7 @@
         const text = this.autocompletable.innerText || "";
         const parts = text.split(",");
 
-        // Replace the last incomplete token with the suggestion
+        // Replace the last incomplete token with the suggestion.
         parts[parts.length - 1] = " " + suggestion;
         suggestion = parts.map(p => p.trim()).join(", ")
       } 

strictdoc/server/routers/main_router.py

@@ -2793,14 +2793,14 @@ def get_autocomplete_field_results(
                 )
 
                 if field.gef_type == RequirementFieldType.MULTIPLE_CHOICE:
-                    # MultipleChoice: Split the query into parts
+                    # MultipleChoice: Split the query into parts.
                     parts = q.lower().split(",")
 
                     # only use the last_part for lookup
                     last_part = parts[-1].strip()
                     query_words = last_part.split()
 
-                    # and pre-filter: don't suggest choices that were already selected / present in the query
+                    # Pre-filter: don't suggest choices that were already selected / present in the query.
                     already_selected = [
                         p.strip() for p in parts[:-1] if p.strip()
                     ]
@@ -2810,13 +2810,13 @@ def get_autocomplete_field_results(
                         if choice.lower() not in already_selected
                     ]
                 else:
-                    # SingleChoice: use all available options
+                    # SingleChoice: use all available options.
                     query_words = q.lower().split()
                     filtered_options = all_options
 
                 resulting_values = []
 
-                # now filter the remainig options for those that macht all words in query_words
+                # Now filter the remaining options for those that match all words in query_words.
                 for option_ in filtered_options:
                     words_ = option_.strip().lower()