Merge pull request #2183 from strictdoc-project/stanislaw/remove_free_text

Code climate: traceability_index: remove unused code

Author: stanislaw

strictdoc/core/traceability_index.py

@@ -99,9 +99,6 @@ def has_parent_requirements(self, requirement: SDocNode) -> bool:
         if not isinstance(requirement.reserved_uid, str):
             return False
 
-        if len(requirement.reserved_uid) == 0:
-            return False
-
         parent_requirements = self.graph_database.get_link_values(
             link_type=GraphLinkType.NODE_TO_PARENT_NODES,
             lhs_node=requirement,
@@ -114,9 +111,6 @@ def has_children_requirements(self, requirement: SDocNode):
         if not isinstance(requirement.reserved_uid, str):
             return False
 
-        if len(requirement.reserved_uid) == 0:
-            return False
-
         children_requirements = self.graph_database.get_link_values(
             link_type=GraphLinkType.NODE_TO_CHILD_NODES,
             lhs_node=requirement,
@@ -159,9 +153,6 @@ def get_parent_requirements(self, requirement: SDocNode) -> List[SDocNode]:
         if not isinstance(requirement.reserved_uid, str):
             return []
 
-        if len(requirement.reserved_uid) == 0:
-            return []
-
         return list(
             self.graph_database.get_link_values(
                 link_type=GraphLinkType.NODE_TO_PARENT_NODES,
@@ -172,10 +163,7 @@ def get_parent_requirements(self, requirement: SDocNode) -> List[SDocNode]:
 
     def get_parent_relations_with_roles(self, requirement: SDocNode):
         assert isinstance(requirement, SDocNode)
-        if (
-            requirement.reserved_uid is None
-            or len(requirement.reserved_uid) == 0
-        ):
+        if requirement.reserved_uid is None:
             return
 
         return list(
@@ -190,10 +178,7 @@ def get_parent_relations_with_role(
         self, requirement: SDocNode, role: Optional[str]
     ) -> List[Any]:  # FIXME: Make Any->SDocNode
         assert isinstance(requirement, SDocNode)
-        if (
-            requirement.reserved_uid is None
-            or len(requirement.reserved_uid) == 0
-        ):
+        if requirement.reserved_uid is None:
             return []
 
         return list(
@@ -208,10 +193,7 @@ def get_child_relations_with_roles(
         self, requirement: SDocNode
     ) -> List[Any]:  # FIXME: Make Any->SDocNode
         assert isinstance(requirement, SDocNode)
-        if (
-            requirement.reserved_uid is None
-            or len(requirement.reserved_uid) == 0
-        ):
+        if requirement.reserved_uid is None:
             return []
 
         return list(
@@ -226,10 +208,7 @@ def get_child_relations_with_role(
         self, requirement: SDocNode, role: Optional[str]
     ) -> List[Any]:  # FIXME: Make Any->SDocNode
         assert isinstance(requirement, SDocNode)
-        if (
-            requirement.reserved_uid is None
-            or len(requirement.reserved_uid) == 0
-        ):
+        if requirement.reserved_uid is None:
             return []
 
         return list(
@@ -247,9 +226,6 @@ def get_children_requirements(
         if not isinstance(requirement.reserved_uid, str):
             return []
 
-        if len(requirement.reserved_uid) == 0:
-            return []
-
         return list(
             self.graph_database.get_link_values(
                 link_type=GraphLinkType.NODE_TO_CHILD_NODES,
@@ -271,8 +247,6 @@ def get_counted_tags(
             link_type=GraphLinkType.DOCUMENT_TO_TAGS,
             lhs_node=document.reserved_mid,
         )
-        if document_tags_or_none is None:
-            return
         document_tags: Dict = assert_cast(document_tags_or_none, dict)
 
         tags = sorted(document_tags.keys(), key=alphanumeric_sort)
@@ -938,14 +912,11 @@ def validate_node_against_anchors(
         #    that case, we need to check if these anchors are used by any LINKs,
         #    raising a validation if they do.
         existing_node_anchor_uids = set()
-        if isinstance(node, SDocNode):
-            for node_anchor_ in node.get_anchors():
-                existing_node_anchor_uids.add(node_anchor_.value)
-        else:
-            if len(node.free_texts) > 0:
-                for part in node.free_texts[0].parts:
-                    if isinstance(part, Anchor):
-                        existing_node_anchor_uids.add(part.value)
+
+        # FIXME: No test reaches this for Section or Document.
+        assert isinstance(node, SDocNode)
+        for node_anchor_ in node.get_anchors():
+            existing_node_anchor_uids.add(node_anchor_.value)
 
         """
         Validation 1: Assert all UIDs are either:

strictdoc/helpers/math.py

@@ -6,8 +6,6 @@ def round_up(number: float, decimals):
     assert isinstance(number, float)
     assert isinstance(decimals, int)
     assert decimals >= 0
-    if decimals == 0:
-        return ceil(number)
 
     factor = 10**decimals
 

tests/unit/strictdoc/helpers/test_math.py

@@ -0,0 +1,10 @@
+from strictdoc.helpers.math import round_up
+
+
+def test_round_up():
+    assert round_up(1.3333, 0) == 2
+    assert round_up(1.3333, 1) == 1.4
+    assert round_up(1.3333, 2) == 1.34
+    assert round_up(1.3333, 3) == 1.334
+    assert round_up(1.3333, 4) == 1.3333
+    assert round_up(1.3333, 5) == 1.3333