rec and dicho reordering data!!

[andresimi]

Something strange is occuring with rec and dicho.
Look:

> data <- mtcars %>% as.tibble()
> data

# A tibble: 32 × 11
     mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb
   <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>
 1  21       6  160    110  3.9   2.62  16.5     0     1     4     4
 2  21       6  160    110  3.9   2.88  17.0     0     1     4     4
 3  22.8     4  108     93  3.85  2.32  18.6     1     1     4     1
 4  21.4     6  258    110  3.08  3.22  19.4     1     0     3     1
 5  18.7     8  360    175  3.15  3.44  17.0     0     0     3     2
 6  18.1     6  225    105  2.76  3.46  20.2     1     0     3     1
 7  14.3     8  360    245  3.21  3.57  15.8     0     0     3     4
 8  24.4     4  147.    62  3.69  3.19  20       1     0     4     2
 9  22.8     4  141.    95  3.92  3.15  22.9     1     0     4     2
10  19.2     6  168.   123  3.92  3.44  18.3     1     0     4     4
# ℹ 22 more rows
# ℹ Use `print(n = ...)` to see more rows

> data %>% 
+   rec(ends_with("b"), ends_with("s"), rec = "0:3 = 99; else = copy", suffix = "")

# A tibble: 32 × 11
     mpg   cyl  disp    hp  drat    wt  qsec  carb    am  gear    vs
   <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>
 1  21       6  160    110  3.9   2.62  16.5     4     1     4    99
 2  21       6  160    110  3.9   2.88  17.0     4     1     4    99
 3  22.8     4  108     93  3.85  2.32  18.6    99     1     4    99
 4  21.4     6  258    110  3.08  3.22  19.4    99     0     3    99
 5  18.7     8  360    175  3.15  3.44  17.0    99     0     3    99
 6  18.1     6  225    105  2.76  3.46  20.2    99     0     3    99
 7  14.3     8  360    245  3.21  3.57  15.8     4     0     3    99
 8  24.4     4  147.    62  3.69  3.19  20      99     0     4    99
 9  22.8     4  141.    95  3.92  3.15  22.9    99     0     4    99
10  19.2     6  168.   123  3.92  3.44  18.3     4     0     4    99
# ℹ 22 more rows
# ℹ Use `print(n = ...)` to see more rows

They are reordering data! We can't rely on tidy select anymore, because the variables order changes after the command.

Also, if you recode a group tibble, it messes things up too.

> data %>% 
+   group_by(carb) %>% 
+   rec(ends_with("b"), ends_with("s"), rec = "0:3 = 99; else = copy", suffix = "")

New names:
• `carb` -> `carb...1`
• `carb` -> `carb...2`
New names:
• `carb` -> `carb...10`
• `carb...1` -> `carb...11`
• `carb...2` -> `carb...12`

# A tibble: 32 × 13
     mpg   cyl  disp    hp  drat    wt  qsec carb...11    am  gear carb...10 carb...12    vs
   <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>     <dbl> <dbl> <dbl>     <dbl>     <dbl> <dbl>
 1  21       6  160    110  3.9   2.62  16.5         4     1     4         4         4    99
 2  21       6  160    110  3.9   2.88  17.0         4     1     4         4         4    99
 3  22.8     4  108     93  3.85  2.32  18.6        99     1     4         1        99    99
 4  21.4     6  258    110  3.08  3.22  19.4        99     0     3         1        99    99
 5  18.7     8  360    175  3.15  3.44  17.0        99     0     3         2        99    99
 6  18.1     6  225    105  2.76  3.46  20.2        99     0     3         1        99    99
 7  14.3     8  360    245  3.21  3.57  15.8         4     0     3         4         4    99
 8  24.4     4  147.    62  3.69  3.19  20          99     0     4         2        99    99
 9  22.8     4  141.    95  3.92  3.15  22.9        99     0     4         2        99    99
10  19.2     6  168.   123  3.92  3.44  18.3         4     0     4         4         4    99
# ℹ 22 more rows
# ℹ Use `print(n = ...)` to see more rows

Best!