[discussion] sb extract

[dvh91]

As for now, the logic behind extract function in storybook CLI is basically getting the storybook build running in a web server using puppeteer in order to get the stories from the internal client storybook state store.

There're use-cases of using this CLI command in CI environment and it's a pretty much an overkill to get a puppeteer and run the whole build only to get the stories metadata.

The use case I'm using stories.json is for newly introduced composed storybook.

Raising this to discussion to see what the community thinks. I might be available to help out implementing something.

[shilman]

AFAIK this is by design. The alternative, JSDOM, has too many corner cases, so we chose Puppeteer to sidestep all of these by running in a real browser.

Hosted services like Chromatic also support stories.json generation automatically, so you don't have to worry about it.

cc @ndelangen

[ndelangen]

@dvh91 we are moving towards having storybook config be declarative & stories be declarative, parameters & decorators & args be declarative.

These are building blocks for being able to extract the stories.json out without using a browser.

We can't do it -right now- but over time we'll hopefully be able to deprecate the non-declarative methods, and extract all data via static analysis.

[dvh91]

@ndelangen Thanks for the answer!
Do you know what part of the stories.json is required for the sb composition (chp level 1) ?

trying to figure out if I can, for this use case, use some other solution for the stories.json creation.

[ndelangen]

Not required, but recommended for performance reasons.

[dvh91]

Oh cool! Didn't realize it from the docs.

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[pardoman]

I also echo the sentiment that relying on puppeteer to generate a JSON file is overkill. I also understand that the developer team is working towards a solution that doesn't include puppeteer, and that's great.

Could someone link the GitHub Issue # so that we can tracking its progress? Something like "remove puppeteer from sb extract". Thanks.

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[pardoman]

Bump due to stale bot's participation.