fix: safeStringify should not re-stringify

Author: marbemac

package.json

@@ -41,7 +41,7 @@
   },
   "dependencies": {
     "@stoplight/fast-safe-stringify": "2.1.2",
-    "@stoplight/types": "4.0.x",
+    "@stoplight/types": "5.x.x",
     "jsonc-parser": "2.1.0",
     "lodash": "4.x.x"
   },
@@ -54,7 +54,7 @@
     "ts-jest": "24.0.x",
     "tslint": "5.14.x",
     "tslint-config-stoplight": "1.2.x",
-    "typescript": "3.3.4000"
+    "typescript": "3.4.5"
   },
   "lint-staged": {
     "*.{ts,tsx}$": [

src/__tests__/safeStringify.ts

@@ -55,8 +55,9 @@ describe('safeStringify', () => {
     expect(safeStringify({ value: undefined })).toBe('{}');
   });
 
-  it('should not stringify twice', () => {
-    expect(safeStringify('"0"')).toBe('"0"');
+  it('should not stringify something that is already a string', () => {
+    // invalid json (for example coming from user in code editor) SHOULD not stringify again
+    expect(safeStringify('{"foo": "bar",}')).toBe('{"foo": "bar",}');
     expect(safeStringify(JSON.stringify({ foo: 'bar' }))).toBe(JSON.stringify({ foo: 'bar' }));
   });
 });

src/index.ts

@@ -3,7 +3,6 @@ export * from './decodePointer';
 export * from './decodePointerFragment';
 export * from './encodePointer';
 export * from './encodePointerFragment';
-export * from './isStringified';
 export * from './pathToPointer';
 export * from './pointerToPath';
 export * from './safeParse';

src/isStringified.ts

@@ -1,12 +1,11 @@
 import fastStringify from '@stoplight/fast-safe-stringify';
-import { isStringified } from './isStringified';
 
 export const safeStringify = (
   value: any,
   replacer?: (key: string, value: any) => any | Array<string | number> | null,
   space?: string | number
 ): string => {
-  if (isStringified(value)) {
+  if (typeof value === 'string') {
     return value;
   }