Merge #286

286: Tidy lints for MDMA and OCTOSPI r=richardeoin a=richardeoin



Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com>

Author: bors[bot]

examples/ethernet-nucleo-h743zi2.rs

@@ -16,7 +16,6 @@ use stm32h7xx_hal::hal::digital::v2::OutputPin;
 use stm32h7xx_hal::rcc::CoreClocks;
 use stm32h7xx_hal::{ethernet, ethernet::PHY};
 use stm32h7xx_hal::{prelude::*, stm32, stm32::interrupt};
-use Speed::*;
 
 /// Configure SYSTICK for 1ms timebase
 fn systick_init(syst: &mut stm32::SYST, clocks: CoreClocks) {

src/dma/mdma.rs

@@ -228,14 +228,11 @@ impl Default for MdmaIncrement {
 }
 
 /// MDMA burst size. This type contains the _register_ value, thus the burst
-/// size is equal to 2^N where N is the register value
-#[derive(Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
+/// size is equal to 2^N where N is the register value.
+///
+/// The derived Default implementation gives a burst size of 2^0 = 1
+#[derive(Clone, Copy, Default, PartialEq, Eq, PartialOrd, Ord)]
 pub struct MdmaBurstSize(pub(crate) u8);
-impl Default for MdmaBurstSize {
-    fn default() -> Self {
-        MdmaBurstSize(0)
-    }
-}
 impl MdmaBurstSize {
     // TODO: add const to make this a const fn
     fn from_size(mut v: usize) -> Self {
@@ -1240,7 +1237,9 @@ mdma_stream!(
     (Stream15, ch15, 15),
 );
 
+#[cfg(not(feature = "rm0455"))] // TODO remove
 type P2M = PeripheralToMemory;
+#[cfg(not(feature = "rm0455"))] // TODO remove
 type M2P = MemoryToPeripheral;
 
 // Access the QSPI data register as a u32 for bus access efficiency. The MDMA

src/xspi/octospi.rs

@@ -2,6 +2,7 @@
 //!
 //! See the parent module for documentation
 
+#[allow(unused)] // TODO remove
 use crate::{
     gpio::{
         gpioa::{PA1, PA2, PA3, PA6, PA7},