Merge #325

325: Gpio inherent r=therealprof a=burrbull

Depends on #266 

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>

Author: bors[bot]

CHANGELOG.md

@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
+- `PinState` and `get/set_state`.
+- Inherent methods for infallible digital operations.
 - Generic `into_alternate` and `into_alternate_open_drain`. Non-generic ones are deprecated
 - Internal implementation of GPIO Pin API changed to use Const Generics
 - `PinExt` trait. Make `ExtiPin` implementation generic

examples/analog-stopwatch-with-spi-ssd1306.rs

@@ -118,9 +118,9 @@ fn main() -> ! {
     let mut ss = gpioe.pe4.into_push_pull_output();
     let mut delay = hal::delay::Delay::new(cp.SYST, clocks);
 
-    ss.set_high().unwrap();
+    ss.set_high();
     delay.delay_ms(100_u32);
-    ss.set_low().unwrap();
+    ss.set_low();
 
     // Set up the display
     let interface = SPIInterfaceNoCS::new(spi, dc);
@@ -164,21 +164,21 @@ fn main() -> ! {
 
         match state {
             StopwatchState::Ready => {
-                led3.set_high().unwrap();
-                led4.set_low().unwrap();
+                led3.set_high();
+                led4.set_low();
             }
             StopwatchState::Running => {
                 if state_led {
-                    led4.set_low().unwrap();
-                    led3.set_high().unwrap();
+                    led4.set_low();
+                    led3.set_high();
                 } else {
-                    led4.set_low().unwrap();
-                    led3.set_low().unwrap();
+                    led4.set_low();
+                    led3.set_low();
                 }
             }
             StopwatchState::Stopped => {
-                led3.set_low().unwrap();
-                led4.set_high().unwrap();
+                led3.set_low();
+                led4.set_high();
             }
         };
 
@@ -282,7 +282,7 @@ fn TIM2() {
             StopwatchState::Stopped => {
                 let mut btn_ref = BUTTON.borrow(cs).borrow_mut();
                 if let Some(ref mut btn) = btn_ref.deref_mut() {
-                    if btn.is_high().unwrap() {
+                    if btn.is_high() {
                         cell_reset.replace(val_reset + 1);
                     }
                 }

examples/blinky-timer-irq.rs

@@ -20,7 +20,6 @@ use crate::hal::{
 use core::cell::RefCell;
 use cortex_m::{asm::wfi, interrupt::Mutex};
 use cortex_m_rt::entry;
-use embedded_hal::digital::v2::OutputPin;
 use embedded_hal::timer::CountDown;
 
 // NOTE You can uncomment 'hprintln' here and in the code below for a bit more

examples/delay-blinky.rs

@@ -30,9 +30,9 @@ fn main() -> ! {
 
         loop {
             // On for 1s, off for 1s.
-            led.set_high().unwrap();
+            led.set_high();
             delay.delay_ms(1000_u32);
-            led.set_low().unwrap();
+            led.set_low();
             delay.delay_ms(1000_u32);
         }
     }

examples/dwt-blinky.rs

@@ -38,12 +38,12 @@ fn main() -> ! {
         let mut sw = dwt.stopwatch(&mut lap_times);
         loop {
             // On for 1s, off for 1s.
-            led1.set_high().unwrap();
-            led2.set_low().unwrap();
+            led1.set_high();
+            led2.set_low();
             delay.delay_ms(1000_u32);
             sw.lap();
-            led1.set_low().unwrap();
-            led2.set_high().unwrap();
+            led1.set_low();
+            led2.set_high();
             delay.delay_ms(900_u32);
             // Also you can measure with almost clock precision
             let cd: ClockDuration = dwt.measure(|| delay.delay_ms(100_u32));

examples/f413disco_lcd_ferris.rs

@@ -743,7 +743,7 @@ fn main() -> ! {
         let mut _te = gpiob.pb14.into_floating_input();
 
         // Enable backlight
-        gpioe.pe5.into_push_pull_output().set_high().ok();
+        gpioe.pe5.into_push_pull_output().set_high();
 
         // Get delay provider
         let mut delay = Delay::new(cp.SYST, clocks);

examples/i2s-audio-out-dma.rs

@@ -148,7 +148,7 @@ fn main() -> ! {
     // Keep DAC reset low for at least one millisecond
     delay.delay_ms(1u8);
     // Release the DAC from reset
-    dac_reset.set_high().unwrap();
+    dac_reset.set_high();
     // Wait at least 550 ns before starting I2C communication
     delay.delay_us(1u8);
 

examples/i2s-audio-out.rs

@@ -145,7 +145,7 @@ fn main() -> ! {
     // Keep DAC reset low for at least one millisecond
     delay.delay_ms(1u8);
     // Release the DAC from reset
-    dac_reset.set_high().unwrap();
+    dac_reset.set_high();
     // Wait at least 550 ns before starting I2C communication
     delay.delay_us(1u8);
 

examples/qei.rs

@@ -52,8 +52,8 @@ fn main() -> ! {
             // Light up the LED when turning clockwise, turn it off
             // when turning counter-clockwise.
             match rotary_encoder.direction() {
-                RotaryDirection::Upcounting => led.set_low().unwrap(),
-                RotaryDirection::Downcounting => led.set_high().unwrap(),
+                RotaryDirection::Upcounting => led.set_low(),
+                RotaryDirection::Downcounting => led.set_high(),
             }
 
             current_count = new_count;

examples/rtic.rs

@@ -38,6 +38,6 @@ const APP: () = {
     #[task(binds = EXTI0, resources = [button, led])]
     fn button_click(ctx: button_click::Context) {
         ctx.resources.button.clear_interrupt_pending_bit();
-        ctx.resources.led.toggle().unwrap();
+        ctx.resources.led.toggle();
     }
 };