Merge #332

332: Serial::tx/rx r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>

Author: bors[bot]

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
+- `Serial:tx` and `Serial::rx` that take only 1 pin
 - Instead of `Alternate<AF1>` you can just use `Alternate<1>`.
 - `PinState` and `get/set_state`.
 - Inherent methods for infallible digital operations.

examples/serial-9bit.rs

@@ -62,7 +62,7 @@ fn main() -> ! {
     let rx_pin = gpioa.pa3.into_alternate();
 
     // configure serial
-    let serial = Serial::usart2(
+    let serial = Serial::new(
         dp.USART2,
         (tx_pin, rx_pin),
         Config::default().baudrate(9600.bps()).wordlength_9(),

examples/serial.rs

@@ -25,19 +25,16 @@ fn main() -> ! {
 
     // define RX/TX pins
     let tx_pin = gpioa.pa2.into_alternate();
-    let rx_pin = gpioa.pa3.into_alternate();
 
     // configure serial
-    let serial = Serial::usart2(
+    let mut tx = Serial::tx(
         dp.USART2,
-        (tx_pin, rx_pin),
+        tx_pin,
         Config::default().baudrate(9600.bps()),
         clocks,
     )
     .unwrap();
 
-    let (mut tx, mut _rx) = serial.split();
-
     let mut value: u8 = 0;
 
     loop {

src/serial.rs

@@ -724,7 +724,42 @@ where
         }
         .config_stop(config))
     }
+}
+
+impl<USART, TX, WORD> Serial<USART, (TX, NoRx), WORD>
+where
+    (TX, NoRx): Pins<USART>,
+    USART: Instance,
+{
+    pub fn tx(
+        usart: USART,
+        tx_pin: TX,
+        config: config::Config,
+        clocks: Clocks,
+    ) -> Result<Tx<USART, WORD>, config::InvalidConfig> {
+        Self::new(usart, (tx_pin, NoRx), config, clocks).map(|s| s.split().0)
+    }
+}
 
+impl<USART, RX, WORD> Serial<USART, (NoTx, RX), WORD>
+where
+    (NoTx, RX): Pins<USART>,
+    USART: Instance,
+{
+    pub fn rx(
+        usart: USART,
+        rx_pin: RX,
+        config: config::Config,
+        clocks: Clocks,
+    ) -> Result<Rx<USART, WORD>, config::InvalidConfig> {
+        Self::new(usart, (NoTx, rx_pin), config, clocks).map(|s| s.split().1)
+    }
+}
+
+impl<USART, PINS, WORD> Serial<USART, PINS, WORD>
+where
+    USART: Instance,
+{
     /// Starts listening for an interrupt event
     ///
     /// Note, you will also have to enable the corresponding interrupt
@@ -1358,9 +1393,8 @@ where
     Serial<USART, PINS>: serial::Write<u8>,
 {
     fn write_str(&mut self, s: &str) -> fmt::Result {
-        s.as_bytes()
-            .iter()
-            .try_for_each(|c| block!(self.write(*c)))
+        s.bytes()
+            .try_for_each(|c| block!(self.write(c)))
             .map_err(|_| fmt::Error)
     }
 }
@@ -1370,9 +1404,8 @@ where
     Tx<USART>: serial::Write<u8>,
 {
     fn write_str(&mut self, s: &str) -> fmt::Result {
-        s.as_bytes()
-            .iter()
-            .try_for_each(|c| block!(self.write(*c)))
+        s.bytes()
+            .try_for_each(|c| block!(self.write(c)))
             .map_err(|_| fmt::Error)
     }
 }