Merge pull request #313 from Sh3Rm4n/fix-error

Make errors public

Author: Sh3Rm4n

CHANGELOG.md

@@ -49,7 +49,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
   which resulted into the situtation, that BSD 0-clause was not affectivly
   0-clause as MIT conditions had to be met anyways. (🧂 IANAL). ([#309])
 - Renamed `Serial::raw_read` to `Serial::read_data_register`. ([#281])
-- Timer error type `AlreadyCancled` is no longer public constructable. ([#281])
 - Seal `FlashExt` and `RccExt` traits. These are no longer implementable by
   a user of this crate. ([#281])
 - Move ADC from a macro to a generic implementation, meaning that

src/adc/channel.rs

@@ -125,7 +125,7 @@ impl TryFrom<u8> for Id {
             16 => Id::Sixteen,
             17 => Id::Seventeen,
             18 => Id::Eighteen,
-            _ => return Err(crate::TryFromIntError(())),
+            _ => return Err(crate::TryFromIntError),
         })
     }
 }

src/adc/config.rs

@@ -116,7 +116,7 @@ impl TryFrom<u8> for Sequence {
             13 => Sequence::Fourteen,
             14 => Sequence::Fifteen,
             15 => Sequence::Sixteen,
-            _ => return Err(crate::TryFromIntError(())),
+            _ => return Err(crate::TryFromIntError),
         })
     }
 }

src/lib.rs

@@ -299,4 +299,4 @@ impl From<bool> for Toggle {
 /// in multiple occasions inside this crate.
 #[derive(Debug, Copy, Clone, PartialEq, Eq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
-pub struct TryFromIntError(pub(crate) ());
+pub struct TryFromIntError;

src/timer.rs

@@ -323,7 +323,7 @@ where
 /// Error if a [`Cancel`]-ble [`Timer`] was cancled already or never been started.
 #[derive(Debug, Copy, Clone, PartialEq, Eq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
-pub struct AlreadyCancled(pub(crate) ());
+pub struct AlreadyCancled;
 
 impl<TIM> Cancel for Timer<TIM>
 where
@@ -333,7 +333,7 @@ where
     fn cancel(&mut self) -> Result<(), Self::Error> {
         // If timer is already stopped.
         if !self.tim.is_cr1_cen_set() {
-            return Err(AlreadyCancled(()));
+            return Err(AlreadyCancled);
         }
         self.stop();
         Ok(())

testsuite/tests/timer.rs

@@ -120,8 +120,8 @@ mod tests {
         timer.start(10.milliseconds());
         state.delay.delay_ms(5u32);
 
-        assert!(matches!(timer.cancel(), Ok(())));
-        assert!(matches!(timer.cancel(), Err(AlreadyCancled)));
+        assert_eq!(timer.cancel(), Ok(()));
+        assert_eq!(timer.cancel(), Err(AlreadyCancled));
         state.timer = Some(timer);
     }