Implement changes after code review

Author: franeklubi

.cargo/config

@@ -13,6 +13,6 @@ rustflags = [
 [build]
 # Pick ONE of these compilation targets
 # target = "thumbv6m-none-eabi"    # Cortex-M0 and Cortex-M0+
-target = "thumbv7m-none-eabi"    # Cortex-M3
+# target = "thumbv7m-none-eabi"    # Cortex-M3
 # target = "thumbv7em-none-eabi"   # Cortex-M4 and Cortex-M7 (no FPU)
-# target = "thumbv7em-none-eabihf" # Cortex-M4F and Cortex-M7F (with FPU)
+target = "thumbv7em-none-eabihf" # Cortex-M4F and Cortex-M7F (with FPU)

Cargo.toml

@@ -4,7 +4,7 @@ name = "stm32-eth"
 description = "Embedded Rust Ethernet driver for the STM32 MCU series"
 license = "Apache-2.0"
 authors = ["Astro <astro@spaceboyz.net>"]
-version = "0.3.0"
+version = "0.2.0"
 keywords = ["ethernet", "eth", "stm32", "stm32f4", "stm32f7"]
 repository = "https://github.com/stm32-rs/stm32-eth"
 documentation = "https://docs.rs/stm32-eth/"

Embed.toml

@@ -15,7 +15,7 @@ Please send pull requests.
 ```bash
 cargo build --example="pktgen" --features="stm32f429"
 cargo build --example="ip" --features="stm32f429 smoltcp-phy log smoltcp/socket-tcp smoltcp/socket-icmp smoltcp/log smoltcp/verbose"
-cargo build --example="ip-f107" --features="stm32f107 smoltcp-phy log smoltcp/socket-tcp smoltcp/socket-icmp" --release
+cargo build --example="ip-f107" --features="stm32f107 smoltcp-phy log smoltcp/socket-tcp smoltcp/socket-icmp smoltcp/log smoltcp/verbose"
 ```
 
 ## Usage

README.md

@@ -25,7 +25,6 @@ use smoltcp::wire::{
 use stm32_eth::{
     hal::gpio::{GpioExt, Speed},
     hal::rcc::RccExt,
-    // hal::time::U32Ext,
     smi,
     stm32::{interrupt, CorePeripherals, Peripherals, SYST},
 };

examples/arp-smoltcp.rs

@@ -1,5 +1,4 @@
 /* STM32F429 */
-/*
 MEMORY
 {
   FLASH (rx)      : ORIGIN = 0x8000000, LENGTH = 2048K
@@ -10,11 +9,12 @@ MEMORY
 }
 _stack_start = ORIGIN(RAM) + LENGTH(RAM);
 _heap_size = LENGTH(RAM) - 4K;
-*/
 
 /* STM32F107 */
+/*
 MEMORY
 {
   FLASH : ORIGIN = 0x08000000, LENGTH = 128K
   RAM : ORIGIN = 0x20000000, LENGTH = 32K
 }
+*/

memory.x

@@ -177,10 +177,7 @@ impl<'rx, 'tx> Eth<'rx, 'tx> {
         // Flow Control Register
         self.eth_mac.macfcr.modify(|_, w| {
             // Pause time
-            #[allow(unused_unsafe)]
-            unsafe {
-                w.pt().bits(0x100)
-            }
+            w.pt().bits(0x100)
         });
 
         // operation mode register

src/lib.rs

@@ -231,10 +231,10 @@ impl<'a> RxRing<'a> {
         }
         self.next_entry = 0;
         let ring_ptr = self.entries[0].desc() as *const RxDescriptor;
+
         // Register RxDescriptor
         eth_dma
             .dmardlar
-            // Note: unsafe block required for `stm32f107`.
             .write(|w| unsafe { w.srl().bits(ring_ptr as u32) });
 
         // We already have fences in `set_owned`, which is called in `setup`