amend dumb idea of aliasing #present? to positive? in all TimingManageable sibling classes; v. 7-0.7.25

Author: steveoro

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 _Please, add the latest build info on top of the list; use Version::MAJOR only after gold release; keep semantic versioning in line with framework's_
 
+- **0.7.25** [Steve A.] amend dumb idea of aliasing #present? to positive? in all TimingManageable sibling classes
 - **0.7.24** [Steve A.] bundle updates & rubocop updates; moved zero?, positive? & present? helpers directly into TimingManageable; specs updates
 - **0.7.23** [Steve A.] bundle updates
 - **0.7.20** [Steve A.] bundle updates; added a missing/new EventType used for Coopernuoto meetings ('6X50SL')

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    goggles_db (0.7.24)
+    goggles_db (0.7.25)
       acts-as-taggable-on
       acts_as_votable
       cities

Guardfile

@@ -85,7 +85,7 @@ end
 rspec_options = {
   cmd: 'spec/dummy/bin/rspec',
   # Exclude performance tests; to make it fail-fast, add option "--fail-fast":
-  cmd_additional_args: ' --color --profile 10 --order rand -f RspecPacmanFormatter::Pacman -t ~type:performance',
+  cmd_additional_args: ' --color --profile 10 --order rand -f doc -t ~type:performance',
   all_after_pass: false,
   failed_mode: :focus
 }

app/models/concerns/timing_manageable.rb

@@ -51,9 +51,6 @@ def positive?
     base_timing_positive || minutes_from_start.positive? || seconds_from_start.positive? || hundredths_from_start.positive?
   end
 
-  # Make sure only positive timings will be considered as "present":
-  alias present? positive? # (new, old)
-
   # Returns +true+ if the timing associated with this result is zero.
   # If the includee responds (at least) also to #hundredths_from_start,
   # this will check all the <tt>XXX_from_start</tt> columns as well.

lib/goggles_db/version.rb

@@ -6,7 +6,7 @@
 #
 module GogglesDb
   # Public gem version (uses Semantic versioning)
-  VERSION = '0.7.24'
+  VERSION = '0.7.25'
 
   # == Versioning codes
   #
@@ -19,8 +19,8 @@ module Version
     CORE  = 'C7'
     MAJOR = '0'
     MINOR = '7'
-    PATCH = '24'
-    BUILD = '20241115'
+    PATCH = '25'
+    BUILD = '20241119'
 
     # Full label
     FULL = "#{MAJOR}.#{MINOR}.#{PATCH} (#{CORE}-#{BUILD})".freeze

spec/models/goggles_db/meeting_individual_result_spec.rb

@@ -208,5 +208,7 @@ module GogglesDb
         )
       end
     end
+    #-- ------------------------------------------------------------------------
+    #++
   end
 end

spec/support/shared_timing_manageable_examples.rb

@@ -30,7 +30,7 @@
   context 'by including this concern, the sibling:' do
     subject { fixture_row }
 
-    it_behaves_like('responding to a list of methods', %i[hundredths seconds minutes to_timing from_timing positive? present? zero?])
+    it_behaves_like('responding to a list of methods', %i[hundredths seconds minutes to_timing from_timing positive? zero?])
   end
 
   context 'for any result with positive time,' do
@@ -47,7 +47,7 @@
     end
 
     describe '#present?' do
-      it 'is true' do
+      it 'is always true' do
         expect(subject.present?).to be true
       end
     end
@@ -80,8 +80,8 @@
     end
 
     describe '#present?' do
-      it 'is false' do
-        expect(subject.present?).to be false
+      it 'is always true' do
+        expect(subject.present?).to be true
       end
     end
 
@@ -92,6 +92,17 @@
     end
   end
 
+  context 'a new instance with zero timing' do
+    subject { described_class.new }
+
+    it 'is always #present?, even if #zero? is true' do
+      expect(subject.zero?).to be true
+      expect(subject.present?).to be true
+    end
+  end
+  #-- ------------------------------------------------------------------------
+  #++
+
   describe '#to_timing' do
     context 'when from_start is false (default),' do
       subject { fixture_row.to_timing }