safe navigation in SwimmerDecorator#display_label when gender is not defined; added bias parameter in CmdFindDBEntity <- DbFinders::FuzzySwimmer because sometimes the default 0.8 doesn't fit the case; refactored Swimmer#age_for_category_range from [Admin2]PdfResults::L2Converter; bundle update; vers. 0.8.00

Author: steveoro

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 _Please, add the latest build info on top of the list; use Version::MAJOR only after gold release; keep semantic versioning in line with framework's_
 
+- **0.8.00** [Steve A.] safe navigation in SwimmerDecorator#display_label when gender is not defined; added bias parameter in CmdFindDBEntity <- DbFinders::FuzzySwimmer because sometimes the default 0.8 doesn't fit the case; refactored Swimmer#age_for_category_range from [Admin2]PdfResults::L2Converter; bundle update
 - **0.7.25** [Steve A.] amend dumb idea of aliasing #present? to positive? in all TimingManageable sibling classes
 - **0.7.24** [Steve A.] bundle updates & rubocop updates; moved zero?, positive? & present? helpers directly into TimingManageable; specs updates
 - **0.7.23** [Steve A.] bundle updates

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    goggles_db (0.7.25)
+    goggles_db (0.8.00)
       acts-as-taggable-on
       acts_as_votable
       cities
@@ -137,7 +137,7 @@ GEM
     country_select (10.0.0)
       countries (> 5.0, < 8.0)
     crass (1.0.6)
-    date (3.4.0)
+    date (3.4.1)
     debug_inspector (1.2.0)
     devise (4.9.4)
       bcrypt (~> 3.0)
@@ -156,13 +156,13 @@ GEM
       activesupport (>= 5.0)
       request_store (>= 1.0)
       ruby2_keywords
-    erubi (1.13.0)
+    erubi (1.13.1)
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     factory_bot_rails (6.4.4)
       factory_bot (~> 6.5)
       railties (>= 5.0.0)
-    faraday (2.12.1)
+    faraday (2.12.2)
       faraday-net_http (>= 2.0, < 3.5)
       json
       logger
@@ -234,7 +234,7 @@ GEM
       sparkr (>= 0.2.0)
       term-ansicolor
       yard (~> 0.9.12)
-    json (2.8.2)
+    json (2.9.1)
     jwt (2.9.3)
       base64
     language_server-protocol (3.17.0.3)
@@ -248,7 +248,7 @@ GEM
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    logger (1.6.1)
+    logger (1.6.4)
     loofah (2.23.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
@@ -262,15 +262,15 @@ GEM
     method_source (1.1.0)
     mini_magick (5.0.1)
     mini_mime (1.1.5)
-    minitest (5.25.1)
+    minitest (5.25.4)
     multi_json (1.15.0)
     multi_xml (0.7.1)
       bigdecimal (~> 3.1)
     mysql2 (0.5.6)
     nenv (0.3.0)
-    net-http (0.5.0)
+    net-http (0.6.0)
       uri
-    net-imap (0.5.1)
+    net-imap (0.5.4)
       date
       net-protocol
     net-pop (0.1.2)
@@ -280,7 +280,7 @@ GEM
     net-smtp (0.5.0)
       net-protocol
     nio4r (2.7.4)
-    nokogiri (1.16.7-x86_64-linux)
+    nokogiri (1.17.2-x86_64-linux)
       racc (~> 1.4)
     notiffany (0.1.3)
       nenv (~> 0.1)
@@ -348,9 +348,9 @@ GEM
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
-    rails-html-sanitizer (1.6.0)
+    rails-html-sanitizer (1.6.2)
       loofah (~> 2.21)
-      nokogiri (~> 1.14)
+      nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
     rails-i18n (6.0.0)
       i18n (>= 0.7, < 2)
       railties (>= 6.0.0, < 7)
@@ -365,7 +365,7 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)
-    regexp_parser (2.9.2)
+    regexp_parser (2.9.3)
     request_store (1.7.0)
       rack (>= 1.4)
     responders (3.1.1)
@@ -392,23 +392,23 @@ GEM
       rspec-expectations (~> 3.13)
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
-    rspec-support (3.13.1)
+    rspec-support (3.13.2)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
     rspec_pacman_formatter (0.1.7)
       colorize
       rspec
-    rubocop (1.68.0)
+    rubocop (1.69.2)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 2.4, < 3.0)
-      rubocop-ast (>= 1.32.2, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.36.2, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.36.1)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.37.0)
       parser (>= 3.3.1.0)
     rubocop-factory_bot (2.26.1)
       rubocop (~> 1.61)
@@ -422,7 +422,7 @@ GEM
       rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (3.2.0)
+    rubocop-rspec (3.3.0)
       rubocop (~> 1.61)
     rubocop-rspec_rails (2.30.0)
       rubocop (~> 1.61)
@@ -476,15 +476,17 @@ GEM
     term-ansicolor (1.11.2)
       tins (~> 1.0)
     thor (1.3.2)
-    tilt (2.4.0)
-    timeout (0.4.2)
-    tins (1.37.0)
+    tilt (2.5.0)
+    timeout (0.4.3)
+    tins (1.37.1)
       bigdecimal
       sync
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unaccent (0.4.0)
-    unicode-display_width (2.6.0)
+    unicode-display_width (3.1.2)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
     uniform_notifier (1.16.0)
     uri (1.0.2)
     version_gem (1.1.4)

app/commands/goggles_db/cmd_find_db_entity.rb

@@ -6,9 +6,10 @@
 module GogglesDb
   #
   # = Generic DB entity fuzzy-finder command
-  #   - version:  7-0.5.01
+  #
+  #   - version:  7-0.8.00
   #   - author:   Steve A.
-  #   - build:    20230401
+  #   - build:    20241223
   #
   # Uses the DbFinders::Factory to create a specific fuzzy-finder for
   # the specified DB entity.
@@ -53,6 +54,7 @@ class CmdFindDbEntity
     #   the verbose search output on the console (default: false); this will be removed from
     #   the search terms.
     #
+    # - <tt>bias</tt>: fuzzy search bias for a match (default: BaseStrategy::DEFAULT_MATCH_BIAS)
     #
     # == Example usage:
     #
@@ -68,9 +70,9 @@ class CmdFindDbEntity
     #   > cmd.result
     #   => #<GogglesDb::Team id: 1, ...>
     #
-    def initialize(model_klass, search_terms = {})
+    def initialize(model_klass, search_terms = {}, bias = DbFinders::BaseStrategy::DEFAULT_MATCH_BIAS)
       @search_terms = search_terms
-      @finder = DbFinders::Factory.for(model_klass, search_terms)
+      @finder = DbFinders::Factory.for(model_klass, search_terms, bias)
       @matches = []
     end
 

app/strategies/goggles_db/db_finders/factory.rb

@@ -7,9 +7,9 @@ module DbFinders
     #
     # = DbFinders singleton factory
     #
-    #   - version:  7-0.4.01
+    #   - version:  7-0.8.00
     #   - author:   Steve A.
-    #   - build:    20220804
+    #   - build:    20241223
     #
     # Allows to create a plug-in strategy object for finding a specific entity given the search
     # parameters.
@@ -34,34 +34,36 @@ class Factory
       #   the verbose search output on the console (default: false); this will be removed from
       #   the search terms (as all other column names non valid as search terms).
       #
+      # - <tt>bias</tt>: fuzzy search bias for a match (default: BaseStrategy::DEFAULT_MATCH_BIAS)
+      #
       # == Returns
       # A <tt>DbFinders::BaseStrategy</tt> sibling
       #
       # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-      def self.for(model_klass, search_terms = {})
+      def self.for(model_klass, search_terms = {}, bias = BaseStrategy::DEFAULT_MATCH_BIAS)
         raise(ArgumentError, 'No search term specified') if search_terms.blank? ||
                                                             search_terms.except(:toggle_debug).blank?
 
         if model_klass == GogglesDb::Swimmer
           # Add also strict parameter checking for the search terms in all models, like this:
           search_terms.keep_if { |key, _v| %i[complete_name year_of_birth gender_type_id toggle_debug].include?(key) }
-          FuzzySwimmer.new(search_terms)
+          FuzzySwimmer.new(search_terms, bias)
 
         elsif model_klass == GogglesDb::Team
           search_terms.keep_if { |key, _v| %i[name editable_name name_variations city_id toggle_debug].include?(key) }
-          FuzzyTeam.new(search_terms)
+          FuzzyTeam.new(search_terms, bias)
 
         elsif model_klass == GogglesDb::SwimmingPool
           search_terms.keep_if { |key, _v| %i[name nick_name pool_type_id city_id toggle_debug].include?(key) }
-          FuzzyPool.new(search_terms)
+          FuzzyPool.new(search_terms, bias)
 
         elsif model_klass == GogglesDb::Meeting
           search_terms.keep_if { |key, _v| %i[description code header_year season_id toggle_debug].include?(key) }
-          FuzzyMeeting.new(search_terms)
+          FuzzyMeeting.new(search_terms, bias)
 
         elsif model_klass == GogglesDb::City
           search_terms.keep_if { |key, _v| %i[name area country country_code toggle_debug].include?(key) }
-          FuzzyCity.new(search_terms)
+          FuzzyCity.new(search_terms, bias)
 
         else
           raise(ArgumentError, 'New, unsupported or unimplemented model class!')

app/strategies/goggles_db/db_finders/fuzzy_city.rb

@@ -5,9 +5,9 @@ module DbFinders
     #
     # = FuzzyCity finder strategy
     #
-    #   - version:  7-0.3.53
+    #   - version:  7-0.8.00
     #   - author:   Steve A.
-    #   - build:    20220526
+    #   - build:    20241223
     #
     class FuzzyCity < BaseStrategy
       # Creates a new search strategy instance given the parameters.
@@ -23,8 +23,10 @@ class FuzzyCity < BaseStrategy
       #   the verbose search output on the console (default: false); this will be removed from
       #   the search terms.
       #
-      def initialize(search_terms = {})
-        super(GogglesDb::City, search_terms, :for_name, 0.8)
+      # - <tt>bias</tt>: fuzzy search bias for a match (default: BaseStrategy::DEFAULT_MATCH_BIAS)
+      #
+      def initialize(search_terms = {}, bias = BaseStrategy::DEFAULT_MATCH_BIAS)
+        super(GogglesDb::City, search_terms, :for_name, bias)
       end
       #-- --------------------------------------------------------------------------
       #++

app/strategies/goggles_db/db_finders/fuzzy_meeting.rb

@@ -5,9 +5,9 @@ module DbFinders
     #
     # = FuzzyMeeting finder strategy
     #
-    #   - version:  7-0.4.01
+    #   - version:  7-0.8.00
     #   - author:   Steve A.
-    #   - build:    20220823
+    #   - build:    20241223
     #
     class FuzzyMeeting < BaseStrategy
       # Creates a new search strategy instance given the parameters.
@@ -20,8 +20,10 @@ class FuzzyMeeting < BaseStrategy
       #   the verbose search output on the console (default: false); this will be removed from
       #   the search terms.
       #
-      def initialize(search_terms = {})
-        super(GogglesDb::Meeting, search_terms, :for_name, DEFAULT_MATCH_BIAS)
+      # - <tt>bias</tt>: fuzzy search bias for a match (default: BaseStrategy::DEFAULT_MATCH_BIAS)
+      #
+      def initialize(search_terms = {}, bias = BaseStrategy::DEFAULT_MATCH_BIAS)
+        super(GogglesDb::Meeting, search_terms, :for_name, bias)
       end
       #-- --------------------------------------------------------------------------
       #++

app/strategies/goggles_db/db_finders/fuzzy_pool.rb

@@ -5,9 +5,9 @@ module DbFinders
     #
     # = FuzzyPool finder strategy
     #
-    #   - version:  7-0.4.01
+    #   - version:  7-0.8.00
     #   - author:   Steve A.
-    #   - build:    20220823
+    #   - build:    20241223
     #
     class FuzzyPool < BaseStrategy
       # Creates a new search strategy instance given the parameters.
@@ -20,8 +20,10 @@ class FuzzyPool < BaseStrategy
       #   the verbose search output on the console (default: false); this will be removed from
       #   the search terms.
       #
-      def initialize(search_terms = {})
-        super(GogglesDb::SwimmingPool, search_terms, :for_name, DEFAULT_MATCH_BIAS)
+      # - <tt>bias</tt>: fuzzy search bias for a match (default: BaseStrategy::DEFAULT_MATCH_BIAS)
+      #
+      def initialize(search_terms = {}, bias = BaseStrategy::DEFAULT_MATCH_BIAS)
+        super(GogglesDb::SwimmingPool, search_terms, :for_name, bias)
       end
       #-- --------------------------------------------------------------------------
       #++

app/strategies/goggles_db/db_finders/fuzzy_swimmer.rb

@@ -5,9 +5,9 @@ module DbFinders
     #
     # = FuzzySwimmer finder strategy
     #
-    #   - version:  7-0.3.53
+    #   - version:  7-0.8.00
     #   - author:   Steve A.
-    #   - build:    20220526
+    #   - build:    20241223
     #
     class FuzzySwimmer < BaseStrategy
       # Creates a new search strategy instance given the parameters.
@@ -20,9 +20,11 @@ class FuzzySwimmer < BaseStrategy
       #   the verbose search output on the console (default: false); this will be removed from
       #   the search terms.
       #
-      def initialize(search_terms = {})
+      # - <tt>bias</tt>: fuzzy search bias for a match (default: BaseStrategy::DEFAULT_MATCH_BIAS)
+      #
+      def initialize(search_terms = {}, bias = BaseStrategy::DEFAULT_MATCH_BIAS)
         # Use a less restrictive bias (0.8 allows for just a surname)
-        super(GogglesDb::Swimmer, search_terms, :for_name, 0.8)
+        super(GogglesDb::Swimmer, search_terms, :for_name, bias)
       end
       #-- --------------------------------------------------------------------------
       #++

app/strategies/goggles_db/db_finders/fuzzy_team.rb

@@ -5,9 +5,9 @@ module DbFinders
     #
     # = FuzzyTeam finder strategy
     #
-    #   - version:  7-0.4.01
+    #   - version:  7-0.8.00
     #   - author:   Steve A.
-    #   - build:    20220823
+    #   - build:    20241223
     #
     class FuzzyTeam < BaseStrategy
       # Creates a new search strategy instance given the parameters.
@@ -20,7 +20,9 @@ class FuzzyTeam < BaseStrategy
       #   the verbose search output on the console (default: false); this will be removed from
       #   the search terms.
       #
-      def initialize(search_terms = {})
+      # - <tt>bias</tt>: fuzzy search bias for a match (default: 0.74)
+      #
+      def initialize(search_terms = {}, _bias = 0.74)
         # Use a less restrictive bias (0.75 allows for just a partial name)
         super(GogglesDb::Team, search_terms, :for_name, 0.74)
       end