services/horizon/internal/ingest: Fix total lookup table rows deleted metric (#5528)

tamirms · web-flow · commit dd8a9b473a30 · 2024-11-13T16:34:07.000+01:00
diff --git a/services/horizon/CHANGELOG.md b/services/horizon/CHANGELOG.md
@@ -7,6 +7,7 @@ file. This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 - Fix the issue where the skip-txmeta flag is not being applied in `/transactions/{tx-id}` endpoint ([5523](https://github.com/stellar/go/pull/5523)).
+- Fix `horizon_ingest_reap_lookup_tables_duration_seconds` metric which reports the total number of lookup table rows which were reaped ([5528](https://github.com/stellar/go/pull/5528)).
 
 ## 22.0.0-rc2
 
diff --git a/services/horizon/internal/ingest/reap.go b/services/horizon/internal/ingest/reap.go
@@ -331,6 +331,7 @@ func (r *lookupTableReaper) deleteOrphanedRows(ctx context.Context) error {
 		}
 		deleteDuration := time.Since(deleteStartTime)
 		totalDeleteDuration += deleteDuration
+		totalDeleted += rowsDeleted
 
 		r.rowsReapedByLookupTable.With(prometheus.Labels{"table": table}).
 			Observe(float64(rowsDeleted))

Original file line number	Diff line number	Diff line change
`@@ -331,6 +331,7 @@ func (r *lookupTableReaper) deleteOrphanedRows(ctx context.Context) error {`
`331`	`331`	`}`
`332`	`332`	`deleteDuration := time.Since(deleteStartTime)`
`333`	`333`	`totalDeleteDuration += deleteDuration`
	`334`	`+ totalDeleted += rowsDeleted`
`334`	`335`
`335`	`336`	`r.rowsReapedByLookupTable.With(prometheus.Labels{"table": table}).`
`336`	`337`	`Observe(float64(rowsDeleted))`