all: Update Go version to 1.23 (#5561)

Author: tamirms

.github/workflows/go.yml

@@ -18,7 +18,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-22.04]
-        go: ["1.22.1"]
+        go: ["1.23"]
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v3
@@ -38,7 +38,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-22.04]
-        go: ["1.21", "1.22"]
+        go: ["1.22", "1.23"]
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v3
@@ -56,7 +56,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-22.04]
-        go: ["1.21", "1.22"]
+        go: ["1.22", "1.23"]
         pg: [12, 16]
     runs-on: ${{ matrix.os }}
     services:

.github/workflows/horizon-release.yml

@@ -22,7 +22,7 @@ jobs:
 
       - uses: ./.github/actions/setup-go
         with:
-          go-version: "1.22"
+          go-version: "1.23"
 
       - name: Check dependencies
         run: ./gomod.sh

.github/workflows/horizon.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04, ubuntu-22.04]
-        go: ["1.21", "1.22"]
+        go: ["1.22", "1.23"]
         pg: [12, 16]
         protocol-version: [21, 22]
     runs-on: ${{ matrix.os }}
@@ -126,6 +126,7 @@ jobs:
     name: Test (and push) verify-range image
     runs-on: ubuntu-22.04
     env:
+      GO_VERSION: 1.23.4
       STELLAR_CORE_VERSION: 21.3.1-2007.4ede19620.focal
       CAPTIVE_CORE_STORAGE_PATH: /tmp
     steps:
@@ -136,7 +137,7 @@ jobs:
 
       - name: Build and test the Verify Range Docker image
         run: |
-          docker build --build-arg="GO_VERSION=$(sed -En 's/^toolchain[[:space:]]+go([[:digit:].]+)$/\1/p' go.mod)" -f services/horizon/docker/verify-range/Dockerfile -t stellar/horizon-verify-range services/horizon/docker/verify-range/
+          docker build --build-arg="GO_VERSION=$GO_VERSION" -f services/horizon/docker/verify-range/Dockerfile -t stellar/horizon-verify-range services/horizon/docker/verify-range/
           # Any range should do for basic testing, this range was chosen pretty early in history so that it only takes a few mins to run
           docker run -e BRANCH=$(git rev-parse HEAD) -e FROM=10000063 -e TO=10000127 stellar/horizon-verify-range
 

exp/services/recoverysigner/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bullseye as build
+FROM golang:1.23-bullseye as build
 
 ADD . /src/recoverysigner
 WORKDIR /src/recoverysigner

exp/services/webauth/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bullseye as build
+FROM golang:1.23-bullseye as build
 
 ADD . /src/webauth
 WORKDIR /src/webauth

go.mod

@@ -1,8 +1,6 @@
 module github.com/stellar/go
 
-go 1.22
-
-toolchain go1.22.1
+go 1.23
 
 require (
 	cloud.google.com/go/firestore v1.15.0 // indirect

ingest/ledgerbackend/toml.go

@@ -303,7 +303,7 @@ func (c *CaptiveCoreToml) unmarshal(data []byte, strict bool) error {
 		return err
 	} else if err = toml.NewDecoder(bytes.NewReader(withoutPlaceHolders)).Strict(strict).Decode(&body); err != nil {
 		if message := err.Error(); strings.HasPrefix(message, "undecoded keys") {
-			return fmt.Errorf(strings.Replace(
+			return errors.New(strings.Replace(
 				message,
 				"undecoded keys",
 				"these fields are not supported by captive core",

services/friendbot/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bullseye as build
+FROM golang:1.23-bullseye as build
 
 ADD . /src/friendbot
 WORKDIR /src/friendbot

services/galexie/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bookworm AS builder
+FROM golang:1.23-bookworm AS builder
 
 WORKDIR /go/src/github.com/stellar/go
 

services/horizon/Makefile

@@ -11,7 +11,7 @@ binary-build:
 		--pull always \
 		--env CGO_ENABLED=0 \
 		--env GOFLAGS="-ldflags=-X=github.com/stellar/go/support/app.version=$(VERSION_STRING)" \
-		golang:1.22-bullseye \
+		golang:1.23-bullseye \
 		/bin/bash -c '\
 			git config --global --add safe.directory /go/src/github.com/stellar/go && \
 			cd /go/src/github.com/stellar/go && \

services/horizon/docker/Dockerfile.dev

@@ -1,4 +1,4 @@
-FROM golang:1.22-bookworm AS builder
+FROM golang:1.23-bookworm AS builder
 
 ARG VERSION="devel"
 WORKDIR /go/src/github.com/stellar/go

services/horizon/docker/verify-range/dependencies

@@ -1,5 +1,7 @@
 #! /usr/bin/env bash
 set -e
+set -o xtrace
+
 
 apt-get update
 apt-get install -y curl git libpq-dev libsqlite3-dev libsasl2-dev postgresql-client postgresql postgresql-contrib sudo vim zlib1g-dev wget gnupg2 lsb-release

services/horizon/internal/scripts/check_release_hash/Dockerfile

@@ -1,5 +1,5 @@
 # Change to Go version used in CI or rebuild with --build-arg.
-ARG GO_IMAGE=golang:1.22-bullseye
+ARG GO_IMAGE=golang:1.23-bullseye
 FROM $GO_IMAGE
 
 WORKDIR /go/src/github.com/stellar/go

services/regulated-assets-approval-server/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bullseye as build
+FROM golang:1.23-bullseye as build
 
 ADD . /src/regulated-assets-approval-server
 WORKDIR /src/regulated-assets-approval-server

staticcheck.sh

@@ -1,7 +1,7 @@
 #! /bin/bash
 set -e
 
-version='2023.1.7'
+version='2024.1.1'
 
 staticcheck='go run honnef.co/go/tools/cmd/staticcheck@'"$version"