Merge pull request #5649 from urvisavla/release-horizon-v22.0.3

services/horizon: Fix operations participants logic to include SAC (#5574)

Author: urvisavla

.github/actions/setup-go/action.yml

@@ -32,15 +32,15 @@ runs:
     run: echo 'PREFIX=${{ github.workflow }}-${{ github.job }}-${{ runner.os }}-${{ inputs.go-version }}-matrix(${{ join(matrix.*,'|') }})' >> $GITHUB_ENV
 
   # Cache the Go Modules downloaded during the job.
-  - uses: actions/cache@v2
+  - uses: actions/cache@v4
     with:
       path: ~/go/pkg/mod
       key: ${{ env.PREFIX }}-go-mod-${{ hashFiles('**/go.sum') }}
       restore-keys: ${{ env.PREFIX }}-go-mod-
 
   # Cache any build and test artifacts during the job, which will speed up
   # rebuilds and cause test runs to skip tests that have no reason to rerun.
-  - uses: actions/cache@v2
+  - uses: actions/cache@v4
     with:
       path: ~/.cache/go-build
       key: ${{ env.PREFIX }}-go-build-${{ github.ref }}-${{ hashFiles('**', '!.git') }}

.github/workflows/galexie-release.yml

@@ -8,7 +8,7 @@ jobs:
 
   publish-docker:
     name: Test and push docker image
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     env:
       GALEXIE_INTEGRATION_TESTS_ENABLED: "true"
       GALEXIE_INTEGRATION_TESTS_CAPTIVE_CORE_BIN: /usr/bin/stellar-core

.github/workflows/galexie.yml

@@ -8,7 +8,7 @@ on:
 jobs:
   galexie:
     name: Test
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     env:
       CAPTIVE_CORE_DEBIAN_PKG_VERSION: 22.0.0-2138.721fd0a65.focal
       GALEXIE_INTEGRATION_TESTS_ENABLED: "true"

.github/workflows/go.yml

@@ -18,7 +18,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-22.04]
-        go: ["1.22.1"]
+        go: ["1.23"]
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v3
@@ -38,7 +38,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-22.04]
-        go: ["1.21", "1.22"]
+        go: ["1.22", "1.23"]
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v3
@@ -56,7 +56,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-22.04]
-        go: ["1.21", "1.22"]
+        go: ["1.22", "1.23"]
         pg: [12, 16]
     runs-on: ${{ matrix.os }}
     services:

.github/workflows/horizon-release.yml

@@ -22,7 +22,7 @@ jobs:
 
       - uses: ./.github/actions/setup-go
         with:
-          go-version: "1.22"
+          go-version: "1.23"
 
       - name: Check dependencies
         run: ./gomod.sh

.github/workflows/horizon.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04, ubuntu-22.04]
-        go: ["1.21", "1.22"]
+        go: ["1.22", "1.23"]
         pg: [12, 16]
         protocol-version: [21, 22]
     runs-on: ${{ matrix.os }}
@@ -126,6 +126,7 @@ jobs:
     name: Test (and push) verify-range image
     runs-on: ubuntu-22.04
     env:
+      GO_VERSION: 1.23.4
       STELLAR_CORE_VERSION: 21.3.1-2007.4ede19620.focal
       CAPTIVE_CORE_STORAGE_PATH: /tmp
     steps:
@@ -136,7 +137,7 @@ jobs:
 
       - name: Build and test the Verify Range Docker image
         run: |
-          docker build --build-arg="GO_VERSION=$(sed -En 's/^toolchain[[:space:]]+go([[:digit:].]+)$/\1/p' go.mod)" -f services/horizon/docker/verify-range/Dockerfile -t stellar/horizon-verify-range services/horizon/docker/verify-range/
+          docker build --build-arg="GO_VERSION=$GO_VERSION" -f services/horizon/docker/verify-range/Dockerfile -t stellar/horizon-verify-range services/horizon/docker/verify-range/
           # Any range should do for basic testing, this range was chosen pretty early in history so that it only takes a few mins to run
           docker run -e BRANCH=$(git rev-parse HEAD) -e FROM=10000063 -e TO=10000127 stellar/horizon-verify-range
 

exp/services/recoverysigner/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bullseye as build
+FROM golang:1.23-bullseye as build
 
 ADD . /src/recoverysigner
 WORKDIR /src/recoverysigner

exp/services/webauth/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bullseye as build
+FROM golang:1.23-bullseye as build
 
 ADD . /src/webauth
 WORKDIR /src/webauth

go.mod

@@ -1,8 +1,6 @@
 module github.com/stellar/go
 
-go 1.22
-
-toolchain go1.22.1
+go 1.23
 
 require (
 	cloud.google.com/go/firestore v1.15.0 // indirect

ingest/ledgerbackend/toml.go

@@ -303,7 +303,7 @@ func (c *CaptiveCoreToml) unmarshal(data []byte, strict bool) error {
 		return err
 	} else if err = toml.NewDecoder(bytes.NewReader(withoutPlaceHolders)).Strict(strict).Decode(&body); err != nil {
 		if message := err.Error(); strings.HasPrefix(message, "undecoded keys") {
-			return fmt.Errorf(strings.Replace(
+			return errors.New(strings.Replace(
 				message,
 				"undecoded keys",
 				"these fields are not supported by captive core",

services/friendbot/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bullseye as build
+FROM golang:1.23-bullseye as build
 
 ADD . /src/friendbot
 WORKDIR /src/friendbot

services/galexie/docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22-bookworm AS builder
+FROM golang:1.23-bookworm AS builder
 
 WORKDIR /go/src/github.com/stellar/go
 

services/horizon/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this
 file. This project adheres to [Semantic Versioning](http://semver.org/).
 
+
+## 22.0.3
+
+### Fixed
+-  Fix the account operations endpoint to include InvokeHostFunction operations. The fix ensures that all account operations will be listed going forward. However, it will not retroactively include these operations for previously ingested ledgers; reingesting the historical data is required to address that. ([5574](https://github.com/stellar/go/pull/5574)).
+
 ## 22.0.2
 
 ### Fixed

services/horizon/Makefile

@@ -11,7 +11,7 @@ binary-build:
 		--pull always \
 		--env CGO_ENABLED=0 \
 		--env GOFLAGS="-ldflags=-X=github.com/stellar/go/support/app.version=$(VERSION_STRING)" \
-		golang:1.22-bullseye \
+		golang:1.23-bullseye \
 		/bin/bash -c '\
 			git config --global --add safe.directory /go/src/github.com/stellar/go && \
 			cd /go/src/github.com/stellar/go && \

services/horizon/docker/Dockerfile.dev

@@ -1,4 +1,4 @@
-FROM golang:1.22-bookworm AS builder
+FROM golang:1.23-bookworm AS builder
 
 ARG VERSION="devel"
 WORKDIR /go/src/github.com/stellar/go

services/horizon/docker/verify-range/dependencies

@@ -1,5 +1,7 @@
 #! /usr/bin/env bash
 set -e
+set -o xtrace
+
 
 apt-get update
 apt-get install -y curl git libpq-dev libsqlite3-dev libsasl2-dev postgresql-client postgresql postgresql-contrib sudo vim zlib1g-dev wget gnupg2 lsb-release

services/horizon/internal/ingest/processor_runner.go

@@ -151,7 +151,7 @@ func (s *ProcessorRunner) buildTransactionProcessor(ledgersProcessor *processors
 		processors.NewOperationProcessor(s.historyQ.NewOperationBatchInsertBuilder(), s.config.NetworkPassphrase),
 		tradeProcessor,
 		processors.NewParticipantsProcessor(accountLoader,
-			s.historyQ.NewTransactionParticipantsBatchInsertBuilder(), s.historyQ.NewOperationParticipantBatchInsertBuilder()),
+			s.historyQ.NewTransactionParticipantsBatchInsertBuilder(), s.historyQ.NewOperationParticipantBatchInsertBuilder(), s.config.NetworkPassphrase),
 		processors.NewTransactionProcessor(s.historyQ.NewTransactionBatchInsertBuilder(), s.config.SkipTxmeta),
 		processors.NewClaimableBalancesTransactionProcessor(cbLoader,
 			s.historyQ.NewTransactionClaimableBalanceBatchInsertBuilder(), s.historyQ.NewOperationClaimableBalanceBatchInsertBuilder()),

services/horizon/internal/ingest/processors/operations_processor.go

@@ -1047,7 +1047,31 @@ func (operation *transactionOperationWrapper) Participants() ([]xdr.AccountId, e
 	case xdr.OperationTypeLiquidityPoolWithdraw:
 		// the only direct participant is the source_account
 	case xdr.OperationTypeInvokeHostFunction:
-		// the only direct participant is the source_account
+		if changes, err := operation.transaction.GetOperationChanges(operation.index); err != nil {
+			return participants, err
+		} else {
+			for _, change := range changes {
+				var data xdr.LedgerEntryData
+				switch {
+				case change.Post != nil:
+					data = change.Post.Data
+				case change.Pre != nil:
+					data = change.Pre.Data
+				default:
+					log.Errorf("Change Type %s with no pre or post", change.Type.String())
+					continue
+				}
+				if ledgerKey, err := data.LedgerKey(); err == nil {
+					participants = append(participants, getLedgerKeyParticipants(ledgerKey)...)
+				}
+			}
+		}
+		if diagnosticEvents, err := operation.transaction.GetDiagnosticEvents(); err != nil {
+			return participants, err
+		} else {
+			participants = append(participants, getParticipantsFromSACEvents(filterEvents(diagnosticEvents), operation.network)...)
+		}
+
 	case xdr.OperationTypeExtendFootprintTtl:
 		// the only direct participant is the source_account
 	case xdr.OperationTypeRestoreFootprint:
@@ -1067,6 +1091,48 @@ func (operation *transactionOperationWrapper) Participants() ([]xdr.AccountId, e
 	return dedupeParticipants(participants), nil
 }
 
+func getParticipantsFromSACEvents(contractEvents []xdr.ContractEvent, network string) []xdr.AccountId {
+	var participants []xdr.AccountId
+
+	for _, contractEvent := range contractEvents {
+		if sacEvent, err := contractevents.NewStellarAssetContractEvent(&contractEvent, network); err == nil {
+			// 'to' and 'from' fields in the events can be either a Contract address or an Account address. We're
+			// only interested in account addresses and will skip Contract addresses.
+			switch sacEvent.GetType() {
+			case contractevents.EventTypeTransfer:
+				var transferEvt *contractevents.TransferEvent
+				transferEvt = sacEvent.(*contractevents.TransferEvent)
+				var from, to xdr.AccountId
+				if from, err = xdr.AddressToAccountId(transferEvt.From); err == nil {
+					participants = append(participants, from)
+				}
+				if to, err = xdr.AddressToAccountId(transferEvt.To); err == nil {
+					participants = append(participants, to)
+				}
+			case contractevents.EventTypeMint:
+				mintEvt := sacEvent.(*contractevents.MintEvent)
+				var to xdr.AccountId
+				if to, err = xdr.AddressToAccountId(mintEvt.To); err == nil {
+					participants = append(participants, to)
+				}
+			case contractevents.EventTypeClawback:
+				clawbackEvt := sacEvent.(*contractevents.ClawbackEvent)
+				var from xdr.AccountId
+				if from, err = xdr.AddressToAccountId(clawbackEvt.From); err == nil {
+					participants = append(participants, from)
+				}
+			case contractevents.EventTypeBurn:
+				burnEvt := sacEvent.(*contractevents.BurnEvent)
+				var from xdr.AccountId
+				if from, err = xdr.AddressToAccountId(burnEvt.From); err == nil {
+					participants = append(participants, from)
+				}
+			}
+		}
+	}
+	return participants
+}
+
 // dedupeParticipants remove any duplicate ids from `in`
 func dedupeParticipants(in []xdr.AccountId) []xdr.AccountId {
 	if len(in) <= 1 {
@@ -1090,7 +1156,7 @@ func dedupeParticipants(in []xdr.AccountId) []xdr.AccountId {
 }
 
 // OperationsParticipants returns a map with all participants per operation
-func operationsParticipants(transaction ingest.LedgerTransaction, sequence uint32) (map[int64][]xdr.AccountId, error) {
+func operationsParticipants(transaction ingest.LedgerTransaction, sequence uint32, network string) (map[int64][]xdr.AccountId, error) {
 	participants := map[int64][]xdr.AccountId{}
 
 	for opi, op := range transaction.Envelope.Operations() {
@@ -1099,6 +1165,7 @@ func operationsParticipants(transaction ingest.LedgerTransaction, sequence uint3
 			transaction:    transaction,
 			operation:      op,
 			ledgerSequence: sequence,
+			network:        network,
 		}
 
 		p, err := operation.Participants()

services/horizon/internal/ingest/processors/participants_processor.go

@@ -19,17 +19,21 @@ type ParticipantsProcessor struct {
 	accountLoader *history.AccountLoader
 	txBatch       history.TransactionParticipantsBatchInsertBuilder
 	opBatch       history.OperationParticipantBatchInsertBuilder
+	network       string
 }
 
 func NewParticipantsProcessor(
 	accountLoader *history.AccountLoader,
 	txBatch history.TransactionParticipantsBatchInsertBuilder,
 	opBatch history.OperationParticipantBatchInsertBuilder,
+	network string,
+
 ) *ParticipantsProcessor {
 	return &ParticipantsProcessor{
 		accountLoader: accountLoader,
 		txBatch:       txBatch,
 		opBatch:       opBatch,
+		network:       network,
 	}
 }
 
@@ -129,7 +133,7 @@ func (p *ParticipantsProcessor) addOperationsParticipants(
 	sequence uint32,
 	transaction ingest.LedgerTransaction,
 ) error {
-	participants, err := operationsParticipants(transaction, sequence)
+	participants, err := operationsParticipants(transaction, sequence, p.network)
 	if err != nil {
 		return errors.Wrap(err, "could not determine operation participants")
 	}

services/horizon/internal/ingest/processors/participants_processor_test.go

@@ -96,6 +96,7 @@ func (s *ParticipantsProcessorTestSuiteLedger) SetupTest() {
 		s.accountLoader,
 		s.mockBatchInsertBuilder,
 		s.mockOperationsBatchInsertBuilder,
+		networkPassphrase,
 	)
 
 	s.txs = []ingest.LedgerTransaction{