Skip to content

Commit 87cbe90

Browse files
committed
Cancel exercise timer if empty input is received.
1 parent 9830386 commit 87cbe90

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

slides/templates/regular/index.html.j2

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,11 @@ require(
231231
Reveal.addKeyBinding(
232232
{ keyCode: 84, key: "T", description: "Start the exercise timer" },
233233
() => {
234-
let exerciseTime = prompt("Timer duration in minutes");
234+
let exerciseTime = prompt("Timer duration in minutes (leave empty to cancel)");
235+
const cleanup = () => {
236+
clearInterval(updateExerciseTimerInterval);
237+
$('.exercise-timer').remove();
238+
}
235239
if (exerciseTime !== undefined && exerciseTime !== "" && exerciseTime !== null){
236240
if (!isNaN(exerciseTime) && exerciseTime >= 0.1) {
237241
exerciseTime = Duration.fromMillis(exerciseTime * 60 * 1000);
@@ -267,14 +271,12 @@ require(
267271
audio.play();
268272
}
269273
else if (secondsRemaining >= -5) $('.exercise-timer').text("TIME'S UP").css('color', 'red');
270-
else {
271-
clearInterval(updateExerciseTimerInterval);
272-
$('.exercise-timer').remove();
273-
}
274+
else cleanup();
274275
}
275276
updateExerciseTimerInterval = setInterval(updateTimer, updateFrequency);
276277
}
277278
}
279+
else cleanup();
278280
}
279281
);
280282

0 commit comments

Comments
 (0)