Auto-generated commit

Author: stdlib-bot

.github/.keepalive

@@ -4,7 +4,7 @@
 
 <section class="release" id="unreleased">
 
-## Unreleased (2025-05-19)
+## Unreleased (2025-05-27)
 
 <section class="features">
 
@@ -16,12 +16,23 @@
 
 <!-- /.features -->
 
+<section class="bug-fixes">
+
+### Bug Fixes
+
+-   [`aa52ed9`](https://github.com/stdlib-js/stdlib/commit/aa52ed96730b4835b3ef403b2abbcd7910e3e483) - update implementation to preserve signed zeros
+
+</section>
+
+<!-- /.bug-fixes -->
+
 <section class="commits">
 
 ### Commits
 
 <details>
 
+-   [`aa52ed9`](https://github.com/stdlib-js/stdlib/commit/aa52ed96730b4835b3ef403b2abbcd7910e3e483) - **fix:** update implementation to preserve signed zeros _(by Athan Reines)_
 -   [`9f85b5d`](https://github.com/stdlib-js/stdlib/commit/9f85b5d90cb6fcaf052116cd06aa4a693757f0ec) - **test:** fix description _(by Philipp Burckhardt)_
 -   [`9367d41`](https://github.com/stdlib-js/stdlib/commit/9367d4175b33e490bdbea8da5062fe95919f5d85) - **refactor:** update paths _(by Aayush Khanna)_
 -   [`99388d1`](https://github.com/stdlib-js/stdlib/commit/99388d1aeabe238c519707b8e08843a4bdeb04d4) - **test:** fix grammar in descriptions _(by Athan Reines)_

CHANGELOG.md

@@ -146,6 +146,7 @@ Ryan Seal <splrk@users.noreply.github.com>
 Rylan Yang <137365285+rylany27@users.noreply.github.com>
 SAHIL KUMAR <168997976+sahilk45@users.noreply.github.com>
 SHIVAM YADAV <120725381+Shivam-1827@users.noreply.github.com>
+Sachin Raj <120590207+schnrj@users.noreply.github.com>
 Sahil Goyal <87982509+sahil20021008@users.noreply.github.com>
 Sai Avinash <120403424+nasarobot@users.noreply.github.com>
 Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
@@ -166,10 +167,12 @@ Spandan Barve <contact@marsian.dev>
 Stephannie Jiménez Gacha <steff456@hotmail.com>
 Suhaib Ilahi <suhaib.elahi87@gmail.com>
 Suraj Kumar <125961509+kumarsuraj212003@users.noreply.github.com>
+Swapnil Hajare <69076366+Swapnil-2502@users.noreply.github.com>
 Tanishq Ahuja <68651083+TheGEN1U5@users.noreply.github.com>
 Tirtadwipa Manunggal <tirtadwipa.manunggal@gmail.com>
 Tudor Pagu <104032457+tudor-pagu@users.noreply.github.com>
 Tufailahmed Bargir <142114244+Tufailahmed-Bargir@users.noreply.github.com>
+Uday Kakade <141299403+udaykakade25@users.noreply.github.com>
 Utkarsh <http://utkarsh11105@gmail.com>
 Utkarsh Raj <rajutkarsh2505@gmail.com>
 UtkershBasnet <119008923+UtkershBasnet@users.noreply.github.com>

CONTRIBUTORS

@@ -45,20 +45,34 @@ var isnan = require( '@stdlib/math-base-assert-is-nan' );
 function dsnansumors( N, x, strideX, offsetX ) {
 	var sum;
 	var ix;
+	var v;
 	var i;
 
-	sum = 0.0;
 	if ( N <= 0 ) {
-		return sum;
+		return 0.0;
 	}
 	ix = offsetX;
 	if ( strideX === 0 ) {
 		if ( isnan( x[ ix ] ) ) {
-			return sum;
+			return 0.0;
 		}
 		return N * x[ ix ];
 	}
+	// Find the first non-NaN element...
 	for ( i = 0; i < N; i++ ) {
+		v = x[ ix ];
+		if ( isnan( v ) === false ) {
+			break;
+		}
+		ix += strideX;
+	}
+	if ( i === N ) {
+		return 0.0;
+	}
+	sum = v;
+	ix += strideX;
+	i += 1;
+	for ( ; i < N; i++ ) {
 		if ( isnan( x[ ix ] ) === false ) {
 			sum += x[ ix ];
 		}

dist/index.js

@@ -59,6 +59,7 @@
     "@stdlib/array-filled-by": "^0.2.1",
     "@stdlib/array-float32": "^0.2.2",
     "@stdlib/assert-is-browser": "^0.2.2",
+    "@stdlib/math-base-assert-is-negative-zero": "^0.2.2",
     "@stdlib/math-base-special-pow": "^0.3.0",
     "@stdlib/random-base-bernoulli": "^0.2.1",
     "@stdlib/random-base-discrete-uniform": "^0.2.1",

dist/index.js.map

@@ -47,19 +47,33 @@ double API_SUFFIX(stdlib_strided_dsnansumors_ndarray)( const CBLAS_INT N, const
 	CBLAS_INT ix;
 	CBLAS_INT i;
 	double sum;
+	double v;
 
-	sum = 0.0;
 	if ( N <= 0 ) {
-		return sum;
+		return 0.0;
 	}
 	ix = offsetX;
 	if ( strideX == 0 ) {
 		if ( stdlib_base_is_nanf( X[ ix ] ) ) {
-			return sum;
+			return 0.0;
 		}
 		return N * X[ ix ];
 	}
+	// Find the first non-NaN element...
 	for ( i = 0; i < N; i++ ) {
+		v = X[ ix ];
+		if ( !stdlib_base_is_nanf( v ) ) {
+			break;
+		}
+		ix += strideX;
+	}
+	if ( i == N ) {
+		return 0.0;
+	}
+	sum = (double)v;
+	ix += strideX;
+	i += 1;
+	for ( ; i < N; i++ ) {
 		if ( !stdlib_base_is_nanf( X[ ix ] ) ) {
 			sum += (double)X[ ix ];
 		}

lib/ndarray.js

@@ -21,6 +21,7 @@
 // MODULES //
 
 var tape = require( 'tape' );
+var isNegativeZero = require( '@stdlib/math-base-assert-is-negative-zero' );
 var Float32Array = require( '@stdlib/array-float32' );
 var dsnansumors = require( './../lib/ndarray.js' );
 
@@ -77,6 +78,17 @@ tape( 'the function calculates the sum of strided array elements (ignoring NaN v
 	t.end();
 });
 
+tape( 'the function preserves the sign of zero', function test( t ) {
+	var x;
+	var v;
+
+	x = new Float32Array( [ -0.0, -0.0, -0.0, -0.0, -0.0 ] );
+	v = dsnansumors( x.length, x, 1, 0 );
+	t.strictEqual( isNegativeZero( v ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `0.0`', function test( t ) {
 	var x;
 	var v;

package.json

@@ -22,6 +22,7 @@
 
 var resolve = require( 'path' ).resolve;
 var tape = require( 'tape' );
+var isNegativeZero = require( '@stdlib/math-base-assert-is-negative-zero' );
 var Float32Array = require( '@stdlib/array-float32' );
 var tryRequire = require( '@stdlib/utils-try-require' );
 
@@ -86,6 +87,17 @@ tape( 'the function calculates the sum of strided array elements (ignoring NaN v
 	t.end();
 });
 
+tape( 'the function preserves the sign of zero', opts, function test( t ) {
+	var x;
+	var v;
+
+	x = new Float32Array( [ -0.0, -0.0, -0.0, -0.0, -0.0 ] );
+	v = dsnansumors( x.length, x, 1, 0 );
+	t.strictEqual( isNegativeZero( v ), true, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `0.0`', opts, function test( t ) {
 	var x;
 	var v;