Skip to content

Commit 9448558

Browse files
author
Jan Sebastian Rothe
committed
fixes to tests
1 parent 51d42cb commit 9448558

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

tests/paths/test_versions.py

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from unittest.mock import patch
22

33
from fagfunksjoner.paths.versions import (
4+
get_fileversions,
45
get_latest_fileversions,
56
latest_version_number,
67
latest_version_path,
@@ -46,16 +47,20 @@ def test_latest_version_number(mock_glob, mock_get_gcs_file_system):
4647

4748

4849
# Test for next_version_number function
50+
@patch("fagfunksjoner.paths.versions.get_fileversions")
4951
@patch("fagfunksjoner.paths.versions.latest_version_number")
50-
def test_next_version_number(mock_latest_version_number):
52+
def test_next_version_number(mock_get_fileversions, mock_latest_version_number):
53+
mock_get_fileversions.return_value = "gs://bucket/folder/file_v2.parquet"
5154
mock_latest_version_number.return_value = 2
5255
filepath = "gs://bucket/folder/file_v2.parquet"
5356
assert next_version_number(filepath) == 3
5457

5558

5659
# Test for next_version_path function
60+
@patch("fagfunksjoner.paths.versions.latest_version_path")
5761
@patch("fagfunksjoner.paths.versions.next_version_number")
58-
def test_next_version_path(mock_next_version_number):
62+
def test_next_version_path(mock_latest_version_path, mock_next_version_number):
63+
mock_latest_version_path.return_value = "gs://bucket/folder/file_v1.parquet"
5964
mock_next_version_number.return_value = 2
6065
filepath = "gs://bucket/folder/file_v1.parquet"
6166
expected = "gs://bucket/folder/file_v2.parquet"
@@ -76,7 +81,13 @@ def test_several_startswith():
7681
assert sorted(get_latest_fileversions(inputs)) == sorted(expected)
7782

7883

79-
def test_without_version():
84+
@patch("fagfunksjoner.paths.versions.FileClient.get_gcs_file_system")
85+
def test_without_version(mock_get_gcs_file_system):
86+
file_list = [
87+
"gs://bucket/folder/nevner_v1.parquet",
88+
"gs://bucket/folder/nevner_v2.parquet",
89+
]
90+
mock_get_gcs_file_system.return_value.glob.return_value = file_list
8091
inputs = "gs://bucket/folder/nevner"
81-
expected = "gs://bucket/folder/nevner_v3.parquet"
82-
assert latest_version_path(inputs) == expected
92+
expected = "gs://bucket/folder/nevner_v2.parquet"
93+
assert get_fileversions(inputs) == expected

0 commit comments

Comments
 (0)