itest: test imported p2tr address in coop close

Safeguard against lightninglabs/loop#923

Author: starius

itest/lnd_coop_close_external_delivery_test.go

@@ -5,7 +5,9 @@ import (
 	"testing"
 
 	"github.com/btcsuite/btcd/btcutil"
+	"github.com/btcsuite/btcd/txscript"
 	"github.com/lightningnetwork/lnd/lnrpc"
+	"github.com/lightningnetwork/lnd/lnrpc/walletrpc"
 	"github.com/lightningnetwork/lnd/lntest"
 	"github.com/lightningnetwork/lnd/lntest/node"
 	"github.com/lightningnetwork/lnd/lntest/wait"
@@ -19,7 +21,7 @@ func testCoopCloseWithExternalDelivery(ht *lntest.HarnessTest) {
 
 	ok := ht.Run("set P2WPKH delivery address at open", func(t *testing.T) {
 		testCoopCloseWithExternalDeliveryImpl(
-			ht, alice, bob, true,
+			ht, alice, bob, true, false,
 			lnrpc.AddressType_UNUSED_WITNESS_PUBKEY_HASH,
 		)
 	})
@@ -30,7 +32,7 @@ func testCoopCloseWithExternalDelivery(ht *lntest.HarnessTest) {
 
 	ok = ht.Run("set P2WPKH delivery address at close", func(t *testing.T) {
 		testCoopCloseWithExternalDeliveryImpl(
-			ht, alice, bob, false,
+			ht, alice, bob, false, false,
 			lnrpc.AddressType_UNUSED_WITNESS_PUBKEY_HASH,
 		)
 	})
@@ -41,7 +43,7 @@ func testCoopCloseWithExternalDelivery(ht *lntest.HarnessTest) {
 
 	ok = ht.Run("set P2TR delivery address at open", func(t *testing.T) {
 		testCoopCloseWithExternalDeliveryImpl(
-			ht, alice, bob, true,
+			ht, alice, bob, true, false,
 			lnrpc.AddressType_UNUSED_TAPROOT_PUBKEY,
 		)
 	})
@@ -50,9 +52,31 @@ func testCoopCloseWithExternalDelivery(ht *lntest.HarnessTest) {
 		return
 	}
 
-	ht.Run("set P2TR delivery address at close", func(t *testing.T) {
+	ok = ht.Run("set P2TR delivery address at close", func(t *testing.T) {
 		testCoopCloseWithExternalDeliveryImpl(
-			ht, alice, bob, false,
+			ht, alice, bob, false, false,
+			lnrpc.AddressType_UNUSED_TAPROOT_PUBKEY,
+		)
+	})
+	// Abort the test if failed.
+	if !ok {
+		return
+	}
+
+	ok = ht.Run("set imported P2TR address at open", func(t *testing.T) {
+		testCoopCloseWithExternalDeliveryImpl(
+			ht, alice, bob, true, true,
+			lnrpc.AddressType_UNUSED_TAPROOT_PUBKEY,
+		)
+	})
+	// Abort the test if failed.
+	if !ok {
+		return
+	}
+
+	ht.Run("set imported P2TR address at close", func(t *testing.T) {
+		testCoopCloseWithExternalDeliveryImpl(
+			ht, alice, bob, false, true,
 			lnrpc.AddressType_UNUSED_TAPROOT_PUBKEY,
 		)
 	})
@@ -62,17 +86,52 @@ func testCoopCloseWithExternalDelivery(ht *lntest.HarnessTest) {
 // balance irrespective of whether the delivery address is in LND's wallet or
 // not. Some users set this value to be an address in a different wallet and
 // this should not affect our ability to accurately report the settled balance.
+//
+// If importTapscript is set, it imports a Taproot script and internal key to
+// alice LND to make sure it doesn't interfere with channel delivery address.
+// See https://github.com/lightninglabs/loop/issues/923
 func testCoopCloseWithExternalDeliveryImpl(ht *lntest.HarnessTest,
-	alice, bob *node.HarnessNode, upfrontShutdown bool,
+	alice, bob *node.HarnessNode, upfrontShutdown, importTapscript bool,
 	deliveryAddressType lnrpc.AddressType) {
 
-	// Here we generate a final delivery address in bob's wallet but set by
-	// alice. We do this to ensure that the address is not in alice's LND
-	// wallet. We already correctly track settled balances when the address
-	// is in the LND wallet.
-	addr := bob.RPC.NewAddress(&lnrpc.NewAddressRequest{
-		Type: deliveryAddressType,
-	})
+	var addr string
+	if importTapscript {
+		// Make fake taproot internal public key (equal to the final).
+		taprootPubkey := [32]byte{1, 2, 3}
+		if upfrontShutdown {
+			// Make new address for second sub-test not to import
+			// the same address twice causing an error.
+			taprootPubkey[3] = 1
+		}
+		pkScriptBytes := append(
+			[]byte{txscript.OP_1, txscript.OP_DATA_32},
+			taprootPubkey[:]...,
+		)
+		pkScript, err := txscript.ParsePkScript(pkScriptBytes)
+		require.NoError(ht, err)
+		address, err := pkScript.Address(harnessNetParams)
+		require.NoError(ht, err)
+		addr = address.String()
+
+		// Import the taproot address to LND.
+		req := &walletrpc.ImportTapscriptRequest{
+			InternalPublicKey: taprootPubkey[:],
+			Script: &walletrpc.ImportTapscriptRequest_FullKeyOnly{
+				FullKeyOnly: true,
+			},
+		}
+		res := alice.RPC.ImportTapscript(req)
+		require.Equal(ht, addr, res.P2TrAddress)
+	} else {
+		// Here we generate a final delivery address in bob's wallet but
+		// set by alice. We do this to ensure that the address is not in
+		// alice's LND wallet. We already correctly track settled
+		// balances when the address is in the LND wallet.
+		res := bob.RPC.NewAddress(&lnrpc.NewAddressRequest{
+			Type: deliveryAddressType,
+		})
+		addr = res.Address
+	}
 
 	// Prepare for channel open.
 	openParams := lntest.OpenChannelParams{
@@ -82,7 +141,7 @@ func testCoopCloseWithExternalDeliveryImpl(ht *lntest.HarnessTest,
 	// If we are testing the case where we set it on open then we'll set the
 	// upfront shutdown script in the channel open parameters.
 	if upfrontShutdown {
-		openParams.CloseAddress = addr.Address
+		openParams.CloseAddress = addr
 	}
 
 	// Open the channel!
@@ -97,7 +156,7 @@ func testCoopCloseWithExternalDeliveryImpl(ht *lntest.HarnessTest,
 	// If we are testing the case where we set the delivery address on
 	// channel close then we will set it in the channel close parameters.
 	if !upfrontShutdown {
-		closeParams.DeliveryAddress = addr.Address
+		closeParams.DeliveryAddress = addr
 	}
 
 	// Close the channel!