Skip to content

Commit 2ed0e9b

Browse files
committed
Remove a hack needed when loading neural coref models using ejml 0.38
1 parent a1061dc commit 2ed0e9b

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

src/edu/stanford/nlp/coref/neural/NeuralCorefModel.java

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,20 @@
88
import edu.stanford.nlp.neural.NeuralUtils;
99
import org.ejml.simple.SimpleMatrix;
1010

11-
// TODO: remove when ejml is upgraded
12-
import java.io.IOException;
13-
import java.io.ObjectInputStream;
14-
import java.util.stream.Collectors;
15-
1611
/**
1712
* Stores the weights and implements the matrix operations used by a {@link NeuralCorefAlgorithm}
1813
* @author Kevin Clark
1914
*/
2015
public class NeuralCorefModel implements Serializable {
2116
private static final long serialVersionUID = 2139427931784505653L;
22-
// TODO: restore /*final*/ when ejml is upgraded
23-
private /*final*/ SimpleMatrix antecedentMatrix;
24-
private /*final*/ SimpleMatrix anaphorMatrix;
25-
private /*final*/ SimpleMatrix pairFeaturesMatrix;
26-
private /*final*/ SimpleMatrix pairwiseFirstLayerBias;
27-
private /*final*/ List<SimpleMatrix> anaphoricityModel;
28-
private /*final*/ List<SimpleMatrix> pairwiseModel;
29-
private /*final*/ Embedding wordEmbeddings;
17+
18+
private SimpleMatrix antecedentMatrix;
19+
private SimpleMatrix anaphorMatrix;
20+
private SimpleMatrix pairFeaturesMatrix;
21+
private SimpleMatrix pairwiseFirstLayerBias;
22+
private List<SimpleMatrix> anaphoricityModel;
23+
private List<SimpleMatrix> pairwiseModel;
24+
private Embedding wordEmbeddings;
3025

3126
public NeuralCorefModel(SimpleMatrix antecedentMatrix, SimpleMatrix anaphorMatrix,
3227
SimpleMatrix pairFeaturesMatrix, SimpleMatrix pairwiseFirstLayerBias,

0 commit comments

Comments
 (0)