Check that a couple annotation types we won't be able to translate cause exceptions

Author: AngledLuffa

src/edu/stanford/nlp/semgraph/semgrex/ssurgeon/AddDep.java

@@ -46,7 +46,11 @@ public AddDep(String govNodeName, GrammaticalRelation relation, Map<String, Stri
 
   public AddDep(String govNodeName, GrammaticalRelation relation, Map<String, String> attributes, double weight) {
     // if there's an exception, we'll barf here rather than at runtime
-    CoreLabel newNodeObj = fromCheapStrings(attributes);
+    try {
+      CoreLabel newNodeObj = fromCheapStrings(attributes);
+    } catch (UnsupportedOperationException e) {
+      throw new SsurgeonParseException("Unable to process keys for AddDep operation", e);
+    }
 
     this.attributes = new TreeMap<>(attributes);
     this.relation = relation;
@@ -65,8 +69,7 @@ public String toEditString() {
     buf.write(govNodeName); buf.write("\t");
     buf.write(Ssurgeon.RELN_ARG);buf.write(" ");
     buf.write(relation.toString()); buf.write("\t");
-    buf.write(Ssurgeon.NODE_PROTO_ARG);buf.write(" ");
-    buf.write("\"");
+
     for (String key : attributes.keySet()) {
       buf.write("-");
       buf.write(key);
@@ -123,7 +126,7 @@ public static CoreLabel fromCheapStrings(Map<String, String> attributes) {
       values[idx] = value;
       ++idx;
     }
-    CoreLabel newWord = new CoreLabel(keys, values);
+    final CoreLabel newWord = new CoreLabel(keys, values);
     if (newWord.value() == null && newWord.word() != null) {
       newWord.setValue(newWord.word());
     }

test/src/edu/stanford/nlp/semgraph/semgrex/ssurgeon/SsurgeonTest.java

@@ -671,6 +671,53 @@ public void readXMLAddDepBrokenAnnotation() {
     }
   }
 
+  @Test
+  public void checkAnnotationConversionErrors() {
+    Ssurgeon inst = Ssurgeon.inst();
+
+    // this should exist, but a string will not produce it
+    assertNotNull(AnnotationLookup.toCoreKey("SPAN"));
+
+    // This will fail because IntPair cannot be converted from a String
+    String add = String.join(newline,
+                             "<ssurgeon-pattern-list>",
+                             "  <ssurgeon-pattern>",
+                             "    <uid>38</uid>",
+                             "    <notes>Remove all incoming edges for a node</notes>",
+                             // have to bomb-proof the pattern
+                             "    <semgrex>" + XMLUtils.escapeXML("{word:antennae}=antennae !> {word:blue}") + "</semgrex>",
+                             "    <edit-list>addDep -gov antennae -reln dep -SPAN blue</edit-list>",
+                             "  </ssurgeon-pattern>",
+                             "</ssurgeon-pattern-list>");
+
+    try {
+      List<SsurgeonPattern> patterns = inst.readFromString(add);
+      throw new AssertionError("Expected a failure because IntPair is not readable from a String in CoreLabel");
+    } catch (SsurgeonParseException e) {
+      // yay
+    }
+    
+    assertNotNull(AnnotationLookup.toCoreKey("headidx"));
+    // This will also fail, this time because Integer cannot be converted from a String
+    add = String.join(newline,
+                      "<ssurgeon-pattern-list>",
+                      "  <ssurgeon-pattern>",
+                      "    <uid>38</uid>",
+                      "    <notes>Remove all incoming edges for a node</notes>",
+                      // have to bomb-proof the pattern
+                      "    <semgrex>" + XMLUtils.escapeXML("{word:antennae}=antennae !> {word:blue}") + "</semgrex>",
+                      "    <edit-list>addDep -gov antennae -reln dep -headidx blue</edit-list>",
+                      "  </ssurgeon-pattern>",
+                      "</ssurgeon-pattern-list>");
+
+    try {
+      List<SsurgeonPattern> patterns = inst.readFromString(add);
+      throw new AssertionError("Expected a failure because IntPair is not readable from a String in CoreLabel");
+    } catch (SsurgeonParseException e) {
+      // yay
+    }
+  }
+
   /**
    * Simple test of an Ssurgeon edit script.  This instances a simple semantic graph,
    * a semgrex pattern, and then the resulting actions over the named nodes in the