Testing ggplot labels

[teunbrand]

Hi there,

We've been preparing a new major release for ggplot2 and found an issue during a reverse dependency check.
The issue is described in tidyverse/ggplot2#6505, where you're welcome to raise discussion.
Essentially the issue is follow-up on #337, where the following test no longer holds:

bayesplot/tests/testthat/test-mcmc-traces.R

Lines 54 to 59 in 8b07034

	if ("get_labs" %in% getNamespaceExports("ggplot2")) {
	ll <- ggplot2::get_labs(g2)
	} else {
	ll <- g2$labels
	}
	expect_true(all(c("xmin", "xmax", "ymin", "ymax") %in% names(ll)))

This is because ggplot2 now tosses out unused labels, so none of these names are present anymore. I apologise for now getting this right the first time! I think the best course of action is just remove this part of the test, but if it actually tests behaviour in your code, perhaps it could be changed.

You can test your code with the development version of ggplot2 by installing it as follows:

# install.packages("pak")
pak::pak("tidyverse/ggplot2")

We aim to release the new ggplot2 version in about 2 weeks, and hope you can submit a fix to CRAN around that time. Hopefully this will inform you in a timely manner.

Best wishes,
Teun

[jgabry]

Thanks for the heads up. I think it's fine for us to remove that part of the test.

[teunbrand]

Thank you for the swift reponse!