Skip to content

Commit bad50cd

Browse files
authored
Merge pull request #6 from stainless-api/sam/remove-node-engine-cap
Remove max supported node engine from package.json
2 parents 2ca6ea7 + 959c46e commit bad50cd

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

.node-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v16.20.2

CONTRIBUTING.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
**Table of contents**
44

5-
* [Contributor License Agreements](#contributor-license-agreements)
6-
* [Contributing a patch](#contributing-a-patch)
7-
* [Running the tests](#running-the-tests)
8-
* [Releasing the library](#releasing-the-library)
5+
- [Contributor License Agreements](#contributor-license-agreements)
6+
- [Contributing a patch](#contributing-a-patch)
7+
- [Running the tests](#running-the-tests)
8+
- [Releasing the library](#releasing-the-library)
99

1010
## Contributor License Agreements
1111

@@ -15,10 +15,10 @@ have to jump a couple of legal hurdles.
1515
Please fill out either the individual or corporate Contributor License Agreement
1616
(CLA).
1717

18-
* If you are an individual writing original source code and you're sure you
19-
own the intellectual property, then you'll need to sign an [individual CLA](https://developers.google.com/open-source/cla/individual).
20-
* If you work for a company that wants to allow you to contribute your work,
21-
then you'll need to sign a [corporate CLA](https://developers.google.com/open-source/cla/corporate).
18+
- If you are an individual writing original source code and you're sure you
19+
own the intellectual property, then you'll need to sign an [individual CLA](https://developers.google.com/open-source/cla/individual).
20+
- If you work for a company that wants to allow you to contribute your work,
21+
then you'll need to sign a [corporate CLA](https://developers.google.com/open-source/cla/corporate).
2222

2323
Follow either of the two links above to access the appropriate CLA and
2424
instructions for how to sign and return it. Once we receive it, we'll be able to
@@ -39,6 +39,8 @@ accept your pull requests.
3939

4040
### Before you begin
4141

42+
> ⚠️ Due to the server mocking library `nock` [not supporting native fetch](https://github.com/nock/nock/issues/2397) tests for `release-please` require a version of node lesser than v18. Tests have been confirmed to pass successfully when using node v16.
43+
4244
1. [Install Node.js LTS][node].
4345

4446
## Running the tests
@@ -66,7 +68,7 @@ accept your pull requests.
6668
--token=$GITHUB_TOKEN \
6769
--repo-url=<owner>/<repo> [extra options]
6870
```
69-
71+
7072
It is equivalent to running the CLI command:
7173

7274
```

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,6 @@
105105
"yargs": "^17.0.0"
106106
},
107107
"engines": {
108-
"node": ">=14.0.0 <18"
108+
"node": ">=14.0.0"
109109
}
110110
}

0 commit comments

Comments
 (0)