Add CI pipeline for test and lint (#64)

Author: hazim-j

.github/workflows/pipeline.yml

@@ -0,0 +1,43 @@
+name: CI Pipeline
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Set up Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: 1.19
+          cache: true
+
+      - name: Install dependencies
+        run: go get .
+
+      - name: Build
+        run: go build -v ./...
+
+      - name: Test
+        run: go test -v ./...
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Set up Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: 1.19
+          cache: true
+
+      - name: Lint
+        uses: golangci/golangci-lint-action@v3

cmd/start.go

@@ -28,6 +28,10 @@ var mode string
 func init() {
 	rootCmd.AddCommand(startCmd)
 	startCmd.Flags().StringVarP(&mode, "mode", "m", "", "Required. See acceptable values above.")
-	startCmd.MarkFlagRequired("mode")
-	viper.BindPFlag("mode", startCmd.Flags().Lookup("mode"))
+	if err := startCmd.MarkFlagRequired("mode"); err != nil {
+		panic(err)
+	}
+	if err := viper.BindPFlag("mode", startCmd.Flags().Lookup("mode")); err != nil {
+		panic(err)
+	}
 }

internal/config/values.go

@@ -61,14 +61,30 @@ func GetValues() *Values {
 	}
 
 	// Read in from environment variables
-	viper.BindEnv("erc4337_bundler_eth_client_url")
-	viper.BindEnv("erc4337_bundler_private_key")
-	viper.BindEnv("erc4337_bundler_port")
-	viper.BindEnv("erc4337_bundler_data_directory")
-	viper.BindEnv("erc4337_bundler_supported_entry_points")
-	viper.BindEnv("erc4337_bundler_beneficiary")
-	viper.BindEnv("erc4337_bundler_max_verification_gas")
-	viper.BindEnv("erc4337_bundler_gin_mode")
+	if err := viper.BindEnv("erc4337_bundler_eth_client_url"); err != nil {
+		panic(err)
+	}
+	if err := viper.BindEnv("erc4337_bundler_private_key"); err != nil {
+		panic(err)
+	}
+	if err := viper.BindEnv("erc4337_bundler_port"); err != nil {
+		panic(err)
+	}
+	if err := viper.BindEnv("erc4337_bundler_data_directory"); err != nil {
+		panic(err)
+	}
+	if err := viper.BindEnv("erc4337_bundler_supported_entry_points"); err != nil {
+		panic(err)
+	}
+	if err := viper.BindEnv("erc4337_bundler_beneficiary"); err != nil {
+		panic(err)
+	}
+	if err := viper.BindEnv("erc4337_bundler_max_verification_gas"); err != nil {
+		panic(err)
+	}
+	if err := viper.BindEnv("erc4337_bundler_gin_mode"); err != nil {
+		panic(err)
+	}
 
 	// Validate required variables
 	if !viper.IsSet("erc4337_bundler_eth_client_url") || viper.GetString("erc4337_bundler_eth_client_url") == "" {

internal/start/private.go

@@ -99,17 +99,21 @@ func PrivateMode() {
 		relayer.SendUserOperation(),
 		paymaster.IncOpsIncluded(),
 	)
-	b.Run()
+	if err := b.Run(); err != nil {
+		log.Fatal(err)
+	}
 
 	// Init HTTP server
 	gin.SetMode(conf.GinMode)
 	r := gin.New()
+	if err := r.SetTrustedProxies(nil); err != nil {
+		log.Fatal(err)
+	}
 	r.Use(
 		cors.Default(),
 		logger.WithLogr(logr),
 		gin.Recovery(),
 	)
-	r.SetTrustedProxies(nil)
 	r.GET("/ping", func(g *gin.Context) {
 		g.Status(http.StatusOK)
 	})
@@ -119,5 +123,7 @@ func PrivateMode() {
 		jsonrpc.Controller(client.NewRpcAdapter(c)),
 		relayer.MapUserOpHashToClientID(),
 	)
-	r.Run(fmt.Sprintf(":%d", conf.Port))
+	if err := r.Run(fmt.Sprintf(":%d", conf.Port)); err != nil {
+		log.Fatal(err)
+	}
 }

internal/testutils/ethmock.go

@@ -0,0 +1,51 @@
+package testutils
+
+import (
+	"encoding/json"
+	"fmt"
+	"net/http"
+	"net/http/httptest"
+)
+
+type mockReq struct {
+	JsonRpc string  `json:"jsonrpc"`
+	ID      float64 `json:"id"`
+	Method  string  `json:"method"`
+}
+
+type mockRes struct {
+	JsonRpc string  `json:"jsonrpc"`
+	ID      float64 `json:"id"`
+	Result  any     `json:"result"`
+}
+
+type MethodMocks map[string]any
+
+// EthMock returns a httptest.Server for mocking the return value of a JSON-RPC method call to an Ethereum node.
+func EthMock(mocks MethodMocks) *httptest.Server {
+	return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		var req mockReq
+		if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
+			panic(err)
+		}
+
+		mock, ok := mocks[req.Method]
+		if !ok {
+			w.WriteHeader(http.StatusBadRequest)
+			if _, err := w.Write([]byte(fmt.Sprintf("method not in mocks: %s", req.Method))); err != nil {
+				panic(err)
+			}
+			return
+		}
+
+		res := &mockRes{
+			JsonRpc: req.JsonRpc,
+			ID:      req.ID,
+			Result:  mock,
+		}
+		w.WriteHeader(http.StatusOK)
+		if err := json.NewEncoder(w).Encode(res); err != nil {
+			panic(err)
+		}
+	}))
+}

pkg/mempool/db.go

@@ -26,7 +26,10 @@ func getEntryPointAndSenderFromDBKey(key []byte) (common.Address, common.Address
 
 func getUserOpFromDBValue(value []byte) (*userop.UserOperation, error) {
 	data := make(map[string]any)
-	json.Unmarshal(value, &data)
+	if err := json.Unmarshal(value, &data); err != nil {
+		return nil, err
+	}
+
 	op, err := userop.New(data)
 	if err != nil {
 		return nil, err

pkg/modules/checks/sanitychecks_test.go

@@ -0,0 +1,27 @@
+package checks
+
+import (
+	"testing"
+
+	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/ethclient"
+	"github.com/stackup-wallet/stackup-bundler/internal/testutils"
+	"github.com/stackup-wallet/stackup-bundler/pkg/userop"
+)
+
+// TestCheckSender calls checks.CheckSender where sender is existing contract and initCode is empty
+func TestCheckSender(t *testing.T) {
+	server := testutils.EthMock(testutils.MethodMocks{
+		"eth_getCode": "0x1234",
+	})
+	defer server.Close()
+
+	eth, _ := ethclient.Dial(server.URL)
+	op := &userop.UserOperation{
+		Sender:   common.HexToAddress("0x"),
+		InitCode: common.Hex2Bytes("0x"),
+	}
+	if err := checkSender(eth, op); err != nil {
+		t.Fatalf(`got err %v, want nil`, err)
+	}
+}