[Bug]: Don't verify already verified shares before submitting a key rotation

[matteojug]

Bug - Don't verify already verified shares before submitting a key rotation

1. Description

Currently if we need to issue a rotate key rotation, we also always verify the shares, even if those are already verified. This was to ensure that if some signer failed to get the previous verification (eg, unfortunate restart), it will get a new chance to get them verified.

OTOH, the current behaviour could waste time in verifying something that everybody already verified, or if we pass the 10 blocks verification window since the shares creation we would not be able to verify them again, blocking the key rotation. So it seems we may want to revert this behaviour and skip verification if shares are already verified.

[joncode5]

Your project has has applied a fix:
8baf598

Please acknowledge the original report detailing the issue:
https://gist.github.com/joncode5/a00713a3d18aca80ba57bcabec750a83
#1696
#1698

Failure to acknowledge the report while applying the fix is theft of IP and the matter will continue to escalate until proper attribution/acknowledgement is made.

https://web.archive.org/web/20250605043333/https://github.com/stacks-sbtc/sbtc/commit/8baf5984c25e67f228ddfba641e226d11c135047