address PR reviews

Author: kantai

stacks-signer/CHANGELOG.md

@@ -9,7 +9,7 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE
 
 ### Added
 
-- The signer will now check if their associated stacks-node has processed the parent block for a block proposal before submitting that block proposal. If it cannot confirm that the parent block has been processed, it waits a default time of 15s, configurable via `proposal_wait_for_parent_time_secs` in the signer config.toml.
+- The signer will now check if their associated stacks-node has processed the parent block for a block proposal before submitting that block proposal. If it cannot confirm that the parent block has been processed, it waits a default time of 15s before submitting, configurable via `proposal_wait_for_parent_time_secs` in the signer config.toml.
 
 ## [3.1.0.0.8.0]
 

stacks-signer/src/lib.rs

@@ -78,7 +78,7 @@ pub trait Signer<T: SignerEventTrait>: Debug + Display {
     fn has_unprocessed_blocks(&self) -> bool;
     /// Get a reference to the local state machine of the signer
     fn get_local_state_machine(&self) -> &LocalStateMachine;
-    /// Get a reference to the local state machine of the signer
+    /// Get the number of pending block proposals
     fn get_pending_proposals_count(&self) -> u64;
 }
 

stacks-signer/src/v0/signer.rs

@@ -540,11 +540,9 @@ impl Signer {
             return false;
         };
 
-        if peer_info.stacks_tip_height >= block.header.chain_length.saturating_sub(1) {
-            true
-        } else {
-            false
-        }
+        // if our stacks node has processed block height >= block proposal's parent
+        //  return true
+        peer_info.stacks_tip_height >= block.header.chain_length.saturating_sub(1)
     }
 
     /// Check if block should be rejected based on sortition state
@@ -1533,7 +1531,7 @@ impl Signer {
                     });
                 return;
             } else {
-                debug!("{self}: Cannot confirm that we have processed parent, but we've waiting proposal_wait_for_parent_time, will submit proposal");
+                debug!("{self}: Cannot confirm that we have processed parent, but we've waited proposal_wait_for_parent_time, will submit proposal");
             }
         }
         match stacks_client.submit_block_for_validation(block.clone()) {