remove unused default features

Author: Jiloc

stacks-common/Cargo.toml

@@ -30,26 +30,26 @@ name = "stacks_common"
 path = "./src/libcommon.rs"
 
 [dependencies]
-chrono = "0.4.19"
-curve25519-dalek = { version = "4.1.3", features = ["serde"] }
+chrono = { version = "0.4.41", default-features = false, features = ["clock"] }
+curve25519-dalek = { version = "4.1.3", default-features = false, features = ["serde"] }
 ed25519-dalek = { workspace = true }
 hashbrown = { workspace = true }
 lazy_static = { workspace = true }
-rand = { workspace = true, optional = true }
-ripemd = "0.1.1"
+ripemd = { version = "0.1.1", default-features = false }
 serde = { workspace = true , features = ["derive"] }
 serde_derive = { workspace = true }
 serde_json = { workspace = true }
-sha3 = "0.10.1"
+sha3 = { version = "0.10.1", default-features = false }
 slog = { workspace = true }
-slog-term = "2.6.0"
+slog-term = { version = "2.6.0", default-features = false }
 
 # Optional dependencies
-slog-json = { version = "2.3.0", optional = true }
 getrandom = { version = "0.2", default-features = false, optional = true }
+rand = { workspace = true, optional = true }
+slog-json = { version = "2.3.0", default-features = false, optional = true }
 
 [target.'cfg(unix)'.dependencies]
-nix = {version = "0.23", optional = true}
+nix = {version = "0.23", default-features = false, optional = true}
 
 [target.'cfg(windows)'.dependencies]
 winapi = { version = "0.3", features = [
@@ -60,7 +60,7 @@ winapi = { version = "0.3", features = [
 ], optional = true }
 
 [target.'cfg(not(target_family = "wasm"))'.dependencies]
-secp256k1 = { version = "0.24.3", features = ["serde", "recovery"] }
+secp256k1 = { version = "0.24.3", default-features = false, features = ["std","serde", "recovery"] }
 rusqlite = { workspace = true, optional = true }
 
 [target.'cfg(target_family = "wasm")'.dependencies]

stacks-common/src/deps_common/bitcoin/mod.rs

@@ -25,9 +25,6 @@
 //! software.
 //!
 
-// Clippy flags
-#![allow(clippy::needless_range_loop)] // suggests making a big mess of array newtypes
-
 // Coding conventions
 #![deny(non_upper_case_globals)]
 #![deny(non_camel_case_types)]

stacks-common/src/libcommon.rs

@@ -4,7 +4,6 @@
 #![allow(non_snake_case)]
 #![allow(non_upper_case_globals)]
 #![cfg_attr(test, allow(unused_variables, unused_assignments))]
-#![allow(clippy::assertions_on_constants)]
 
 #[allow(unused_imports)]
 #[macro_use(o, slog_log, slog_trace, slog_debug, slog_info, slog_warn, slog_error)]

stacks-common/src/types/chainstate.rs

@@ -168,8 +168,12 @@ impl SortitionId {
             write!(hasher, "{pox}").expect("Failed to deserialize PoX ID into the hasher");
             let h = Sha512Trunc256Sum::from_hasher(hasher);
             let s = SortitionId(h.0);
-            test_debug!("SortitionId({}) = {} + {}", &s, bhh, pox);
-            s
+            // The `test_debug!` macro will expand to nothing on release builds.
+            #[allow(clippy::let_and_return)]
+            {
+                test_debug!("SortitionId({}) = {} + {}", &s, bhh, pox);
+                s
+            }
         }
     }
 }

stacks-common/src/util/secp256k1/native.rs

@@ -609,6 +609,7 @@ mod tests {
             let key = Secp256k1PublicKey::from_hex(fixture.public_key).unwrap();
             let signature = MessageSignature::from_raw(&hex_bytes(fixture.signature).unwrap());
             let ver_res = key.verify(&hex_bytes(fixture.data).unwrap(), &signature);
+            #[allow(clippy::assertions_on_constants)]
             match (ver_res, fixture.result) {
                 (Ok(true), Ok(true)) => {}
                 (Ok(false), Ok(false)) => {}