CRC: cleanup

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>

Author: jferrant

clarity/src/vm/database/sqlite.rs

@@ -155,10 +155,7 @@ impl SqliteConnection {
             "INSERT INTO metadata_table (blockhash, key, value) VALUES (?, ?, ?)",
             params,
         ) {
-            error!(
-                "Failed to insert ({bhh},{key},{}): {e:?}",
-                &value.to_string()
-            );
+            error!("Failed to insert ({bhh},{key},{value}): {e:?}");
             return Err(InterpreterError::DBError(SQL_FAIL_MESSAGE.into()).into());
         }
         Ok(())

clarity/src/vm/tests/simple_apply_eval.rs

@@ -969,10 +969,9 @@ fn test_sequence_comparisons_clarity2() {
     // Note: Execute against Clarity2.
     success_tests.iter().for_each(|(program, expectation)| {
         assert_eq!(
-            expectation.clone(),
-            vm_execute_v2(program).unwrap().unwrap(),
-            "{program:?}, {:?}",
-            expectation.clone()
+            expectation,
+            &vm_execute_v2(program).unwrap().unwrap(),
+            "{program:?}, {expectation:?}"
         )
     });
 }

clarity/src/vm/types/mod.rs

@@ -1491,7 +1491,7 @@ impl fmt::Display for PrincipalData {
 impl fmt::Display for CallableData {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         if let Some(trait_identifier) = &self.trait_identifier {
-            write!(f, "({} as <{trait_identifier}>)", self.contract_identifier,)
+            write!(f, "({} as <{trait_identifier}>)", self.contract_identifier)
         } else {
             write!(f, "{}", self.contract_identifier,)
         }

stacks-common/src/util/uint.rs

@@ -556,7 +556,7 @@ mod tests {
             0xFFFFFFFFFFFFFFFF,
         ]);
         assert_eq!(
-            format!("{max_val}"),
+            max_val.to_string(),
             "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
         );
     }