cleanup core-build-tests workflow for upstream PR

Author: wileyj

.github/workflows/core-build-tests.yml

@@ -27,15 +27,8 @@ jobs:
         uses: actions-rust-lang/setup-rust-toolchain@11df97af8e8102fd60b60a77dfbf58d40cd843b8 # v1.10.1
         with:
           toolchain: ${{ env.RUST_TOOLCHAIN }}
-      ## run the cargo check steps with
-
-      ## this step fails on the unused imports
-      - name: Cargo Check (clarity)
-        # if: ${{ false }}
-        id: cargo_check_clarity
-        run: |
-          RUSTFLAGS="" cargo check -p clarity --no-default-features
 
+      ## run cargo check steps
       - name: Cargo Check
         id: cargo_check
         run: |
@@ -46,12 +39,11 @@ jobs:
         run: |
           cargo check --features monitoring_prom
 
-      # ## this step fails on the unused imports
-      # - name: Cargo Check (clarity)
-      #   # if: ${{ false }}
-      #   id: cargo_check_clarity
-      #   run: |
-      #     cargo check -p clarity --no-default-features
+      ## by default, RUSTFLAGS is set with `-D warnings`, which will fail this step. we run this with an empty RUSTFLAGS so the warnings won't cause a step failure
+      - name: Cargo Check (clarity)
+        id: cargo_check_clarity
+        run: |
+          RUSTFLAGS="" cargo check -p clarity --no-default-features
 
       - name: Cargo Check (stacks-common)
         id: cargo_check_stacks-common
@@ -63,8 +55,8 @@ jobs:
         run: |
           cargo run --bin stacks-inspect -- dump-consts | tee out.json
 
+      ## output any diff to the github job summary
       - name: Compare expected constants JSON
         id: expects-json
         run: |
-          # if there is a diff, return will be non-zero
           diff out.json ./sample/expected_consts.json >> $GITHUB_STEP_SUMMARY