test: fix transfer counting assertion

assertion should not include phantom txs. timing changes around the signer status checks made this more likely.

Author: kantai

testnet/stacks-node/src/nakamoto_node/signer_coordinator.rs

@@ -298,7 +298,10 @@ impl SignerCoordinator {
             );
 
             match res {
-                Err(NakamotoNodeError::SignatureTimeout) => continue,
+                Err(NakamotoNodeError::SignatureTimeout) => {
+                    info!("Block proposal signing process timed out, resending the same proposal");
+                    continue;
+                }
                 _ => return res,
             }
         }

testnet/stacks-node/src/tests/signer/v0.rs

@@ -35,7 +35,7 @@ use stacks::chainstate::burn::db::sortdb::SortitionDB;
 use stacks::chainstate::burn::operations::LeaderBlockCommitOp;
 use stacks::chainstate::coordinator::comm::CoordinatorChannels;
 use stacks::chainstate::nakamoto::{NakamotoBlock, NakamotoBlockHeader, NakamotoChainState};
-use stacks::chainstate::stacks::address::PoxAddress;
+use stacks::chainstate::stacks::address::{PoxAddress, StacksAddressExtensions};
 use stacks::chainstate::stacks::boot::MINERS_NAME;
 use stacks::chainstate::stacks::db::{StacksBlockHeaderTypes, StacksChainState, StacksHeaderInfo};
 use stacks::chainstate::stacks::miner::{TransactionEvent, TransactionSuccessEvent};
@@ -12105,7 +12105,10 @@ fn transfers_in_block(block: &serde_json::Value) -> usize {
         let tx_bytes = hex_bytes(&raw_tx[2..]).unwrap();
         let parsed = StacksTransaction::consensus_deserialize(&mut &tx_bytes[..]).unwrap();
         if let TransactionPayload::TokenTransfer(..) = &parsed.payload {
-            count += 1;
+            // don't count phantom unlock transactions (identified as transfers from the boot addr)
+            if !parsed.get_origin().address_testnet().is_boot_code_addr() {
+                count += 1;
+            }
         }
     }
     count