chore: remove x_replay_rejected_for_invalid_proposal_due_to_partial_replay, because we want to allow this behaviour. #5971

Author: fdefelici

testnet/stacks-node/src/tests/signer/v0.rs

@@ -3760,164 +3760,6 @@ fn tx_replay_disagreement() {
     miners.shutdown();
 }
 
-#[test]
-#[ignore]
-/// Demonstrates Tx Replay reject a proposal with partial replayed transactions,
-/// when not due to a Tenure Extend
-///
-/// The test flow is:
-///
-/// - Boot to Epoch 3
-/// - Mine 3 tenures
-/// - Submit 2 STX transfers (Tx1, Tx2) in the last tenure
-/// - Trigger a Bitcoin fork
-/// - Verify that signers move into tx replay state [Tx1, Tx2]
-/// - Force Miner to do partial replay (only Tx1)
-/// - Signers should reject miner proposal
-/// - In the end, Tx Replay Set remains unchanged [Tx1, Tx2]
-fn tx_replay_rejected_for_invalid_proposal_due_to_partial_replay() {
-    if env::var("BITCOIND_TEST") != Ok("1".into()) {
-        return;
-    }
-
-    let num_signers = 5;
-    let sender1_sk = Secp256k1PrivateKey::random();
-    let sender1_addr = tests::to_addr(&sender1_sk);
-    let send_amt = 100;
-    let send_fee = 180;
-    let num_txs = 2;
-    let signer_test: SignerTest<SpawnedSigner> = SignerTest::new_with_config_modifications(
-        num_signers,
-        vec![(sender1_addr, (send_amt + send_fee) * num_txs)],
-        |c| {
-            c.validate_with_replay_tx = true;
-        },
-        |node_config| {
-            node_config.miner.block_commit_delay = Duration::from_secs(1);
-            node_config.miner.replay_transactions = true;
-        },
-        None,
-        None,
-    );
-    let conf = &signer_test.running_nodes.conf;
-    let btc_controller = &signer_test.running_nodes.btc_regtest_controller;
-    let counters = &signer_test.running_nodes.counters;
-    let http_origin = format!("http://{}", &conf.node.rpc_bind);
-    let stacks_miner_pk = StacksPublicKey::from_private(&conf.miner.mining_key.unwrap());
-
-    signer_test.boot_to_epoch_3();
-    info!("------------------------- Reached Epoch 3.0 -------------------------");
-
-    let pre_fork_tenures = 3;
-    for i in 0..pre_fork_tenures {
-        info!("Mining pre-fork tenure {} of {pre_fork_tenures}", i + 1);
-        signer_test.mine_nakamoto_block(Duration::from_secs(30), true);
-    }
-    signer_test.check_signer_states_normal();
-
-    // Make transfer txs (these will get forked)
-    let (sender1_tx1, sender1_nonce) = signer_test
-        .submit_transfer_tx(&sender1_sk, send_fee, send_amt)
-        .unwrap();
-    signer_test
-        .wait_for_nonce_increase(&sender1_addr, sender1_nonce)
-        .expect("Expect sender1 nonce increased");
-
-    let (sender1_tx2, sender1_nonce) = signer_test
-        .submit_transfer_tx(&sender1_sk, send_fee, send_amt)
-        .unwrap();
-    signer_test
-        .wait_for_nonce_increase(&sender1_addr, sender1_nonce)
-        .expect("Expect sender1 nonce increased");
-
-    let sender1_nonce = get_account(&http_origin, &sender1_addr).nonce;
-    assert_eq!(2, sender1_nonce);
-
-    info!("------------------------- Triggering Bitcoin Fork -------------------------");
-    let tip = get_chain_info(&conf);
-    let burn_header_hash_to_fork = btc_controller.get_block_hash(tip.burn_block_height - 2);
-    btc_controller.invalidate_block(&burn_header_hash_to_fork);
-    btc_controller.build_next_block(3);
-    // note, we should still have normal signer states!
-    signer_test.check_signer_states_normal();
-
-    info!("Wait for block off of shallow fork");
-    TEST_MINE_STALL.set(true);
-
-    let submitted_commits = counters.naka_submitted_commits.clone();
-    // we need to mine some blocks to get back to being considered a frequent miner
-    for i in 0..3 {
-        let current_burn_height = get_chain_info(&conf).burn_block_height;
-        info!(
-            "Mining block #{i} to be considered a frequent miner";
-            "current_burn_height" => current_burn_height,
-        );
-        let commits_count = submitted_commits.load(Ordering::SeqCst);
-        next_block_and(btc_controller, 60, || {
-            Ok(submitted_commits.load(Ordering::SeqCst) > commits_count)
-        })
-        .unwrap();
-    }
-
-    signer_test
-        .wait_for_signer_state_check(30, |state| {
-            let Some(tx_replay_set) = state.get_tx_replay_set() else {
-                return Ok(false);
-            };
-            let len_ok = tx_replay_set.len() == 2;
-            let txid_ok = tx_replay_set[0].txid().to_hex() == sender1_tx1
-                && tx_replay_set[1].txid().to_hex() == sender1_tx2;
-            Ok(len_ok && txid_ok)
-        })
-        .expect("Timed out waiting for tx replay set to be updated");
-
-    // We should have forked 2 txs
-    let sender1_nonce_post_fork = get_account(&http_origin, &sender1_addr).nonce;
-    assert_eq!(0, sender1_nonce_post_fork);
-
-    info!("------------------------- Partial Tx Replay (only Tx1) -------------------------");
-    test_observer::clear();
-    TEST_MINE_ALLOWED_REPLAY_TXS.set(vec![sender1_tx1.clone()]);
-    TEST_MINE_STALL.set(false);
-
-    // First, a Tenure Change block mined
-    let tip = get_chain_info(&conf);
-    _ = wait_for_tenure_change_tx(30, TenureChangeCause::BlockFound, tip.stacks_tip_height + 1);
-
-    // Then, expect next block proposal to contain just Tx1
-    let block_prop = wait_for_block_proposal(30, tip.stacks_tip_height + 2, &stacks_miner_pk)
-        .expect("Time out waiting for block proposal");
-    assert_eq!(1, block_prop.txs.len());
-    assert_eq!(sender1_tx1, block_prop.txs[0].txid().to_hex());
-
-    // Signers should reject this proposal, because not justified (e.g. tenure extend)
-    wait_for_block_global_rejection_with_reject_reason(
-        30,
-        block_prop.header.signer_signature_hash(),
-        num_signers,
-        RejectReason::ValidationFailed(ValidateRejectCode::InvalidTransactionReplay),
-    )
-    .expect("Time out waiting for global block rejection due to invalid tx replay");
-
-    // Tx Replay Set remains untouched
-    signer_test
-        .wait_for_signer_state_check(30, |state| {
-            let Some(tx_replay_set) = state.get_tx_replay_set() else {
-                return Ok(false);
-            };
-            let len_ok = tx_replay_set.len() == 2;
-            let txid_ok = tx_replay_set[0].txid().to_hex() == sender1_tx1
-                && tx_replay_set[1].txid().to_hex() == sender1_tx2;
-            Ok(len_ok && txid_ok)
-        })
-        .expect("Timed out waiting for tx replay set to be updated");
-
-    let sender1_nonce = get_account(&http_origin, &sender1_addr).nonce;
-    assert_eq!(0, sender1_nonce);
-
-    signer_test.shutdown();
-}
-
 #[test]
 #[ignore]
 /// Demonstrates that transaction replay can be "solved" using mempool transactions,