refactor: avoid duplication in send_block_response

Author: obycode

stacks-signer/src/v0/signer.rs

@@ -478,6 +478,22 @@ impl Signer {
         }
     }
 
+    /// The actual `send_block_response` implementation. Declared so that we do
+    /// not need to duplicate in testing.
+    fn impl_send_block_response(&mut self, block_response: BlockResponse) {
+        let res = self
+            .stackerdb
+            .send_message_with_retry::<SignerMessage>(block_response.clone().into());
+        match res {
+            Err(e) => warn!("{self}: Failed to send block rejection to stacker-db: {e:?}"),
+            Ok(ack) if !ack.accepted => warn!(
+                "{self}: Block rejection not accepted by stacker-db: {:?}",
+                ack.reason
+            ),
+            Ok(_) => debug!("{self}: Block rejection accepted by stacker-db"),
+        }
+    }
+
     #[cfg(any(test, feature = "testing"))]
     fn send_block_response(&mut self, block_response: BlockResponse) {
         const NUM_REPEATS: usize = 1;
@@ -489,17 +505,7 @@ impl Signer {
             count = NUM_REPEATS;
         }
         while count <= NUM_REPEATS {
-            let res = self
-                .stackerdb
-                .send_message_with_retry::<SignerMessage>(block_response.clone().into());
-            match res {
-                Err(e) => warn!("{self}: Failed to send block rejection to stacker-db: {e:?}"),
-                Ok(ack) if !ack.accepted => warn!(
-                    "{self}: Block rejection not accepted by stacker-db: {:?}",
-                    ack.reason
-                ),
-                Ok(_) => debug!("{self}: Block rejection accepted by stacker-db"),
-            }
+            self.impl_send_block_response(block_response.clone());
 
             count += 1;
             sleep_ms(1000);
@@ -508,17 +514,7 @@ impl Signer {
 
     #[cfg(not(any(test, feature = "testing")))]
     fn send_block_response(&mut self, block_response: BlockResponse) {
-        let res = self
-            .stackerdb
-            .send_message_with_retry::<SignerMessage>(block_response.clone().into());
-        match res {
-            Err(e) => warn!("{self}: Failed to send block rejection to stacker-db: {e:?}"),
-            Ok(ack) if !ack.accepted => warn!(
-                "{self}: Block rejection not accepted by stacker-db: {:?}",
-                ack.reason
-            ),
-            Ok(_) => debug!("{self}: Block rejection accepted by stacker-db"),
-        }
+        self.impl_send_block_response(block_response)
     }
 
     /// Handle block proposal messages submitted to signers stackerdb