feat: clear tx_replay_set when a new block is mined

Author: hstove

stacks-signer/src/v0/signer_state.rs

@@ -643,6 +643,9 @@ impl LocalStateMachine {
             }
         };
 
+        // No matter what, if we're in tx replay mode, remove the tx replay set
+        prior_state_machine.tx_replay_set = None;
+
         let MinerState::ActiveMiner {
             parent_tenure_id,
             parent_tenure_last_block,

testnet/stacks-node/src/tests/signer/v0.rs

@@ -2901,6 +2901,16 @@ fn tx_replay_forking_test() {
 
     TEST_MINE_STALL.set(false);
 
+    // Now, make a new stacks block, which should clear the tx replay set
+    signer_test.mine_nakamoto_block(Duration::from_secs(30), true);
+    let (signer_states, _) = signer_test.get_burn_updated_states();
+    for state in signer_states {
+        assert!(
+            state.get_tx_replay_set().is_none(),
+            "Signer state is in tx replay state, when it shouldn't be"
+        );
+    }
+
     signer_test.shutdown();
 }