ROX-19024: Remove RHCOS FF (#1245)

Author: Maddosaurus

api/v1/nodescan/service.go

@@ -21,7 +21,6 @@ import (
 	"github.com/stackrox/scanner/ext/versionfmt"
 	v1 "github.com/stackrox/scanner/generated/scanner/api/v1"
 	k8scache "github.com/stackrox/scanner/k8s/cache"
-	featureFlags "github.com/stackrox/scanner/pkg/features"
 	"github.com/stackrox/scanner/pkg/repo2cpe"
 	"github.com/stackrox/scanner/pkg/version"
 	"github.com/stackrox/scanner/pkg/wellknownnamespaces"
@@ -242,7 +241,7 @@ func (s *serviceImpl) getRuntimeVulns(containerRuntime *v1.GetNodeVulnerabilitie
 
 func (s *serviceImpl) GetNodeVulnerabilities(ctx context.Context, req *v1.GetNodeVulnerabilitiesRequest) (*v1.GetNodeVulnerabilitiesResponse, error) {
 	// If NodeInventory is empty `req.GetComponents() == nil` then fallback to v1 scanning
-	if req.GetComponents() == nil || !featureFlags.RHCOSNodeScanning.Enabled() {
+	if req.GetComponents() == nil {
 		return s.getNodeVulnerabilitiesLegacy(ctx, req)
 	}
 

chart/templates/deployment.yaml

@@ -28,8 +28,6 @@ spec:
               fieldPath: metadata.name
         - name: ROX_SKIP_PEER_VALIDATION
           value: "true"
-        - name: ROX_RHCOS_NODE_SCANNING
-          value: "true"
         - name: ROX_ACTIVE_VULN_MGMT
           value: "true"
         resources:

pkg/features/list.go

@@ -5,7 +5,4 @@ var (
 	ContinueUnknownOS = registerFeature("Enable continuation upon detecting unknown OS", "ROX_CONTINUE_UNKNOWN_OS", true)
 	// RHEL9Scanning enables support for scanning RHEL9-based images.
 	RHEL9Scanning = registerFeature("Enable support for scanning RHEL9 images", "ROX_RHEL9_SCANNING", true)
-
-	// RHCOSNodeScanning enables phase 1 functions of "Full host level vulnerability scanning for RHCOS nodes" (ROX-10818)
-	RHCOSNodeScanning = registerFeature("Enabling Full host level vulnerability scanning for RHCOS nodes", "ROX_RHCOS_NODE_SCANNING", true)
 )