Skip to content

Commit d89a4a4

Browse files
ekzyishuumn
andauthored
Wallet v2 (#2169)
* Migrate vault entries to new schema (#2092) * Migrate existing vault entries to new schema * Read+write new vault schema * Drop VaultEntry table * Refactor vaultPrismaFragments * Remove wrong comment * Remove TODO * Fix possible race condition on update of vault key * Remove lib/object.js * Wallet schema v2 (#2146) * Add wallet-v2 TODOs * Update checkWallet * Wallet list * Delete almost all wallet v1 code and add some code for wallet protocol forms * Define protocol display name in JSON * Show form per protocol * Increase max-height of image in form * Add JSdoc for protocols, form validation * Use wallet cards again My wallet list was quite ugly and I couldn't look at it anymore. * Refactor hooks in wallet provider * Fix PasswordInput not used * Read encrypted wallets * Decrypt wallets * useWalletQuery now returns decrypted wallets * Refactor useIndexedDB because its only purpose will be to store the key, so no need for pagination code etc. * There is still a bug: if the wallet is not decrypted on first render, the form will not see the decrypted value. See TODO. * Rename protocolJson to protocol it no longer uses a JSON file * Fix form not updated with decrypted API key * Fix wallet template forms * Fix optional shown as hint * Rename to mapUserWalletResolveTypes * Save LNbits send and recv TODO: * implement resolvers for other protocols * fix double update required for trigger? * add missing validation on server * add missing network tests * don't import from wallets/client on server * Move definitions to lib/wallets.json and lib/protocols * Fix ProtocolWallet.updated_at not updated by trigger * Move wallet fragments into wallets/client/fragments/ * move invoice fragments to fragments/invoice.js * remove some unused fragments that I don't think I also will not use * move fragments that will be generated in own file * Move wallet resolvers into wallets/server/resolvers * Fix missing authorization check on wallet update * Run all shared code in generic wallet update function * Fix 'encrypt' flag not set for blink send currency * Add mutations for all protocols * Fix macaroon validation * Fix CLN socket value not set * Add server-side schema validation * Fix JSDoc typedef for protocols * Don't put JSDoc into separate file * Create test invoices on save * Also move type resolvers into wallets/server/resolvers * Fix unconfigured protocols of UserWallet not found * Fix Blink API key in wallet seed * Test send payment on save (except LNC) This does not include LNC because LNC cannot be saved yet * Check if window.webln is defined on save * Create new wallets from templates * Separate protocols in wallets/lib into individual files * Use justify-content-start for protocol tabs and larger margin at the top * Add LNC to client protocols * Only return wallets from useWallets * Query decrypted wallets * Payments with new wallets * More wallet logos * Fix TypeError in useIndexedDB * Add protocol attach docs * Fix undefined useWalletRecvPrompt import * Remove outdated TODOs * First successful zap to new wallets * Fix walletLogger imports * Fix sequences * the sequences for InvoiceForward and DirectPayment were still starting at 1 * when using setval() with two arguments, nextval() will return the second argument+1 (see https://www.postgresql.org/docs/current/functions-sequence.html) * Rename ProtocolWallet columns * Remove more outdated TODOs * Update wallet indicator * Fix page reset on route change * Refactor __typename checks into functions * Refactor protocol selection into own hook * Add button to detach protocol * Refetch wallet on save and detach * Refetch wallets on change * Always show all templates * Refactor WalletLink component * Also put wallet into forms context * Remove outdated TODOs * Use useMemo in wallets hooks * Passphrase modals * prompt for password if decryption failed * add button to reveal passphrase on wallet page TODO: * remove button if passphrase was revealed or imported * encrypt wallets with new key on passphrase reveal * Fix protocol missing as callback dependency * Encrypt wallets with new key on passphrase export * Update 'unlock wallets' text * Rename wallet mutation hooks * Remove 'removeWallet' mutation Wallets are automatically deleted when all protocols are deleted * Passphrase reset * Use 110px as minimum width for bip39 words longest bip39 words are 8 characters and they fit into 103px so I rounded up to 110px. * Also disable passphrase export on save * Wallet settings * Fix wallet receive prompt * Remove unused parameters from postgres function * Rename UserWallet to Wallet, ProtocolWallet to WalletProtocol * Use danger variant for button to show passphrase * Fix inconsistent imports and exports * Remove outdated TODOs * wallet logs * Remove outdated comment * Make sure wallets are used in priority order * Separate wallets from templates in reducer * Fix missing useCallback dependencies * Refactor with useWalletLogger hook * Move enabled to WalletProtocol * Add checkbox to enable/disable protocol * Fix migration with prod db dump * Parse Coinos relay URLs * Skip network tests if only enabled changed * Allow IndexedDB calls without session * Add code to migrate old CryptoKey * first try to use existing CryptoKey before generating a new one * bump IDB version to delete old object stores and create new ones * return IDB callbacks with useMemo * don't delete old IDB right away, wait until next release * Fix ghost import error *Sometimes*, I get import errors because it tries to resolve @/wallets/server to wallets/server.js instead of wallets/server/index.js. For the files in wallets/server, it kind of makes sense because it's a circular import. But I don't know why the files in worker/ have this problem. Interestingly, it only seems to happen with walletLogger imports, so I guess its related to its import chain. Anyway, this commit should make sure this never happens again ... * Skip wallets queries if not logged in * Split CUSTOM wallet into NWC and LN_ADDR * Migrate local wallets * Link to /wallets/:id/receive if send not supported * Hide separator if there are no configured wallets * Save LNC * Add one-liner to attach LNC * Update wallet priorities via DnD * Wallet logs are part of protocol resolvers * Fix logging to deleted protocol * Fix trying to fetch logs for template * also change type to Int so GraphQL layer can catch trying to fetch string IDs as is the case for templates * Fix embedded flag for wallets logs not set * Remove TODO * Decrease max-height for embedded wallet logs on big screens * Fix missing refetch on wallet priority update * Set priorities of all wallets in one tx * Fix nested state update * Add DragIcon * DnD mobile support and refactor * Add CancelButton to wallet settings * Remount form if path changes This fixes the following warning in the console: """ Warning: A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component. """ * Support string and object for wallet.image JSON * Append domain to lightning address inputs * Remove outdated TODOs * Add template IDs to wallet JSON * Fix missing callback dependency * Implement lightning address save in receive prompt * Update TODOs * Fix missing check for enabled * Pay QR codes with WebLN as anon * Add logo for NWC * Fix trying to save logs for template * Add template logs * Fix inconsistent margin * Always throw on missing key * Remove misleading comment Wallets are returned even if decryption fails so we can show the unlock page if a wallet is stored as encrypted in the context. Maybe I should rethink this. * Check for existing wallets on local wallet migration * Fix local wallet migration causing duplicates * Fix protocol reattached on detach due to migration * Fix form not centered * Fix ZEUS lightning address domain * Add placeholder, help, hints etc. to wallet form inputs * Fix wallet badges not updated * Remove unused declared variables * Rename to ATTACH_PAGE * Fix 500 error if no amount was given to LNURLp endpoint * Tag log messages with wallet name * Only skip network tests if we're disabling the wallet * Rename var to networkTests * Continue to store key hash in IndexedDB * Rethink wallet state management If decryption failed, the function to decrypt the wallets didn't throw but simply returned wallets that were still encrypted. This was bad because it meant we could not rely on the wallets in the state being decrypted, even though this was the original idea behind the query hooks: hide the details of encryption and decryption inside them. Because of this, we had to check if the wallets were still encrypted before we ran the wallet migration since we want to check if a protocol already exists. This commit fixes this by making encryption and decryption always throw (and catching the errors), as well as returning a ready state from hooks. A hook might not be ready because it still needs to load something (in the case of the crypto hooks, it's loading the key from IndexedDB). Callers check that ready state before they call the function returned by the hook. So now, the wallet migration hook can itself simply check if the hook to encrypt wallets is ready and if the wallets are no longer loading to let callers know if it itself is ready. Since we also relied on wallets stored as encrypted in the context to show the unlock page, this was also changed by comparing the local and remote key hash. * Add empty line * Save new key hash during wallet reset * Only receive protocol upserts require networkTests param * Compare key hashes on server on each save * Delete old code * Fix card shows attach instead of configure * Fix empty wallets created during migration The old schema can contain '' instead of NULL in the columns of wallets for receiving. * Update reset passphrase text * Wrap passphrase reset in try/catch * Fix migrate called multiple times * Update key hash on migration if not set * Fetch local wallets in migrate * Fix missing await on setKey * Let first device set key hash * Fix indicator not shown if wallets locked * Check if IndexedDB is available * Fix inconsistent WebLN error message * Disable WebLN if not available * Remove outdated TODO * Cursor-based pagination for wallet logs * Fix log message x-overflow * Add context to wallet logs * Wrap errors are warnings in logs * Rename wallet v2 migrations * Update wallet status during logging * Fix wallet logs loading state The loading state would go from false -> true -> false because it's false when the lazy query wasn't called yet. * Add wallet search * Add Alby Go wallet * Revert "Add Alby Go wallet" This reverts commit 926c706. * Fix wallet logs sent by client don't update protocol status * Fix mutation name * put drag icon on opposite corner * Add wallets/README.md * Fix inconsistent case in wallets/README.md * Fix autoprefixer warning about mixed support This warning was in the app logs: app | Warning app | app | (31:3) autoprefixer: end value has mixed support, consider using flex-end instead app | app | Import trace for requested module: app | ./styles/wallet.module.css app | ./wallets/client/hooks/prompt.js app | ./wallets/client/hooks/index.js app | ./wallets/client/context/hooks.js app | ./wallets/client/context/provider.js app | ./wallets/client/context/index.js * fix effect of wallet indicators on logo * Fix deleting wallet template logs * Use name as primary key of WalletTemplate * Fix wallet_clear_vault trigger not mentioned in README * Fix wallet receive prompt Also remove no longer needed templateId from wallets.json and helper functions * Use findUnique since name is now primary key * Merge Alby wallets into one * Remove unused name parameter from WalletsForm component * Fix number check to decide if wallet or template * Update wallet encryption on click, not as effect * add cashu.me and lightning address logos * add images * Use recommended typeof to check if IDB available * Also check if IDB available on delete * Use constraint triggers * Add indices on columns used for joins * Fix inconsistent CLEAR OR REPLACE TRIGGER * Attach wallet_check_support trigger to WalletProtocol table * Update wallets/README.md * Remove debugging code * Refactor reducer: replace page with status * Show 'wallets unavailable' if device does not support IndexedDB * Remove duplicate ELSIF condition * Fix hasSendWallet The useSendWallets hook was not checking if the returned send wallets are enabled. Since the components that used that hook only need to know if there is a send wallet, I replaced the useSendWallets hook with a useHasSendWallet hook. * Add Cash App wallet * fix changes loglevel enum * Fix key init race condition in strict mode if no key exists yet * Formatting * Fix key init race condition via transactions in readwrite mode * Replace Promise.withResolvers with regular promises * replace generic spinner with our usual --------- Co-authored-by: k00b <k00b@stacker.news>
1 parent df299a2 commit d89a4a4

File tree

208 files changed

+8547
-4969
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

208 files changed

+8547
-4969
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ docker-compose.*.yml
5353
*.sql
5454
!/prisma/migrations/*/*.sql
5555
!/docker/db/seed.sql
56+
!/docker/db/wallet-seed.sql
5657

5758
# nostr wallet connect
5859
scripts/nwc-keys.json

api/paidAction/index.js

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ async function performP2PAction (actionType, args, incomingContext) {
227227
await assertBelowMaxPendingInvoices(incomingContext)
228228

229229
const description = await paidActions[actionType].describe(args, incomingContext)
230-
const { invoice, wrappedInvoice, wallet, maxFee } = await createWrappedInvoice(userId, {
230+
const { invoice, wrappedInvoice, protocol, maxFee } = await createWrappedInvoice(userId, {
231231
msats: cost,
232232
feePercent: sybilFeePercent,
233233
description,
@@ -239,7 +239,7 @@ async function performP2PAction (actionType, args, incomingContext) {
239239
invoiceArgs: {
240240
bolt11: invoice,
241241
wrappedBolt11: wrappedInvoice,
242-
wallet,
242+
protocol,
243243
maxFee
244244
}
245245
}
@@ -269,7 +269,7 @@ async function performDirectAction (actionType, args, incomingContext) {
269269

270270
const description = actionDescription ?? await paidActions[actionType].describe(args, incomingContext)
271271

272-
for await (const { invoice, logger, wallet } of createUserInvoice(userId, {
272+
for await (const { invoice, logger, protocol } of createUserInvoice(userId, {
273273
msats: cost,
274274
description,
275275
expiry: INVOICE_EXPIRE_SECS
@@ -293,7 +293,7 @@ async function performDirectAction (actionType, args, incomingContext) {
293293
bolt11: invoice,
294294
msats: cost,
295295
hash,
296-
walletId: wallet.id,
296+
protocolId: protocol.id,
297297
receiverId: userId
298298
}
299299
}),
@@ -346,22 +346,26 @@ export async function retryPaidAction (actionType, args, incomingContext) {
346346
invoiceId: failedInvoice.id
347347
},
348348
include: {
349-
wallet: true
349+
protocol: {
350+
include: {
351+
wallet: true
352+
}
353+
}
350354
}
351355
})
352356

353357
if (invoiceForward) {
354358
// this is a wrapped invoice, we need to retry it with receiver fallbacks
355359
try {
356-
const { userId } = invoiceForward.wallet
360+
const { userId } = invoiceForward.protocol.wallet
357361
// this will return an invoice from the first receiver wallet that didn't fail yet and throw if none is available
358-
const { invoice: bolt11, wrappedInvoice: wrappedBolt11, wallet, maxFee } = await createWrappedInvoice(userId, {
362+
const { invoice: bolt11, wrappedInvoice: wrappedBolt11, protocol, maxFee } = await createWrappedInvoice(userId, {
359363
msats: failedInvoice.msatsRequested,
360364
feePercent: await action.getSybilFeePercent?.(actionArgs, retryContext),
361365
description: await action.describe?.(actionArgs, retryContext),
362366
expiry: INVOICE_EXPIRE_SECS
363367
}, retryContext)
364-
invoiceArgs = { bolt11, wrappedBolt11, wallet, maxFee }
368+
invoiceArgs = { bolt11, wrappedBolt11, protocol, maxFee }
365369
} catch (err) {
366370
console.log('failed to retry wrapped invoice, falling back to SN:', err)
367371
}
@@ -429,7 +433,7 @@ async function createSNInvoice (actionType, args, context) {
429433

430434
async function createDbInvoice (actionType, args, context) {
431435
const { me, models, tx, cost, optimistic, actionId, invoiceArgs, paymentAttempt, predecessorId } = context
432-
const { bolt11, wrappedBolt11, preimage, wallet, maxFee } = invoiceArgs
436+
const { bolt11, wrappedBolt11, preimage, protocol, maxFee } = invoiceArgs
433437

434438
const db = tx ?? models
435439

@@ -468,9 +472,9 @@ async function createDbInvoice (actionType, args, context) {
468472
invoice: {
469473
create: invoiceData
470474
},
471-
wallet: {
475+
protocol: {
472476
connect: {
473-
id: wallet.id
477+
id: protocol.id
474478
}
475479
}
476480
}

api/paidAction/zap.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ export async function getInvoiceablePeer ({ id, sats, hasSendWallet }, { models,
3939
return null
4040
}
4141

42-
const wallets = await getInvoiceableWallets(item.userId, { models })
42+
const protocols = await getInvoiceableWallets(item.userId, { models })
4343

4444
// request peer invoice if they have an attached wallet and have not forwarded the item
4545
// and the receiver doesn't want to receive credits
46-
if (wallets.length > 0 &&
46+
if (protocols.length > 0 &&
4747
item.itemForwards.length === 0 &&
4848
sats >= item.user.receiveCreditsBelowSats) {
4949
return item.userId

api/payingAction/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import { parsePaymentRequest, payViaPaymentRequest } from 'ln-service'
66
// paying actions are completely distinct from paid actions
77
// and there's only one paying action: send
88
// ... still we want the api to at least be similar
9-
export default async function performPayingAction ({ bolt11, maxFee, walletId }, { me, models, lnd }) {
9+
export default async function performPayingAction ({ bolt11, maxFee, protocolId }, { me, models, lnd }) {
1010
try {
11-
console.group('performPayingAction', `${bolt11.slice(0, 10)}...`, maxFee, walletId)
11+
console.group('performPayingAction', `${bolt11.slice(0, 10)}...`, maxFee, protocolId)
1212

1313
if (!me) {
1414
throw new Error('You must be logged in to perform this action')
@@ -34,8 +34,8 @@ export default async function performPayingAction ({ bolt11, maxFee, walletId },
3434
msatsPaying: toPositiveBigInt(decoded.mtokens),
3535
msatsFeePaying: satsToMsats(maxFee),
3636
userId: me.id,
37-
walletId,
38-
autoWithdraw: !!walletId
37+
protocolId,
38+
autoWithdraw: !!protocolId
3939
}
4040
})
4141
}, { isolationLevel: Prisma.TransactionIsolationLevel.ReadCommitted })

api/resolvers/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import user from './user'
22
import message from './message'
33
import item from './item'
4-
import wallet from './wallet'
4+
import walletV1 from './wallet'
5+
import walletV2 from '@/wallets/server/resolvers'
56
import lnurl from './lnurl'
67
import notifications from './notifications'
78
import invite from './invite'
@@ -19,7 +20,6 @@ import chainFee from './chainFee'
1920
import { GraphQLScalarType, Kind } from 'graphql'
2021
import { createIntScalar } from 'graphql-scalar'
2122
import paidAction from './paidAction'
22-
import vault from './vault'
2323

2424
const date = new GraphQLScalarType({
2525
name: 'Date',
@@ -54,6 +54,6 @@ const limit = createIntScalar({
5454
maximum: 1000
5555
})
5656

57-
export default [user, item, message, wallet, lnurl, notifications, invite, sub,
57+
export default [user, item, message, walletV1, walletV2, lnurl, notifications, invite, sub,
5858
upload, search, growth, rewards, referrals, price, admin, blockHeight, chainFee,
59-
{ JSONObject }, { Date: date }, { Limit: limit }, paidAction, vault]
59+
{ JSONObject }, { Date: date }, { Limit: limit }, paidAction]

api/resolvers/vault.js

Lines changed: 0 additions & 53 deletions
This file was deleted.

0 commit comments

Comments
 (0)